validate import checks in python course environment setup - #3538
Closed
Dhairya Patel (HABER7789) wants to merge 111 commits into
Closed
validate import checks in python course environment setup#3538Dhairya Patel (HABER7789) wants to merge 111 commits into
Dhairya Patel (HABER7789) wants to merge 111 commits into
Conversation
Module names from course.json flowed into a `python -c` command line without validation, so a drop-in course could run random Python when someone ran the environment check. They now have to be dotted identifiers, and anything else is reported as a failed check rather than silently dropped. Also fixes the multiple-environments warning, which joined the environment objects directly and so logged [object Object] instead of their names.
A unit whose notebook has no exercise tagged cells produced an empty activities array and a switch to that course threw an error. This commit gives it one activitiy (in the form of lesson) so notebook can be opened and read.
Dhairya Patel (HABER7789)
force-pushed
the
HABER7789/python-learning-review
branch
from
August 7, 2026 19:40
7a48dc0 to
4a762f9
Compare
Quizzes are markdown with a details element, which reads fine but cannot report an answer back. This adds a renderer for a quiz mime type so a quiz can become a real widget. It is dependency-free and falls back to the next renderer on an unknown schema.
Focus mode hid the chrome itself, which meant owning a list of things to hide. This delegates to Zen Mode, then pulls the outline back and un-centres the layout so the workbook has room. Opening a course notebook now also points first-time learners at the sidebar.
Contributor
Author
|
Closing this PR since it was only being used as a reference for the environment-check work. That work is now part of #3568, so this PR is no longer needed and won’t be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Module names from course.json flowed into a
python -ccommand line without validation, so a drop-in course could run random Python when someone ran the environment check. They now have to be dotted identifiers, and anything else is reported as a failed check rather than silently dropped.Also fixes the multiple-environments warning, which joined the environment objects directly and so logged
[object Object]instead of their names.