Skip to content

Use theme aware SVG diagrams in the chemistry QPE course - #3631

Merged
Dhairya Patel (HABER7789) merged 3 commits into
mainfrom
HABER7789/chemistry-svg-diagrams
Aug 24, 2026
Merged

Use theme aware SVG diagrams in the chemistry QPE course#3631
Dhairya Patel (HABER7789) merged 3 commits into
mainfrom
HABER7789/chemistry-svg-diagrams

Conversation

@HABER7789

Copy link
Copy Markdown
Contributor

The chemistry course diagrams showed up as white boxes in dark themes. Nine of them are now inline SVG in the Markdown cells, so they follow whatever theme is active. They have to be inline rather than attachments, because an attachment renders as an that can't see the notebook's stylesheet.

The two orbital photos stay PNG since they are not line art, but their white background is now transparent so they work on either theme.

Addresses the diagram item in #3605.

@HABER7789
Dhairya Patel (HABER7789) force-pushed the HABER7789/chemistry-svg-diagrams branch from b501545 to 6dc99dd Compare August 22, 2026 03:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Chemistry QPE course to embed diagrams as inline SVGs while retaining transparent PNGs for photographic assets.

Changes:

  • Adds nine inline SVG course diagrams.
  • Updates conversion logic while preserving stable cell IDs.
  • Extends course verification and authoring documentation.

Reviewed changes

Copilot reviewed 4 out of 20 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
verify_course.py Validates expected SVGs and transparent PNG attachments.
rst_to_notebook.py Embeds local SVG assets and preserves legacy cell IDs.
README.md Documents image authoring behavior.
tutorial_qpe_workflow.svg Adds the QPE workflow diagram.
tutorial_qpe_wavefunction_hierarchy.svg Adds the wavefunction hierarchy diagram.
tutorial_qpe_state_preparation_comparison.svg Adds the state-preparation circuit comparison.
tutorial_qpe_power_one_circuit_overview.svg Adds the IQPE circuit overview.
tutorial_qpe_phase_wrapping.svg Adds the phase-wrapping plot.
tutorial_qpe_orbital_partition.svg Adds the orbital partition diagram.
tutorial_qpe_orbital_entropy.svg Adds the orbital entropy plot.
tutorial_qpe_jordan_wigner_parity.svg Adds the Jordan–Wigner parity diagram.
tutorial_qpe_iqpe_iteration.svg Adds the IQPE iteration flowchart.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread source/vscode/resources/qdk-learning/utils/chemistry-qpe/rst_to_notebook.py Outdated
Comment thread source/vscode/resources/qdk-learning/utils/chemistry-qpe/rst_to_notebook.py Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 20 changed files in this pull request and generated no new comments.

@amcasey Andrew Casey (amcasey) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I flicked through the themes and that looks way better

@HABER7789
Dhairya Patel (HABER7789) added this pull request to the merge queue Aug 24, 2026
Merged via the queue into main with commit 4b5a917 Aug 24, 2026
15 checks passed
@HABER7789
Dhairya Patel (HABER7789) deleted the HABER7789/chemistry-svg-diagrams branch August 24, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants