Use theme aware SVG diagrams in the chemistry QPE course - #3631
Merged
Dhairya Patel (HABER7789) merged 3 commits intoAug 24, 2026
Conversation
Dhairya Patel (HABER7789)
force-pushed
the
HABER7789/chemistry-svg-diagrams
branch
from
August 22, 2026 03:16
b501545 to
6dc99dd
Compare
Dhairya Patel (HABER7789)
force-pushed
the
HABER7789/chemistry-svg-diagrams
branch
from
August 22, 2026 03:18
6dc99dd to
9ba7528
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Chemistry QPE course to embed diagrams as inline SVGs while retaining transparent PNGs for photographic assets.
Changes:
- Adds nine inline SVG course diagrams.
- Updates conversion logic while preserving stable cell IDs.
- Extends course verification and authoring documentation.
Reviewed changes
Copilot reviewed 4 out of 20 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
verify_course.py |
Validates expected SVGs and transparent PNG attachments. |
rst_to_notebook.py |
Embeds local SVG assets and preserves legacy cell IDs. |
README.md |
Documents image authoring behavior. |
tutorial_qpe_workflow.svg |
Adds the QPE workflow diagram. |
tutorial_qpe_wavefunction_hierarchy.svg |
Adds the wavefunction hierarchy diagram. |
tutorial_qpe_state_preparation_comparison.svg |
Adds the state-preparation circuit comparison. |
tutorial_qpe_power_one_circuit_overview.svg |
Adds the IQPE circuit overview. |
tutorial_qpe_phase_wrapping.svg |
Adds the phase-wrapping plot. |
tutorial_qpe_orbital_partition.svg |
Adds the orbital partition diagram. |
tutorial_qpe_orbital_entropy.svg |
Adds the orbital entropy plot. |
tutorial_qpe_jordan_wigner_parity.svg |
Adds the Jordan–Wigner parity diagram. |
tutorial_qpe_iqpe_iteration.svg |
Adds the IQPE iteration flowchart. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This was referenced Aug 22, 2026
Dhairya Patel (HABER7789)
marked this pull request as ready for review
August 24, 2026 16:27
Dhairya Patel (HABER7789)
requested review from
Andrew Casey (amcasey),
Bill Ticehurst (billti) and
Ian Davis (idavis)
as code owners
August 24, 2026 16:27
Andrew Casey (amcasey)
approved these changes
Aug 24, 2026
Andrew Casey (amcasey)
left a comment
Member
There was a problem hiding this comment.
I flicked through the themes and that looks way better
Bill Ticehurst (billti)
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chemistry course diagrams showed up as white boxes in dark themes. Nine of them are now inline SVG in the Markdown cells, so they follow whatever theme is active. They have to be inline rather than attachments, because an attachment renders as an
that can't see the notebook's stylesheet.
The two orbital photos stay PNG since they are not line art, but their white background is now transparent so they work on either theme.
Addresses the diagram item in #3605.