Repository navigation
Fix consent theme initialization race - #1511
Merged
Cedric Vidal (cedricvidal) merged 6 commits intoOct 15, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
…rnetes-self-hosting
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Cedric Vidal (cedricvidal)
marked this pull request as ready for review
October 15, 2026 17:17
Cedric Vidal (cedricvidal)
requested a review
from Wassim Chegham (manekinekko)
as a code owner
October 15, 2026 17:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the post-merge Pages failure from
run 38772995219.
The consent UI theme observer now ignores writes that do not change the
resolved theme. This prevents a redundant initial
darkapplication whenStarlight and Mermaid initialize concurrently. The browser regression test
now verifies same-theme writes are ignored and real light/dark transitions
are applied.
Demos
N/A — website initialization and test-stability fix.
Before
N/A
After
N/A
Testing
cd website && SITE=https://microsoft.github.io BASE_PATH=/scope pnpm run build— passed
cd website && pnpm exec playwright test tests/analytics.spec.ts --grep 'consent UI follows Starlight theme changes'— passed, 4 testscd website && pnpm exec playwright test— passed, 68 testsDocumentation and compatibility
None. No API, CLI, or deployment compatibility impact.
Checklist
up()/down()and keep it CosmosDB-compatible. — N/A; no database change.NOTICE/NOTICE-REVIEW.txtwithpnpm noticeas needed. — N/A; no dependency change.