Skip to content

Fix consent theme initialization race - #1511

Merged
Cedric Vidal (cedricvidal) merged 6 commits into
mainfrom
cedricvidal-docs-kubernetes-self-hosting
Oct 15, 2026
Merged

Cedric Vidal (cedricvidal) merged 6 commits into
mainfrom
cedricvidal-docs-kubernetes-self-hosting

Conversation

@cedricvidal

Copy link
Copy Markdown
Collaborator

Summary

Fix the post-merge Pages failure from
run 38772995219.

The consent UI theme observer now ignores writes that do not change the
resolved theme. This prevents a redundant initial dark application when
Starlight and Mermaid initialize concurrently. The browser regression test
now verifies same-theme writes are ignored and real light/dark transitions
are applied.

Demos

N/A — website initialization and test-stability fix.

Before

N/A

After

N/A

Testing

  • cd website && SITE=https://microsoft.github.io BASE_PATH=/scope pnpm run build
    — passed
  • cd website && pnpm exec playwright test tests/analytics.spec.ts --grep 'consent UI follows Starlight theme changes' — passed, 4 tests
  • cd website && pnpm exec playwright test — passed, 68 tests

Documentation and compatibility

None. No API, CLI, or deployment compatibility impact.

Checklist

  • If Portal features changed, keep CLI capabilities in sync. — N/A; no Portal feature change.
  • If Portal components changed, update their Storybook stories. — N/A; no Portal component change.
  • If database changes require a migration, include up() / down() and keep it CosmosDB-compatible. — N/A; no database change.
  • If dependencies changed, update the lockfile and regenerate NOTICE / NOTICE-REVIEW.txt with pnpm notice as needed. — N/A; no dependency change.
  • Video showing the behavior before the suggested change — N/A; initialization race covered by automated regression test.
  • Video showing the behavior after the suggested change — N/A; initialization race covered by automated regression test.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: c52928ea-d413-4aab-95a1-b4ecfd7d9f96
@cedricvidal Cedric Vidal (cedricvidal) added type: bug Incorrect behavior or a regression that needs fixing. topic: reliability Availability, fault tolerance, recovery, and consistent operation. area: website Scope documentation website (Astro) under website/. labels Oct 15, 2026
@github-actions github-actions Bot added language: javascript Work involving JavaScript code, tooling, or dependencies. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. labels Oct 15, 2026
@cedricvidal
Cedric Vidal (cedricvidal) marked this pull request as ready for review October 15, 2026 17:17
@cedricvidal
Cedric Vidal (cedricvidal) merged commit 25dba53 into main Oct 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: website Scope documentation website (Astro) under website/. language: javascript Work involving JavaScript code, tooling, or dependencies. topic: reliability Availability, fault tolerance, recovery, and consistent operation. topic: testing Test coverage, test infrastructure, and validation quality. topic: ui Portal, visual presentation, layout, and interface components. type: bug Incorrect behavior or a regression that needs fixing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant