Repository navigation
fix(website): correct 1DS consent and move cookie banner to top - #1514
Merged
Wassim Chegham (manekinekko) merged 1 commit intoOct 16, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: e66fbb0c-26e6-4760-b481-e8636fa35dc8
Wassim Chegham (manekinekko)
marked this pull request as ready for review
October 16, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
propertyConfiguration.userConsentedbefore initializing each 1DS instance. Delaying SDK initialization alone left opted-in page views carryingext.web.userConsent: false.scopeApp ID, existing ingestion identifier,PRODenvironment, disabled analytics cookies, URL query/fragment exclusions, and opt-in/withdrawal/GPC/DNT protections.CJA dashboard visibility has not been verified; the fix still needs deployment before confirming new events in Web - All - Prod.
Demos
Website-only change; Portal/CLI recordings are N/A. Desktop and mobile screenshots were inspected locally using the real WCP banner.
Before
N/A — no Portal/CLI changes. On the website, the banner rendered below the footer, and accepted visits still emitted
userConsent: false.After
N/A — no Portal/CLI changes. The website banner sits above the header at desktop/mobile widths, and opted-in initial/subsequent page views emit
userConsent: true.Testing
cd website && SITE=https://microsoft.github.io BASE_PATH=/scope npx --yes pnpm@10.29.1 run build— passed, 225 HTML pages built.cd website && npx --yes pnpm@10.29.1 test— passed, 7 plugin tests.cd website && npx --yes pnpm@10.29.1 exec playwright test --reporter=dot— passed, all 84 accessibility/privacy/analytics cases across light/dark themes and 1280px/320px widths.npx --yes --package=typescript@5.9.3 tsc --noEmit --project website/tsconfig.json— failed with 10 pre-existing diagnostics in the Astro configuration,starlight-openapi, and missing root Vitest types. An in-memory compiler comparison againstHEADconfirmed identical full-project diagnostics, zero diagnostics in the changed TypeScript files, and no introduced errors.git diff --check— passed.ext.web.userConsent: true, retainiKey: "o:d73f4c6d7bfd4f54ab769e2baaf3156b", and restore the header offset after acceptance. Consent-management dialogs remain usable. Collector requests were intercepted locally; no synthetic telemetry was sent to Microsoft during these checks.Documentation and compatibility
Checklist
up()/down()and keep it CosmosDB-compatible. — N/A (no database changes).NOTICE/NOTICE-REVIEW.txtwithpnpm noticeas needed. — N/A (no dependency changes).