Add Python support with DynWinRT bindings and development identity by lei9444 · Pull Request #1062 · microsoft/winappCli

leileizhang (lei9444) · 2026-10-12T14:03:34Z

What and why

Add microsoft-winappcli, a Python package that includes the native Windows App Development CLI for x64 and ARM64. It provides the winapp command and python -m winappcli entry point. Python projects can generate bindings for Windows Runtime (WinRT) APIs, restore their declared dependencies, and run scripts with Windows package identity when an API requires an installed-app registration.

Ordinary run uses the project's existing .venv. run --identity prepares a separate Python runtime and environment without changing the ordinary .venv or a shared Python installation. This is a development workflow; distributing an application still requires packaging its runtime and dependencies.

After installing this PR's wheel, use these commands from a Python project:

winapp init . --use-defaults --add-python-bindings
winapp run .\app.py
winapp run --identity .\app.py
winapp restore

Once published, install with python -m pip install --upgrade microsoft-winappcli. The Python identity sample covers console execution and MSIX packaging. The separate Python WinUI sample provides an unpackaged counter without development identity.

Related issue: N/A.

Before / after

Same command and script, with a project .venv available. app.py contains print("Hello from Python"):

winapp run -q .\app.py

Before — native CLI from main: Python files are not runnable inputs.

After — installed Python package: the script runs with the project interpreter.

Not tested / risks

SDK setup in directories containing spaces can hit an existing native C++/WinRT issue; the separate fix is in #1174.
ARM64 execution was not tested locally.
PyPI publication has not been exercised. ESRP publishing authorization for microsoft-winappcli still needs confirmation.

Checklist

Tests added or updated
Tested locally on Windows
Docs, samples, and plugins/winapp/skills/ updated if user-facing behavior changed

Notes for reviewers

Native winapp continues to own SDK setup, manifests, signing and MSIX packaging; its source and tests are unchanged in this PR. Python adds bindings and dependency handling.

Initialization records the generator version in pyproject.toml; restore and generate reuse it, while update advances it. The private Python runtime is selected from a download catalog pinned by the installed tool, not from a project-level catalog setting.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

🟡 Changes recommended

The Python test suite fails on Windows environments whose temporary path uses an 8.3 short-path spelling.

1 open finding

Normalize temporary path before comparing bundled CLI path · New

What changed in this PR

Adds first-class Python support through winapp-py, combining the native CLI with DynWinRT bindings, dependency restoration, isolated development identity, packaging, samples, and release automation.

Changes:

Adds the Python wrapper, secure runtime/identity management, and comprehensive tests.
Extends native project detection and binding generation for Python projects.
Adds wheels, documentation, samples, CI validation, signing, and PyPI publishing.

Release native build and 177 targeted tests passed. The Python suite exposed one path-normalization test failure on Windows short paths.

File	Description
`.github/workflows/build-package.yml`	Builds and validates Python wheels.
`.github/workflows/test-samples.yml`	Adds Python sample validation.
`.pipelines/README.md`	Documents wheel signing order.
`.pipelines/release.yml`	Adds gated PyPI publication.
`.pipelines/templates/build-env.yaml`	Configures Python build tooling.
`.pipelines/templates/build.yaml`	Packages and validates signed wheels.
`README.md`	Introduces Python usage.
`docs/guides/python.md`	Adds the Python WinUI guide.
`docs/telemetry.md`	Documents Python project telemetry.
`docs/usage.md`	Documents `winapp-py` workflows.
`plugins/winapp/com.github.copilot/agents/winapp.agent.md`	Teaches the agent Python workflows.
`plugins/winapp/skills/winapp-frameworks/SKILL.md`	Adds Python framework guidance.
`samples/python-app/.gitignore`	Excludes generated Python artifacts.
`samples/python-app/README.md`	Documents the counter sample.
`samples/python-app/app.py`	Adds the sample entry point.
`samples/python-app/counter.py`	Implements persisted counter state.
`samples/python-app/pyproject.toml`	Declares sample metadata and bindings.
`samples/python-app/runtime.py`	Initializes Windows App SDK runtime.
`samples/python-app/test.Tests.ps1`	Tests the guide and packaged sample.
`samples/python-app/test_app.py`	Adds sample unit tests.
`samples/python-app/window.py`	Implements the WinUI window.
`scripts/package-python.ps1`	Builds architecture-specific wheels.
`scripts/test-python.ps1`	Validates installed-wheel workflows.
`scripts/test-samples.ps1`	Supports Python sample artifacts.
`scripts/tests/artifact-workflow.Tests.ps1`	Tests pipeline artifact integration.
`scripts/tests/package-python.Tests.ps1`	Tests wheel packaging behavior.
`scripts/tests/verify-signatures.Tests.ps1`	Tests wheel signature inspection.
`scripts/verify-signatures.ps1`	Verifies binaries embedded in wheels.
`src/winapp-CLI/Directory.Packages.props`	Adds the TOML parser dependency.
`src/winapp-CLI/WinApp.Cli.Tests/CppWinrtServiceTests.cs`	Tests Python binding asset copying.
`src/winapp-CLI/WinApp.Cli.Tests/DetectedProjectTests.cs`	Tests Python project results.
`src/winapp-CLI/WinApp.Cli.Tests/IncrementalCopyHelperTests.cs`	Tests safe incremental copies.
`src/winapp-CLI/WinApp.Cli.Tests/InitCommandPythonContextTests.cs`	Tests Python initialization context.
`src/winapp-CLI/WinApp.Cli.Tests/InitCommandTests.cs`	Extends initialization coverage.
`src/winapp-CLI/WinApp.Cli.Tests/ProjectContextDetectorTests.cs`	Tests Python context detection.
`src/winapp-CLI/WinApp.Cli.Tests/ProjectDetectionServiceAccessDeniedTests.cs`	Tests inaccessible Python metadata.
`src/winapp-CLI/WinApp.Cli.Tests/ProjectDetectionServiceTests.cs`	Tests Python project markers.
`src/winapp-CLI/WinApp.Cli.Tests/TelemetryEventsTests.cs`	Tests Python telemetry fields.
`src/winapp-CLI/WinApp.Cli/Commands/InitCommand.cs`	Reports machine-readable initialization results.
`src/winapp-CLI/WinApp.Cli/Services/CppWinrtService.cs`	Supports Python binding outputs.
`src/winapp-CLI/WinApp.Cli/Services/DetectedProject.cs`	Represents detected Python projects.
`src/winapp-CLI/WinApp.Cli/Services/DetectedProjectType.cs`	Adds the Python project type.
`src/winapp-CLI/WinApp.Cli/Services/IncrementalCopyHelper.cs`	Safely copies binding assets.
`src/winapp-CLI/WinApp.Cli/Services/ProjectContext.cs`	Carries Python project context.
`src/winapp-CLI/WinApp.Cli/Services/ProjectContextDetector.cs`	Detects Python metadata.
`src/winapp-CLI/WinApp.Cli/Services/ProjectDetectionService.cs`	Integrates Python project discovery.
`src/winapp-CLI/WinApp.Cli/Services/PythonProjectMetadata.cs`	Parses Python project metadata safely.
`src/winapp-CLI/WinApp.Cli/Services/WorkspaceSetupService.cs`	Prepares Python binding workspaces.
`src/winapp-CLI/WinApp.Cli/Telemetry/Events/ProjectContextEvent.cs`	Adds Python telemetry classification.
`src/winapp-CLI/WinApp.Cli/WinApp.Cli.csproj`	References TOML parsing support.
`src/winapp-python/.gitignore`	Excludes Python build artifacts.
`src/winapp-python/LICENSE`	Includes package licensing.
`src/winapp-python/README.md`	Documents the Python package.
`src/winapp-python/docs/development.md`	Documents contributor workflows.
`src/winapp-python/pyproject.toml`	Defines package metadata and entry points.
`src/winapp-python/setup.py`	Builds platform-specific wheels.
`src/winapp-python/src/winapp_cli/__init__.py`	Exposes package metadata.
`src/winapp-python/src/winapp_cli/__main__.py`	Supports module execution.
`src/winapp-python/src/winapp_cli/cli.py`	Implements `winapp-py` commands.
`src/winapp-python/src/winapp_cli/config.py`	Parses Python binding configuration.
`src/winapp-python/src/winapp_cli/dependencies.py`	Restores project dependencies.
`src/winapp-python/src/winapp_cli/errors.py`	Defines wrapper errors.
`src/winapp-python/src/winapp_cli/generate.py`	Generates and publishes bindings.
`src/winapp-python/src/winapp_cli/identity.py`	Manages development identity execution.
`src/winapp-python/src/winapp_cli/identity_environment.py`	Prepares isolated identity dependencies.
`src/winapp-python/src/winapp_cli/metadata.py`	Reads native package inventories.
`src/winapp-python/src/winapp_cli/native.py`	Locates and validates bundled CLI binaries.
`src/winapp-python/src/winapp_cli/paths.py`	Enforces safe project paths.
`src/winapp-python/src/winapp_cli/progress.py`	Provides terminal progress reporting.
`src/winapp-python/src/winapp_cli/python_runtime.py`	Downloads and extracts private runtimes.
`src/winapp-python/src/winapp_cli/tools.py`	Runs native and Python tools.
`src/winapp-python/tests/fixtures/appsdk-nonui/app.py`	Adds a non-UI fixture application.
`src/winapp-python/tests/fixtures/appsdk-nonui/pyproject.toml`	Configures the non-UI fixture.
`src/winapp-python/tests/fixtures/appsdk-nonui/winapp.yaml`	Pins fixture SDK packages.
`src/winapp-python/tests/fixtures/uri/app.py`	Adds a bindings fixture application.
`src/winapp-python/tests/fixtures/uri/identity_probe.py`	Probes development identity.
`src/winapp-python/tests/fixtures/uri/pyproject.toml`	Configures URI bindings.
`src/winapp-python/tests/fixtures/uri/requirements-dev.txt`	Declares fixture development dependencies.
`src/winapp-python/tests/fixtures/uri/requirements.txt`	Declares fixture dependencies.
`src/winapp-python/tests/fixtures/uri/winapp.yaml`	Pins fixture SDK packages.
`src/winapp-python/tests/helpers.py`	Provides shared Python test fixtures.
`src/winapp-python/tests/test_cli_tools.py`	Tests command execution helpers.
`src/winapp-python/tests/test_config_metadata.py`	Tests configuration and inventory parsing.
`src/winapp-python/tests/test_dependencies.py`	Tests dependency synchronization.
`src/winapp-python/tests/test_generate.py`	Tests binding generation and publication.
`src/winapp-python/tests/test_help.py`	Tests CLI help and version output.
`src/winapp-python/tests/test_identity.py`	Tests identity lifecycle and contention.
`src/winapp-python/tests/test_identity_environment.py`	Tests isolated dependency preparation.
`src/winapp-python/tests/test_init.py`	Tests Python initialization.
`src/winapp-python/tests/test_native.py`	Tests bundled native payload handling.
`src/winapp-python/tests/test_progress.py`	Tests terminal progress behavior.
`src/winapp-python/tests/test_python_runtime.py`	Tests runtime selection and extraction.

🧠 Review effort: Balanced

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

github-actions · 2026-10-12T14:37:10Z

Build Metrics Report

Validation passed. All required build and validation jobs succeeded.

Binary Sizes

Artifact	Baseline	Current	Delta
CLI (ARM64)	65.05 MB	65.06 MB	📈 +16.0 KB (+0.02%)
CLI (x64)	64.97 MB	64.99 MB	📈 +14.0 KB (+0.02%)
MSIX (ARM64)	26.93 MB	26.93 MB	📈 +4.1 KB (+0.01%)
MSIX (x64)	28.55 MB	28.56 MB	📈 +12.6 KB (+0.04%)
NPM Package	56.12 MB	56.12 MB	📈 +0.0 KB (+0.00%)
NuGet Package	56.27 MB	56.28 MB	📈 +8.9 KB (+0.02%)

.NET Test Results (TRX reports)

Other suites are reflected in the overall validation status above.

✅ 10669 passed, 43 skipped out of 10712 tests in 2189.1s (+5 tests, -395.2s vs. baseline)

Test Coverage

✅ 87.4% line coverage, 81.5% branch coverage · ✅ no change vs. baseline

CLI Startup Time

78ms median (x64, winapp --version) · ⚠️ +18ms vs. baseline

Updated 2026-10-23 11:48:24 UTC · commit e23c788 · workflow run

Nikola Metulev (nmetulev)

🤖 AI-generated review (winappcli pr-review skill) — verify before acting.

Decision: changes required

Python support fits winapp, and a PyPI wheel as a peer to the npm package is the right shape. The core flows work end to end against this PR's own native build:

init --add-python-bindings succeeds.
run works.
run --identity works: GetCurrentPackageFullName succeeded and the script's exit code came through. Cold start took 79 s, a warm run 6 s.
identity clear unregistered cleanly.

Before merge:

CI needs to go green.
Four bugs need fixing; each breaks user config, user files, or script output.
restore needs to stop pulling an unpinned generator.
The native CLI changes should shrink.
The names should match our other channels.
The guide should follow the same journey as the other framework guides.

Must fix

1. CI is red because of this PR

validate-tests (Auxiliary): docs/guides/python.md opts into MS Learn publishing but isn't in the generated TOC. Add it to $TocLabels and the framework-guides $tocTree in scripts/port-mslearn-docs.ps1.
validate-python: test_native.test_bundled_path_is_absolute_and_matches_python_platform compares C:/Users/runneradmin/... against C:/Users/RUNNER~1/.... Resolve the expected path before comparing.
Fails locally, not in CI: ProjectContextDetectorTests.DetectDirectory_Python_UsesOnlyRecognizedProjectMetadata walks above %TEMP% and picks up project markers in a parent folder. Add a .git boundary to the fixture.

2. `restore` installs and runs the newest prerelease generator every time

What is wrong: restore, generate and update all run pip install --upgrade --force-reinstall --pre dynwinrt-codegen and then execute it. config.py rejects any attempt to pin a version.
Show me: winapp-py restore --verbose prints "Uninstalling dynwinrt-codegen-0.1.0rc23 … Successfully installed 0.1.0rc23" on every run. It will pick up rc24 the day it ships, and upstream preview.23 already changed the Python typing/write contracts.
Why it matters:
- Clones and CI get different bindings without any project change.
- A release published after ours gets executed on a routine restore.
- Restore always needs network access.
Smallest fix: init/update record the resolved version in winapp-managed project data. restore/generate install ==<version>. Only update advances it. Apps still don't need to declare the generator or runtime themselves.
Location: src/winapp-python/src/winapp_cli/dependencies.py:454-476, cli.py:196-220, config.py:132-139

3. `init --use-defaults` erases existing bindings settings

Show me: start with scope = "types", types = ["Windows.Foundation.Uri"], then run winapp-py init . --use-defaults --config-only. Result: scope = "default", types = [], exit code 0.
Smallest fix: keep existing settings under --use-defaults, and only reset them in the explicit reset branch.
Location: cli.py:278-289, config.py:169-177

4. `init` can permanently break the user's requirements files

Show me: if requirements.txt contains -r requirements-dev.txt, init appends -r requirements.txt to the dev file. pip then fails with "recursively references itself", and the edit stays on disk.
Smallest fix: skip the reverse include when the dev file is already reachable from the app requirements.
Location: dependencies.py:309-316

5. `run` writes its own status lines into the script's stdout

Show me: after winapp-py run app.py > out.txt, out.txt contains Using project .venv: … before the script's own output. The identity path's progress lines and Running x.py… also go to stdout.
Why it matters: a script that emits JSON or text for piping becomes unparseable.
Smallest fix: send wrapper status to stderr, or print it only under --verbose.
Location: cli.py:177, identity.py:422,510

6. Keep the native CLI changes to what every wrapper needs

Remove the WINAPP_PY_INIT_RESULT side channel (InitCommand.WritePythonInitResult plus WorkspaceSetupService.MetadataDirectory).
- It's a hidden contract between native and the wheel that only the wheel uses.
- npm gets the same information with no native changes: it works out the selected workspace and init mode from its own arguments plus winapp.yaml and .winapp/winmds.lock.json (see src/winapp-npm/src/jsbindings/cli-hooks.ts). The wheel can do the same.
Drop Python from native project detection, but keep the .venv/pyvenv.cfg skip.
- Nothing in native behaves differently for a Python project. Detection only changes the init label, telemetry, and where the subdirectory search stops.
- To get that, it adds a third-party TOML parser (Tomlyn) to the native binary. For comparison, Electron detection uses the built-in JSON parser, and Rust detection only checks whether Cargo.toml exists.
- It also causes a regression. At a repo root whose pyproject.toml has a name, interactive winapp init stops searching and no longer offers a nested .csproj or Electron app.
- If the "Python project detected" label is wanted, check that the marker file exists, without parsing it and without stopping the search.

7. Match our other channels' naming

Today:
- winget: Microsoft.winappcli → winapp
- npm: @microsoft/winappcli → winapp
- this PR: winapp-cli → winapp-py
Proposal: distribution winappcli, console script winapp, import package winappcli.
- Tools on PyPI that bundle a native CLI install the real command name (cmake, ninja, ruff).
- npm's winapp already layers extra behavior over the native commands, and an active venv puts its own winapp first on PATH.
- It also fixes forwarded help, which already prints Usage: winapp.
Nothing has been published yet, so rename outright with no winapp-py alias.
Reserve the PyPI name and confirm ESRP can publish to it before docs advertise pip install. All the candidate names currently return 404 on PyPI.

8. The guide should follow the same journey as the other framework guides

What is wrong: docs/guides/python.md is built around a 130-line code-built WinUI picker run with run --identity. Nothing in it needs identity.
- The guide itself says the picker doesn't.
- Identity is only being used to make the Windows App Runtime available, and the counter sample does that with the bootstrapper instead.
Why it matters:
- It teaches that WinUI needs identity, which isn't true.
- It routes newcomers through the slowest path first: a private Python runtime download (about 72 MB) and a 79 s cold start.
- It leads with WinUI hosting, which upstream DynWinRT calls experimental.
- The demand in #117 and #61 is scripts and services that need an identity-gated API.
Smallest fix: mirror the Rust guide.
1. A minimal app.py that prints Package.current.id.family_name.
2. A plain run prints "Not packaged".
3. winapp-py run --identity app.py prints the family name.
4. identity clear.
5. Package.
The non-UI identity probe in tests/fixtures/uri/ is a good starting point. Move the WinUI picker to the sample or a follow-up section.
While there:
- Use mkdir/cd like every other guide, instead of New-Item/Set-Location.
- Drop the PEP 440 version-format tip; it's implementation detail.
- Don't have users hand-write the bindings table that init creates.

Non-blocking

--quiet/--json behave differently depending on where they're placed.
- winapp-py restore --quiet exits with code 2.
- winapp-py --quiet restore is forwarded to native and silently skips the bindings restore.
- run --json x.py goes to native, while run x.py --json stays in Python.
Normalize shared flags before dispatch, and keep script arguments after --.
The identity runtime trusts a catalog on astral-sh/uv main. The download URL and its SHA-256 both come from raw.githubusercontent.com/astral-sh/uv/main/.... Pin it to a commit, or vendor the hashes per release. Each project also downloads its own copy of the runtime (about 72 MB measured).
A failed codegen during init leaves a dependency on a missing package. Dependency edits are written before codegen and never rolled back. Write them after generation succeeds (cli.py:234-248).

Not verified

ARM64, and x64 Python emulated on ARM64.
Building and signing the wheel, and the ESRP/PyPI publish.
The interactive monorepo winapp init regression: found by reading the code, not reproduced.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Keep shared output options on Python workflows and register generated dependencies only after successful generation. Read identity CI diagnostics from stderr and isolate metadata test fixtures from parent projects. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Replace native TOML parsing with marker-only Python hints that do not prune nested projects. Remove the Python-specific initialization result channel and confirm SDK artifact targets in the Python wrapper. Update related documentation and regression coverage. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Nikola Metulev (nmetulev)

Thanks for the updates. All 5 must-fixes from the last round are fixed, and I re-checked each one:

restore installs the pinned codegen-version.
init --use-defaults keeps an existing bindings selection.
An existing -r requirements-dev.txt no longer causes a recursive include.
run keeps wrapper status off the script's stdout.
CI is green.

The flag-placement, codegen-failure rollback and nested-project detection items are fixed too. Two things remain, plus merge conflicts.

1. The identity runtime catalog pin is written into the user's project and needs the GitHub API

What happens: the first winapp-py run --identity writes [tool.winapp.python-identity] uv-catalog-version into the user's pyproject.toml ("Pinned uv PBS catalog 0.13.1 in pyproject.toml"). After that, every fresh preparation calls the unauthenticated api.github.com/repos/astral-sh/uv/releases to check the release (identity.py:430-440, python_runtime.py:172-188). The local .winapp record isn't committed, so this repeats on every clone and CI job.
Why it matters:
- A run command edits a tracked file.
- The identity path depends on a rate-limited API (60 requests per hour per IP), which shared CI runners can hit.
- Once this ships, the setting becomes user configuration we can't remove without breaking projects.
Smallest fix: ship one pin per release as a constant in the wheel: a catalog URL at a fixed commit plus the catalog's SHA-256, or vendored hashes. That removes the setting, the API call, the pyproject.toml write, the schema bump and the docs section.

2. Native project detection crashes on a folder it can't list

What happens: the new requirements.txt check in ProjectDetectionService.cs:171-176 calls EnumerateFiles("*.py") without catching UnauthorizedAccessException/IOException. The other detection helpers in that file do catch them.
Repro: a folder with requirements.txt + a.py, then icacls <folder> /deny <me>:(RD), then winapp init .\locked --use-defaults --setup-sdks none → unhandled UnauthorizedAccessException, exit 1. The interactive search from a parent folder takes the same path for any such subfolder, so this also affects non-Python users.
Smallest fix: wrap the enumeration the way the neighboring helpers do, treat the folder as not detected, and add a case to ProjectDetectionServiceAccessDeniedTests.

3. Merge conflicts with main

GitHub reports conflicts in CustomHelpAction.cs, CompactHelpRenderer.cs, build-package.yml and artifact-workflow.Tests.ps1.

After these, I think this is close. I'd rather not do more rounds on medium items.

Publish as microsoft-winappcli with the winapp module and command, and remove Python-specific native help name rewriting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Keep both Python and DevTools validation gates and require both before publishing successful baseline metrics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Remove native Python project detection while keeping virtual environment exclusions. Keep C# initialization results when Python bindings are unsupported. Preserve uv dependency conditions, reject mismatched bindings, avoid implicit uv lookup, and leave unchanged requirements untouched. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Compare expected executable paths after resolving Windows short names, without changing uv lookup or weakening the exact-path assertions. Clarify that PBS downloads do not require uv, but uv-managed dependency restoration does. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Restore native sources and tests to main and keep the WinUI sample focused on the counter. The C++/WinRT response-file fix and space-path regression are tracked separately in #1174; Python workflow fixtures use ordinary directory names. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

leileizhang (lei9444) and others added 3 commits October 12, 2026 21:10

Add Python integration with DynWinRT bindings and PyPI publishing

1221548

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge latest main into Python integration

d8225e6

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Harden Python restoration and development identity

b92b271

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI balanced review requested due to automatic review settings October 12, 2026 14:03

Copilot started reviewing on behalf of leileizhang (lei9444) October 12, 2026 14:04

View session

leileizhang (lei9444) added the agent-preparing Agent is addressing feedback or completing required validation and CI label Oct 12, 2026

Copilot AI reviewed Oct 12, 2026

View reviewed changes

Comment thread src/winapp-python/tests/test_native.py Outdated

github-code-quality Bot found potential problems Oct 12, 2026

View reviewed changes

Nikola Metulev (nmetulev) requested changes Oct 12, 2026

View reviewed changes

leileizhang (lei9444) and others added 5 commits October 13, 2026 09:31

Merge branch 'main' into lei9444-dynwinrt-python-integration

078fe81

Make Python help display the correct entry point

da26b1e

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Pin project codegen versions and fix Python workflow regressions

2d5c1cc

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-code-quality Bot found potential problems Oct 14, 2026

View reviewed changes

Comment thread src/winapp-CLI/WinApp.Cli.Tests/ProjectDetectionServiceAccessDeniedTests.cs Fixed

Comment thread src/winapp-CLI/WinApp.Cli.Tests/ProjectDetectionServiceTests.cs Fixed

leileizhang (lei9444) and others added 5 commits October 15, 2026 15:10

Split Python identity and unpackaged WinUI samples

36e8d24

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Pin Python identity runtime catalogs per project

982cda0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge main into Python integration

8971b05

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Fix test for the Possible Python project label

6716ac0

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Preserve npm schema arguments in PowerShell builds

d992cd1

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Nikola Metulev (nmetulev) requested changes Oct 16, 2026

View reviewed changes

leileizhang (lei9444) and others added 4 commits October 19, 2026 10:04

Unify Python package and command naming

a857372

Publish as microsoft-winappcli with the winapp module and command, and remove Python-specific native help name rewriting. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge latest main into Python integration

182672f

Keep both Python and DevTools validation gates and require both before publishing successful baseline metrics. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Fix Python catalog pinning and review feedback

5f72176

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge main into Python integration

87af036

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-code-quality Bot found potential problems Oct 20, 2026

View reviewed changes

Use Path.Join in copy checks and Python tests

4ec4742

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

github-code-quality Bot found potential problems Oct 20, 2026

View reviewed changes

Use Path.Join in Python detection tests

70cdf45

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

leileizhang (lei9444) and others added 4 commits October 23, 2026 11:30

Merge main into Python integration

a81869c

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Conversation

leileizhang (lei9444) commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What and why

Before / after

Not tested / risks

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

github-actions Bot commented Oct 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Build Metrics Report

Binary Sizes

.NET Test Results (TRX reports)

Test Coverage

CLI Startup Time

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Nikola Metulev (nmetulev) left a comment

Choose a reason for hiding this comment

Decision: changes required

Must fix

1. CI is red because of this PR

2. restore installs and runs the newest prerelease generator every time

3. init --use-defaults erases existing bindings settings

4. init can permanently break the user's requirements files

5. run writes its own status lines into the script's stdout

6. Keep the native CLI changes to what every wrapper needs

7. Match our other channels' naming

8. The guide should follow the same journey as the other framework guides

Non-blocking

Not verified

Uh oh!

Uh oh!

Uh oh!

Nikola Metulev (nmetulev) left a comment

Choose a reason for hiding this comment

1. The identity runtime catalog pin is written into the user's project and needs the GitHub API

2. Native project detection crashes on a folder it can't list

3. Merge conflicts with main

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

leileizhang (lei9444) commented Oct 12, 2026 •

edited

Loading

github-actions Bot commented Oct 12, 2026 •

edited

Loading

2. `restore` installs and runs the newest prerelease generator every time

3. `init --use-defaults` erases existing bindings settings

4. `init` can permanently break the user's requirements files

5. `run` writes its own status lines into the script's stdout