Repository navigation
Include current values in DevTools accessible property names - #1169
Closed
Chiara Mooney (chiaramooney) wants to merge 3 commits into
Closed
Chiara Mooney (chiaramooney) wants to merge 3 commits into
Chiara Mooney (chiaramooney) wants to merge 3 commits into
Conversation
Allow Tab focus and Left/Right resizing with accessible instructions and shared mouse resize limits. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
Split generated XAML into adjacent wide literals and avoid constant-condition warnings without disabling compiler checks. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
Contributor
Build Metrics ReportValidation passed. All required build and validation jobs succeeded. Binary Sizes
.NET Test Results (TRX reports)Other suites are reflected in the overall validation status above. ✅ 10669 passed, 43 skipped out of 10712 tests in 1910.1s (+5 tests, -674.2s vs. baseline) Test Coverage✅ 87.4% line coverage, 81.5% branch coverage · ✅ no change vs. baseline CLI Startup Time72ms median (x64, Try This BuildInstalls the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing. & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 1169Switching between builds often?Put the tool on your PATH once: & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPathThen this build is just: winapp-pr 1169Run Updated 2026-10-23 17:38:22 UTC · commit |
Update names when rows are realized, edited, or changed live while preserving AutomationIds. Remove the divider keyboard fix, tests, and guide text so the other PR can own issue #1155. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
When a keyboard user focuses a DevTools property value, its accessible name now includes the displayed value. For example, a button showing Auto is named
Height: Autoinstead ofHeight value.The button and its text update together after edits and live property changes. Their AutomationIds stay unchanged, so
Height valueandHeight shownstill work as selectors.Fixes #1154
Before / after
Before (reported in the issue)
winapp ui get-property "Height value" -w <inspector-hwnd> --jsonreportsName: Height value, although the visible value is Auto.After (observed in a live WinUI app on ARM64 Windows)
The same command reports
Name: Height: Auto,AutomationId: Height value, andHasKeyboardFocus: True. After changing Height to 120, both the button and child text reportName: Height: 120. Restoring Auto changes both names back toHeight: Auto.The visible row is unchanged. These are UI Automation results, not a recording of screen-reader speech.
Not tested / risks
Narrator speech and the full CLI, sample, and UI end-to-end suites were not tested. Live checks ran on ARM64 Windows. Both x64 and ARM64 binaries built successfully. Latest-head CI has not been assessed.
Checklist
plugins/winapp/skills/updated if user-facing behavior changedNotes for reviewers
No command or workflow changed, so no documentation update is needed. Small native build fixes remain: split oversized generated XAML literals and avoid constant-condition warnings without disabling compiler checks.
Local command results:
pwsh -NoProfile -File .\scripts\build-cli.ps1 -SkipAll: passed for both architectures; packaging and full test suites skipped..\src\winapp-devtools\test\bin\window-runtime-tests.exe: passed, 103 checks, no failures or skips, including initial values, empty values, nested paths, committed edits, and live changes.git diff --check: passed.A focused live script also passed seven checks covering Auto -> 120 -> Auto, stable AutomationIds, and the focused button's accessible name. The added assertions in
scripts\test-e2e-winui-ui.ps1were not run as part of that full suite.