Skip to content

Include current values in DevTools accessible property names - #1169

Closed
Chiara Mooney (chiaramooney) wants to merge 3 commits into
mainfrom
chiaramooney-devtools-keyboard-divider
Closed

Chiara Mooney (chiaramooney) wants to merge 3 commits into
mainfrom
chiaramooney-devtools-keyboard-divider

Conversation

@chiaramooney

@chiaramooney Chiara Mooney (chiaramooney) commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

What and why

When a keyboard user focuses a DevTools property value, its accessible name now includes the displayed value. For example, a button showing Auto is named Height: Auto instead of Height value.

The button and its text update together after edits and live property changes. Their AutomationIds stay unchanged, so Height value and Height shown still work as selectors.

Fixes #1154

Before / after

Before (reported in the issue)

winapp ui get-property "Height value" -w <inspector-hwnd> --json reports Name: Height value, although the visible value is Auto.

After (observed in a live WinUI app on ARM64 Windows)

The same command reports Name: Height: Auto, AutomationId: Height value, and HasKeyboardFocus: True. After changing Height to 120, both the button and child text report Name: Height: 120. Restoring Auto changes both names back to Height: Auto.

The visible row is unchanged. These are UI Automation results, not a recording of screen-reader speech.

Not tested / risks

Narrator speech and the full CLI, sample, and UI end-to-end suites were not tested. Live checks ran on ARM64 Windows. Both x64 and ARM64 binaries built successfully. Latest-head CI has not been assessed.

Checklist

  • Tests added or updated
  • Tested locally on Windows
  • Docs, samples, and plugins/winapp/skills/ updated if user-facing behavior changed
Notes for reviewers

No command or workflow changed, so no documentation update is needed. Small native build fixes remain: split oversized generated XAML literals and avoid constant-condition warnings without disabling compiler checks.

Local command results:

  • pwsh -NoProfile -File .\scripts\build-cli.ps1 -SkipAll: passed for both architectures; packaging and full test suites skipped.
  • .\src\winapp-devtools\test\bin\window-runtime-tests.exe: passed, 103 checks, no failures or skips, including initial values, empty values, nested paths, committed edits, and live changes.
  • git diff --check: passed.

A focused live script also passed seven checks covering Auto -> 120 -> Auto, stable AutomationIds, and the focused button's accessible name. The added assertions in scripts\test-e2e-winui-ui.ps1 were not run as part of that full suite.

Allow Tab focus and Left/Right resizing with accessible instructions and shared mouse resize limits.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
@chiaramooney Chiara Mooney (chiaramooney) added the agent-blocked Agent cannot address feedback or fix CI without help, or needs author input label Oct 22, 2026
Split generated XAML into adjacent wide literals and avoid constant-condition warnings without disabling compiler checks.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
@chiaramooney Chiara Mooney (chiaramooney) added agent-preparing Agent is addressing feedback or completing required validation and CI and removed agent-blocked Agent cannot address feedback or fix CI without help, or needs author input labels Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Build Metrics Report

Validation passed. All required build and validation jobs succeeded.

Binary Sizes

Artifact Baseline Current Delta
CLI (ARM64) 65.05 MB 65.06 MB 📈 +16.0 KB (+0.02%)
CLI (x64) 64.97 MB 64.99 MB 📈 +14.5 KB (+0.02%)
MSIX (ARM64) 26.93 MB 26.93 MB 📈 +4.1 KB (+0.01%)
MSIX (x64) 28.55 MB 28.56 MB 📈 +12.8 KB (+0.04%)
NPM Package 56.12 MB 56.12 MB 📈 +0.4 KB (+0.00%)
NuGet Package 56.27 MB 56.28 MB 📈 +9.3 KB (+0.02%)

.NET Test Results (TRX reports)

Other suites are reflected in the overall validation status above.

✅ 10669 passed, 43 skipped out of 10712 tests in 1910.1s (+5 tests, -674.2s vs. baseline)

Test Coverage

✅ 87.4% line coverage, 81.5% branch coverage · ✅ no change vs. baseline

CLI Startup Time

72ms median (x64, winapp --version) · ⚠️ +12ms vs. baseline

Try This Build

Installs the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing.

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 1169
Switching between builds often?

Put the tool on your PATH once:

& ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPath

Then this build is just:

winapp-pr 1169

Run winapp-pr with no arguments to pick from a list of open PRs.


Updated 2026-10-23 17:38:22 UTC · commit f495631 · workflow run

Update names when rows are realized, edited, or changed live while preserving AutomationIds. Remove the divider keyboard fix, tests, and guide text so the other PR can own issue #1155.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 18f16489-29e9-4ca4-b372-85159bc0a64f
@chiaramooney Chiara Mooney (chiaramooney) changed the title Make the DevTools pane divider keyboard accessible Include current values in DevTools accessible property names Oct 23, 2026
@chiaramooney Chiara Mooney (chiaramooney) removed the agent-preparing Agent is addressing feedback or completing required validation and CI label Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DevTools property value controls omit the current value from their accessible names

1 participant