-
Notifications
You must be signed in to change notification settings - Fork 12
fix(optrace): include CPU fallback operators in QNN results #1368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -341,6 +341,9 @@ def _build_session_options( | |
| for key, value in session_option_entries.items(): | ||
| so.add_session_config_entry(key, value) | ||
|
|
||
| if ep_monitor is not None: | ||
| ep_monitor.configure_session_options(so) | ||
|
|
||
| handle = ep_device.device._ort | ||
| options = ( | ||
| dict(provider_options) | ||
|
|
@@ -502,7 +505,7 @@ def __init__( | |
| so = _build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| self._ep_monitor, | ||
| self._session_options_factory, | ||
| session_option_entries=self._active_session_option_entries, | ||
| provider_options=self._provider_options, | ||
|
|
@@ -548,7 +551,7 @@ def compile(self) -> None: | |
| sess_options=_build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| self._ep_monitor, | ||
| self._session_options_factory, | ||
| session_option_entries=self._active_session_option_entries, | ||
| provider_options=self._provider_options, | ||
|
|
@@ -591,7 +594,7 @@ def compile(self) -> None: | |
| runtime_so = _build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| self._ep_monitor, | ||
| self._session_options_factory, | ||
| session_option_entries=self._active_session_option_entries, | ||
| provider_options=self._provider_options, | ||
|
|
@@ -714,7 +717,7 @@ def _prepare_epcontext_model( | |
| so = _build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| self._ep_monitor, | ||
| self._session_options_factory, | ||
| session_option_entries=self._active_session_option_entries, | ||
| provider_options=self._provider_options, | ||
|
|
@@ -1539,7 +1542,7 @@ def _restore_baseline() -> Exception | None: | |
| sess_options=_build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| self._ep_monitor, | ||
| self._session_options_factory, | ||
| session_option_entries=saved_sess_entries, | ||
| provider_options=saved_prov, | ||
|
|
@@ -1563,7 +1566,7 @@ def _restore_baseline() -> Exception | None: | |
| so = _build_session_options( | ||
| self._ep_device, | ||
| self._ep_config, | ||
| None, | ||
| effective_monitor, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This hook is only reached when |
||
| self._session_options_factory, | ||
| session_option_entries=desired_sess_entries, | ||
| provider_options=new_prov, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A CPU fallback node inside
LooporScancan emit multiple kernel events per top-level inference, so this count can legitimately exceed the perf-window iteration count. The current equality check rejects those valid mixed-provider traces asparse_failed; please account for repeated node executions within each run before validating/removing warmup samples.