fix(build): honor CLI optimization bypass - #1401
Draft
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 2 commits into
Draft
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 2 commits into
Qiong Wu (qiowu) (DingmaomaoBJTU) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CLI-only control-correctness fix; no recipes, model-specific logic, new graph optimization pass, or speedup claim.
skip_optimizeat the actual single-model HF and direct-ONNX CLI sinks, then passCLI skip OR config.skip_optimizeto the existing_run_optimize_stagehelper.Exactly two changed paths: the CLI build command (+4/-1) and its regression tests (+252). No library, recipe, dependency, lockfile, or skill changes.
Validation
4da82cde6c93894199f00e108f80be13f5dfe3bd; parent/base:dcad2f4a29cb34af71d7b138bcafc4276a70a4ed. Fetchedorigin/mainstill matched this base before shipment; no rebase or new commit.Scope and limits
Overlap and integration
Overlaps the CLI portion of #1370 by ssss141414 (observed head
3cd22269dfbfaac8baef63cb221c44c9e803af91). That draft combines multilingual recipes with a repair that bypasses the entire optimize-stage helper; this standalone fix instead preserves the existing helper contract.Proposed disposition, if this fix is adopted: use this as the canonical CLI repair in place of #1370's overlapping code/test change, while keeping its model recipes separate or adapting them to depend on the canonical repair. This acknowledges the prior overlapping work; it does not claim agreement from that author or declare #1370 superseded. #1370 has not been edited, commented on, closed, rebased, or pushed by this shipment.
Coordinate ownership before landing either overlapping implementation; do not merge both unchanged. Keep this PR draft pending independent post-PR review and integration coordination.