fix(e2e): isolate download observation from execution timeouts - #1424
Draft
Yue Sun (KayMKM) wants to merge 1 commit into
Draft
Yue Sun (KayMKM) wants to merge 1 commit into
Yue Sun (KayMKM) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Investigation
The real-agent diagnostic comparison used the same commit, QNN agent, model order, and external stack sampler:
0xC0000005while the model-build child was still progressing. The following GPU runner remained insidepsutil.open_files()after the model child exited. The run was subsequently canceled after evidence preservation.The native dump supports a psutil helper-thread/heap-wait failure, but does not establish the precise low-level corruption mechanism. Crash dumps and local investigation artifacts are not included in this PR.
Related: #1400 and #1399.
Validation performed
tests/unit/eval/test_hf_download_observer.pytests/unit/eval/test_e2e_process_tree.pytests/unit/eval/test_download_observer_integration.pytests/unit/eval/test_run_eval_script.pygit diff --checkpassed.Draft status / integration required
This branch was developed against
79f1a1b2. Main subsequently merged #1411 (71e04ac7), which independently changes subprocess download monitoring, retained logs/heartbeats, and release evaluation. A merge preflight reports conflicts in:scripts/e2e_eval/run_eval.pytests/unit/eval/test_run_eval_script.pyscripts/e2e_eval/README.mdKeep this PR as a draft until the two approaches are reconciled without dropping the new release/logging behavior, the rebased result is retested, and full observer-enabled hardware validation is completed. The 291 passing cases above apply to this branch, not a merge with current main.