Repository navigation
test: regression test for detached onPlaced crash (#639) - #652
Merged
Merged
Conversation
Adds a jvmTest Compose UI test that swipes a HorizontalPager of LazyColumns containing markdown to recycle items, reproducing the IllegalStateException from #639 when onPlaced reads parentLayoutCoordinates on detached coordinates. Fails without the isAttached guards from #641, passes with them. - adds jvmTest deps: compose runtime/ui/foundation/ui-test, desktop currentOs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a jvmTest Compose UI test that reproduces #639: a
HorizontalPagerofLazyColumns with markdown, swiped to recycle items.isAttachedguards withIllegalStateException: LayoutCoordinate operations are only valid when isAttached is true.jvmTestdependencies (compose runtime/ui/foundation/ui-test, desktopcurrentOs).This branch is based on #641 (its fix commit is included), so it supersedes/extends that PR. Merge #641 first and this reduces to the test only.
Only this test was run; full
jvmTestandapiCheckwere not.