feat(apps): add @apps/warondisease - #199
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 483b194502
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /* Primary - Brutal Pink */ | ||
| --primary: rgb(236, 70, 153); | ||
| --primary-foreground: rgb(255, 255, 255); | ||
|
|
||
| /* Secondary - Brutal Yellow */ | ||
| --secondary: rgb(255, 221, 87); | ||
| --secondary-foreground: rgb(0, 0, 0); | ||
|
|
||
| /* Accent - Brutal Cyan */ | ||
| --accent: rgb(0, 217, 255); |
There was a problem hiding this comment.
Every newly added public page loads this global stylesheet through app/layout.tsx, so these pink, yellow, and cyan brand tokens make the new War on Disease app render in the neobrutalist design that the repository explicitly prohibits for new public UI. Define the treaty black-and-white semantic tokens instead and remove the app-wide decorative colors and hard-shadow system.
AGENTS.md reference: AGENTS.md:L82-L85
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed real per AGENTS.md ("New components default to treaty style" / no neobrutalist tokens on new public UI) — apps/warondisease/app/globals.css ships the full pink/yellow/cyan neobrutalist palette plus the hard-shadow system, and every page in this new app (221 changed files) is built against brutal-* tokens and shadow-[8px_8px_0px_0px_rgba(0,0,0,1)] classes throughout.
Not fixing this as part of automated PR maintenance: replacing the design system for a brand-new, already-built 221-file app is a full visual rewrite of every page, not a scoped bug fix — and AGENTS.md requires screenshot-based UI verification before any UI change is considered done, plus showing current/proposed flow for a non-trivial cross-system change. That needs Mike's call on sequencing (restyle now and re-review the whole app visually, vs. ship this variant and restyle as tracked follow-up work) rather than an unreviewed mass rewrite from this pass.
@mikepsinn — flagging for your decision, leaving this thread open.
Generated by Claude Code
185e4aa to
b0f7faa
Compare
d36378a to
fdf8317
Compare
Full War on Disease Next entrypoint on shared Neon schema, with CI apps-warondisease-validate typecheck against the same Postgres pattern. Co-authored-by: Cursor <cursoragent@cursor.com>
Skills/links stubbed; soldiers and dashboard use Person.handle/displayName. Co-authored-by: Cursor <cursoragent@cursor.com>
Display name lives on Person after DIH schema strip. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
- signup: stop marking credentials accounts emailVerified on creation; matches packages/web's signup route and closes an account-takeover path via OAuth email linking. - weekly-emails cron: use the existing calculateUserRank() helper instead of a query that assigned every recipient the same count. - stripe session route: return only the fields the success page renders instead of full customer_details/metadata (billing address, phone, arbitrary metadata) to an unauthenticated lookup. - sitemap.xml: generate from the existing getSitemapRoutesForVariant() route registry instead of reading a public/sitemaps/*.xml file that is never generated or committed, which made the route always 404. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
fdf8317 to
7c5f48a
Compare
|
Superseded by single tip PR #195 (apps-dih-split) — stack collapsed to avoid N× duplicate review. |
2 participants
Summary
@apps/warondisease(port 3010) campaign app on shared@optimitron/dbapps-warondisease-validateCI job + brand_apps path filterStacked on #198
Split from #195
Test plan
apps-warondisease-validatetypecheck green@apps/*packages/web