Repository navigation
test(api): update stale expectations in test_18c, test_22, test_47 (#1251) - #1294
Merged
Merged
Conversation
…1251) - test_18c: match the current 'Duplicate SIP provider pjsip section' log line. - test_22: read the 422 body and check substituted tokens instead of English words; fail when validation is missing. - test_47: in Docker the release server returns no firmware by design, so skip the quick-vs-detailed check there and when the detailed check is degraded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1251
test_05: the core logsDuplicate SIP provider pjsip section "<uniqid>" … kept m_Sip.id=…(SIPConf::shouldSkipDuplicateSection); the needle was the olduniqid "…"text.test_01,test_04: 422 messages are translated, so the tests now read the body (allow_404=True) and checkresult=falseplus the substituted tokens (30,s3_endpoint). They also fail now if validation goes missing (before they only printed a warning).test_03: the release server returns no firmware fromcheckNewFirmwareforTYPE=docker(Docker updates by image; the update page showsUpdate/docker.volt), whileifNewReleaseAvailablereports the new version. Lxc/bare/vm get consistent answers. In Docker the test now asserts an empty firmware list instead of consistency; a degraded detailed check (checkSucceeded=false) is reported, not failed.Verification: local mikopbx-php83 (2026.1.223, Docker): the three files pass 36/36; the unmodified files fail exactly these 4 tests on the same stand.
Устаревшие ожидания в трёх тестах REST: новый текст лога дедупликации SIP, переводимые сообщения 422 у S3, отсутствие прошивок для Docker на сервере релизов (намеренно). Проверено на локальном Docker: 36/36, старые версии падают ровно в 4 тестах.