Conversation
Contributor
|
quit spamming our repo with slop |
Contributor
|
whoopsies |
Sweaterdog
approved these changes
Aug 31, 2026
Sweaterdog
left a comment
Contributor
There was a problem hiding this comment.
Succinctly does what is required to fix it for all model endpoints.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improve cleanup of reasoning-model output before Mindcraft uses it as a conversation response or memory summary.
Some reasoning-capable models can expose internal reasoning delimiters such as
</think>or emit the configured***stop sequence literally. Mindcraft already strips</think>, but the current implementation only takes the first segment after the marker.Changes
_cleanReasoningOutput()helper</think>marker***stop-sequence leakageWhy
During testing with an OpenAI-compatible local reasoning model, responses occasionally contained: