search: hyphenated titles and stopwords no longer empty BOOLEAN results - #526
Open
t0ma5 wants to merge 1 commit into
Open
search: hyphenated titles and stopwords no longer empty BOOLEAN results#526t0ma5 wants to merge 1 commit into
t0ma5 wants to merge 1 commit into
Conversation
…search MySQL FULLTEXT indexes co-working as co plus working. Stripping the hyphen required +coworking*, which matched nothing. InnoDB stopwords (+and*, +in*) failed the same way. Split punctuation and skip tokens the index does not store. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
co-workingintocoworking, which FULLTEXT never indexed (it storesco+working), so pasting a hyphenated title returned no rows.+and*/+in*failed the same way: InnoDB's default stopword list does not store those words, but BOOLEAN truncation still required them.Test plan
php tests/models/search.php— 58 passed, including hyphenated title paste (Co-working space in Aville) and tokenco-working-termexclusion, quoted phrase, below-min-length LIKE fallbackand/ininto public search; that listing is in the result setMade with Cursor