Skip to content

Test refactorings for improved code coverage#976

Merged
michelebastione merged 3 commits into
mini-software:masterfrom
michelebastione:coverage-improvement
Jun 21, 2026
Merged

Test refactorings for improved code coverage#976
michelebastione merged 3 commits into
mini-software:masterfrom
michelebastione:coverage-improvement

Conversation

@michelebastione

@michelebastione michelebastione commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

The following changes have been implemented to improve test coverage:

  • Added .runsettings file for code coverage configuration
  • Expanded test target frameworks to include NET8 and NET9
  • Separated OpenXmlImporter and OpenXmlExporter tests
  • Added new tests for retrieving sheet informations, sheet dimensions and column names
  • Added new queryrange tests
  • Removed obsolete FileHelper test utility class
  • Removed removed superfluous excel test files

closes #864

Added .runsettings file for configuring code coverage, separated OpenXmlImporter and OpenXmlExporter tests, added new tests for retrieving sheet informations, sheet dimensions and column names, added new queryrange tests, added new addpicture test, removed obsolete FileHelper test utility class

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several enhancements and test refactorings, including adding a .runsettings file for code coverage, making NextResult abstract in MiniExcelDataReaderBase, adding .xlsm format validation, and splitting OpenXml importer and exporter tests into dedicated files. Feedback on the changes highlights a redundant stream in FillTemplateAsync, potential file locking issues in template tests due to stream scope, and compiler warnings from synchronous test methods incorrectly marked as async Task. Additionally, it is recommended to use StringComparison.OrdinalIgnoreCase for file extension comparisons.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/MiniExcel.OpenXml.Tests/Templates/MiniExcelTemplateAsyncTests.cs Outdated
Comment thread tests/MiniExcel.OpenXml.Tests/Templates/MiniExcelTemplateTests.cs
Comment thread src/MiniExcel.OpenXml/Api/OpenXmlExporter.cs
Comment thread tests/MiniExcel.OpenXml.Tests/AlterSheets/MiniExcelAlterSheetsTests.cs Outdated
Comment thread tests/MiniExcel.OpenXml.Tests/DataReader/OpenXmlDataReaderTests.cs Outdated
@michelebastione michelebastione merged commit 1932687 into mini-software:master Jun 21, 2026
3 checks passed
@michelebastione michelebastione deleted the coverage-improvement branch June 21, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unit test coverage improvements

1 participant