Repository navigation
Conversation
Add GitLab CI, CircleCI, Azure Pipelines, and Google Cloud Build workflows using documented mint build flags. Fix Jenkins and GitHub Actions examples (--continue-after=app-exit, workflow syntax). Signed-off-by: hippi345 <13539685+hippi345@users.noreply.github.com>
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 files)
Reviewed by free · Input: 65.9K · Output: 1.1K · Cached: 64K |
Contributor
|
looking |
There was a problem hiding this comment.
🟡 Changes recommended
Unresolved issues in the README examples can cause CI validation failures, block Docker daemon access, or end monitoring before required runtime files are captured.
5 open issues
What changed in this PR
Expands the README’s CI/CD integration guidance for Mint image optimization, addressing issue #72 with examples for more platforms.
Changes:
- Adds GitLab CI, CircleCI, Azure Pipelines, and Google Cloud Build examples.
- Updates Jenkins examples to use explicit probing and continuation flags.
- Corrects GitHub Actions tag expressions and login-step formatting.
| File | Description |
|---|---|
| README.md | Expands CI/CD examples and updates existing Jenkins and GitHub Actions snippets. |
Review effort: Balanced
| sh 'docker run --rm -v /var/run/docker.sock:/var/run/docker.sock mintoolkit/mint \ | ||
| build --target IMAGE_NAME:$BUILD_NUMBER --tag IMAGE_NAME:slim-$BUILD_NUMBER \ | ||
| exit' | ||
| --http-probe=false --continue-after=app-exit' |
|
|
||
| ```yaml | ||
| slim-image: | ||
| stage: slim |
Comment on lines
+1048
to
+1049
| docker run --rm \ | ||
| -e DOCKER_HOST -e DOCKER_TLS_VERIFY -e DOCKER_CERT_PATH \ |
| - docker build -t "$CI_REGISTRY_IMAGE:$CI_COMMIT_SHA" . | ||
| - | | ||
| docker run --rm \ | ||
| -e DOCKER_HOST -e DOCKER_TLS_VERIFY -e DOCKER_CERT_PATH \ |
Comment on lines
+1111
to
+1113
| volumes: | ||
| - name: docker | ||
| path: /var/run/docker.sock |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes-72
What
Expand the README CI/CD INTEGRATIONS section with GitLab CI, CircleCI, Azure Pipelines, and Google Cloud Build examples that use
mint buildand documented flags. Correct the Jenkins and GitHub Actions snippets (--continue-after=app-exit,${{ github.run_number }}, login step formatting).Why
Issue #72 asks for more and clearer CI/CD integration examples across common platforms; the section previously only covered Jenkins and GitHub Actions.
How Tested
make testCloses #72