Skip to content

MIR-2199: Describe Workbench as a public beta in detective help - #1432

Merged
evanphx merged 1 commit into
mainfrom
evan/mir-2199-change-wording-about-workbench-availability-in-cli
Nov 5, 2026
Merged

evanphx merged 1 commit into
mainfrom
evan/mir-2199-change-wording-about-workbench-availability-in-cli

Conversation

@evanphx

@evanphx evanphx commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Why

miren detective --help and its generated docs still describe Workbench as a Miren Labs feature that you request access to on Discord. Workbench is moving to a public beta, so this text now says so. Resolves MIR-2199.

Change

  • The first line of the description now reads "Workbench is in beta and available to all Miren Cloud users."
  • The requirements no longer list "Workbench enabled for the cluster's organization". A Cloud-registered cluster and a Cloud login are still required.
  • docs/docs/command/detective.md was regenerated with go generate ./cli/commands/.

Concerns

This wording assumes every org gets access. On Cloud main today, the askworkbench flag is still off by default, and Cloud's 403 still says "Ask Workbench is a Miren Labs feature… Ask for access on Discord". Ship this together with the Cloud change that opens access, or the CLI and Cloud will contradict each other.

Verification

  • make bin/miren builds.
  • go test ./cli/commands/ -run 'TestDocs|Detective|Workbench' passes.
  • Docs regeneration changed only detective.md.

Amp thread: https://ampcode.com/threads/T-44c4284d-7078-40db-b132-888ce0deb19c

The detective description still called Workbench a Miren Labs feature
gated behind a Discord access request. Say instead that it is in beta for
all Miren Cloud users, and drop the per-organization enablement requirement.

Resolves MIR-2199.

@miren-code-agent miren-code-agent Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪 biscuit: ✅ ready to merge — auto-review, non-blocking

This does what MIR-2199 asks. miren detective --help now describes Workbench as a public beta and no longer says it has to be enabled for each organization. The regenerated docs/docs/command/detective.md matches the new workbenchDescription constant in cli/commands/workbench.go line for line. Nothing else in cli/ or docs/ still describes Workbench as a Labs feature or needing Discord access. The remaining "Ask Workbench" strings at workbench.go:185 and workbench_ui.go:429 are just the chat banner, and they still read correctly.

The code is ready. I'm not recommending approval because of when it should merge, which is your call. You noted that Cloud still gates access behind a flag that's off by default, and its 403 still sends people to Discord. If this lands first, a user in an org without the flag will see "available to all Miren Cloud users" in --help and then get the old denial message. A human should decide whether to hold this until the Cloud change ships, or merge now and accept a short window where the CLI and Cloud disagree.


🍪 full review note · reviewed at f091f80

evanphx commented Nov 5, 2026

Copy link
Copy Markdown
Contributor Author

Thanks. The merge timing depends on the Cloud change that opens Workbench to every org, so a human will make that call. No code changes needed for this review.

@evanphx
evanphx marked this pull request as ready for review November 5, 2026 20:14
@evanphx
evanphx requested a review from a team as a code owner November 5, 2026 20:14
@evanphx
evanphx merged commit 9958ac5 into main Nov 5, 2026
26 checks passed
@evanphx
evanphx deleted the evan/mir-2199-change-wording-about-workbench-availability-in-cli branch November 5, 2026 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants