Repository navigation
Conversation
The detective description still called Workbench a Miren Labs feature gated behind a Discord access request. Say instead that it is in beta for all Miren Cloud users, and drop the per-organization enablement requirement. Resolves MIR-2199.
There was a problem hiding this comment.
🍪 biscuit: ✅ ready to merge — auto-review, non-blocking
This does what MIR-2199 asks. miren detective --help now describes Workbench as a public beta and no longer says it has to be enabled for each organization. The regenerated docs/docs/command/detective.md matches the new workbenchDescription constant in cli/commands/workbench.go line for line. Nothing else in cli/ or docs/ still describes Workbench as a Labs feature or needing Discord access. The remaining "Ask Workbench" strings at workbench.go:185 and workbench_ui.go:429 are just the chat banner, and they still read correctly.
The code is ready. I'm not recommending approval because of when it should merge, which is your call. You noted that Cloud still gates access behind a flag that's off by default, and its 403 still sends people to Discord. If this lands first, a user in an org without the flag will see "available to all Miren Cloud users" in --help and then get the old denial message. A human should decide whether to hold this until the Cloud change ships, or merge now and accept a short window where the CLI and Cloud disagree.
🍪 full review note · reviewed at f091f80
|
Thanks. The merge timing depends on the Cloud change that opens Workbench to every org, so a human will make that call. No code changes needed for this review. |
Why
miren detective --helpand its generated docs still describe Workbench as a Miren Labs feature that you request access to on Discord. Workbench is moving to a public beta, so this text now says so. Resolves MIR-2199.Change
docs/docs/command/detective.mdwas regenerated withgo generate ./cli/commands/.Concerns
This wording assumes every org gets access. On Cloud
maintoday, theaskworkbenchflag is still off by default, and Cloud's 403 still says "Ask Workbench is a Miren Labs feature… Ask for access on Discord". Ship this together with the Cloud change that opens access, or the CLI and Cloud will contradict each other.Verification
make bin/mirenbuilds.go test ./cli/commands/ -run 'TestDocs|Detective|Workbench'passes.detective.md.Amp thread: https://ampcode.com/threads/T-44c4284d-7078-40db-b132-888ce0deb19c