Add and apply most of rust-bitcoin's lints - #140
Open
luisschwab wants to merge 6 commits into
Open
Conversation
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
July 8, 2026 20:53
c2e655d to
de8c93a
Compare
Contributor
Author
|
Added the ~$ cargo rbmt test
[...]
Tests complete.
Test Summary
Commit: de8c93a0b0bdd4864cb512bd5344a81a925cf2a2
Package: rustreexo
Examples : stump_modify, stump_modify:std, stump_modify:with-serde, stump_modify:with-serde std, proof_update, proof_update:std, proof_update:with-serde, proof_update:with-serde std, custom_hash, custom_hash:std, custom_hash:with-serde, custom_hash:with-serde std
Individual features: serde, std, with-serde
Feature subsets : [serde, std], [serde, with-serde], [std, with-serde]
+ No-std check : ran |
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
July 8, 2026 21:34
1bdc74d to
243e3cb
Compare
Davidson-Souza
requested changes
Jul 16, 2026
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
July 17, 2026 18:52
243e3cb to
425181b
Compare
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
July 27, 2026 09:02
425181b to
b3b859c
Compare
Contributor
Author
|
@Davidson-Souza latest reviews are addressed |
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
August 4, 2026 20:21
b3b859c to
ee6851d
Compare
Contributor
Author
|
ee6851d rebased on |
Collaborator
|
Needs rebase again |
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
August 5, 2026 13:27
ee6851d to
b9eaf93
Compare
* Bump the Rust edition to 2021 (released on Rust 1.56.0) * Add the `tools` field to `[package.metadata.rbmt]`, such that CI and local `cargo-audit` and Zizmor versions are in sync * Update the Zizmor CI job to set up rbmt's tools * Update the justfile and README
The `default_trait_access` lint complained that we were instantiating a `HashMap` with `HashMap::with_hasher(Default::default())`. I've mirrored the helpers on the `std` prelude such that we may keep the two in sync.
Import the `std` crate, feature gated on the `std` feature, and add the `#![no_std]` attribute such that `cargo-rbmt` also tests the crate in a no-std target (`thumbv7m-none-eabi`).
Add and apply all `rust-bitcoin` lints, except for documentation lints.
luisschwab
force-pushed
the
chore/add-rust-bitcoin-lints
branch
from
August 5, 2026 13:28
b9eaf93 to
e29d1fe
Compare
Contributor
Author
|
e29d1fe rebased on |
* Bump `stable` from 1.96.0 to 1.97.1 * Bump `nightly` from `nightly-2026-06-23` to `nightly-2026-08-04` * Fix the `clippy::mut_mut` lint on `Stump::serialize`
Contributor
Author
|
eaf1f5d bumped toolchains and fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog