Repository navigation
Read each module's atom table once in the cloak reachability test - #1008
Merged
Merged
Conversation
The scan called Application.app_dir (a code-server round trip) and :beam_lib.chunks for every module up to three times, once per affected cloak module. Behind a loaded code server that stalled the test past ExUnit's 60 s timeout (chg S10 shadow on minis, 2026-10-19). The ebin dir is now resolved once and each atom table read once, intersected with the affected set.
Owner
Author
|
Review round 1 (code) counted at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CloakAdvisoryReachabilityTestread every:loopctlmodule's atom table up to three times, once per affected cloak module, insideEnum.any?(@affected, ...). Each read made anApplication.app_dir/2call, which goes through the code server, plus a:beam_lib.chunkscall.On minis under load (20-34, with home_care_billing suites running at the same time), the chg S10 shadow run saw this test exceed ExUnit's 60 s timeout. It was waiting on
:code_server.call(see mkreyman/home_care_billing#2544 for the same code-server stall).The fix:
ebinis resolved once.MapSet.What the test asserts is unchanged: the GCM positive control still guards against a vacuous scan. Test-only; no operator-facing change.