Repository navigation
Add lecture notebook smoke tests and GitHub Actions workflow - #5
Merged
Merged
Conversation
Pins a CI-safe nbclient runner with stdin/widget/optimize caps so PRs that touch notebooks can catch runtime regressions without hanging on interactive cells.
Pin daft-pgm (not PyPI daft) and pre-create lecture diagram directories so notebook writes do not fail with FileNotFoundError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/smoke_notebooks.py: nbclient runner with Agg backend, mocked stdin, capped GPy/DeepGPoptimize, and short-circuitedipywidgets.interact/notutils.display_plotsso interactive lecture cells do not hang in CI.requirements-smoke.txtfor a reproducible smoke environment (GPy, PyDeepGP, mlai, pods, notutils, emukit, …)..github/workflows/notebook-smoke.yml: runs on PRs that touch notebooks/smoke files, weekly schedule, andworkflow_dispatch(optional--onlyprefixes). Uploads_notebooks/test-resultsas an artifact.Test plan
python scripts/smoke_notebooks.py --only 01 06→ 2/2 passedonlyfor the full 13-notebook suitenotebook-smoke-resultscontainssummary.json_notebooks/*.ipynbshould