Repository navigation
Fix Deep GP notebook smoke: write_figure and MNIST ARFF parser - #7
Merged
Merged
Conversation
Lecture 11 smoke was failing without system latex because the PGM cells set usetex=True. Lecture 12 hits a pandas 3 TypeError in sklearn's default OpenML ARFF parser. Matches snippets PR 64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usetex=Trueon the PGM cells and save the Markov diagrams withmlai.write_figure, so weekly smoke no longer needs system latex.as_frame=False, parser='liac-arff'and subsample with NumPy, avoiding the pandas 3TypeErrorin sklearn's default OpenML ARFF parser.Source of truth is lawrennd/snippets#64. This is the generated-file stopgap until a LaMD rebuild, matching PR #6.
Test plan
11-deep-gps-Iand12-deep-gps-IIfetch_openmlno longer TypeErrors (full MNIST download is still slow)