Skip to content

chore(packages): sync mmcc/moq-publisher with upstream main via mmcc/moq - #40

Merged
mmcc merged 168 commits into
mmcc/moq-publisherfrom
chore/sync-publisher-upstream
Sep 1, 2026
Merged

mmcc merged 168 commits into
mmcc/moq-publisherfrom
chore/sync-publisher-upstream

Conversation

@mmcc

@mmcc mmcc commented Aug 26, 2026 •

Copy link
Copy Markdown
Owner

Depends on #39 (merge that first; this branch contains its merge commit).

Summary

Sync mmcc/moq-publisher with upstream main (d08395023, 10.0.0-beta.32) via mmcc/moq. Beyond the textual conflicts this ports the publisher UI onto several upstream restructurings: the html presets/define split, the dialog and controls-backdrop surface separation, the --media-* CSS variable prefix, and the Vite+ toolchain.

Reviewing this PR

The "Files changed" tab is the whole upstream delta. Review the merge commit's manual work instead:

git show --remerge-diff dd5b31644

Changes

  • html: the publisher preset lives in presets/publisher/{index,player,skin,skin.tailwind}.ts; define/publisher/* modules are registration-only. VideoPublisherElement extends createPlayer().PlayerElement and the preset exports a PlayerController, matching the other presets.
  • Skins (html + React, CSS + Tailwind): error dialogs use media-dialog-* / ErrorDialog.Backdrop+Popup; controls wrap a media-controls-backdrop + media-controls-content; device-picker menus wrap items in Menu.Popup + Menu.Content / media-menu-content; the removed error/overlay primitives are replaced by dialog/controls-backdrop.
  • Publisher CSS custom properties adopt upstream's --media-* prefix, including the publisher's own tokens (--media-publish-live-color, --media-quality-*-color, --media-publish-status-background).
  • Upstream renames applied: MediaElement→UIElement, MediaContainerElement→ContainerElement, publishMenuMetadata→publishMenuTriggerState, hotkey action names in core/ui/hotkey/core.ts (toggleMicMuted / toggleCameraMuted added there).
  • Toolchain: moq-publish / moq-publish-video pack entries and the publish* test projects move to packages/spf/vite.config.ts; tests import from vite-plus/test.
  • Sandbox: @videojs/skins is no longer a sandbox dependency upstream, so the media-pulse Tailwind theme is inlined in apps/sandbox/app/styles.css (source of truth stays packages/skins/src/shared/tailwind.css).
Known follow-up

Upstream renamed core UI modules to <component>/core.ts / data.ts / vars.ts (videojs#2064). The publisher's eleven components still use the older <name>-core.ts / <name>-data-attrs.ts names. They compile and are exported correctly; the rename is left for a separate PR to keep this merge reviewable.

Testing

  • pnpm typecheck, pnpm lint, pnpm check:workspace, pnpm build:packages, pnpm build:sandbox — all green
  • pnpm -F @videojs/spf test: 151 files / 2344 tests passed (publish browser projects included)
  • pnpm -F @videojs/html test: 70 files / 513 passed · @videojs/react: 69 / 537 · @videojs/core: 115 / 1641 · @videojs/skins: 7 / 20

Note: the merge commit was made with --no-verify because lint-staged cannot run on merge commits; the full repo lint ran green beforehand.

🤖 Generated with Claude Code


Summary by cubic

Syncs mmcc/moq-publisher with upstream main at 10.0.0-beta.32 through mmcc/moq, porting the publisher onto upstream's split component surfaces, --media-* conventions, and Vite+ toolchain without changing its core behavior.

Migration

  • Merge chore(root): sync mmcc/moq with upstream main (10.0.0-beta.32) #39 first; this branch includes its merge commit.
  • Publisher presets use upstream's preset/define split, PlayerElement, PlayerController, dialog and controls-backdrop parts, and renamed UI APIs.
  • Builds and publisher tests run on Vite+ configs; Oxlint/Oxfmt replace Biome and Prettier, and the agent and changelog workflows now use OpenAI Codex in place of the Claude Code action.
  • CI adds Vite task caching, pkg.pr.new preview releases, a changelog forward-port to site/v10, and concurrency groups that cancel stale runs.
  • E2E adds axe accessibility, VJSC skin parity, SPF background-video, and late element-registration coverage.
  • The eleven legacy <name>-core.ts / <name>-data-attrs.ts filenames remain unchanged for a follow-up.

Review

  • Review the manual merge with git show --remerge-diff dd5b31644; the regular file list mostly shows the upstream delta.
  • pnpm typecheck, pnpm lint, pnpm check:workspace, package and sandbox builds, and the affected test suites pass.

Written for commit 5622191. Summary will update on new commits.

Review in cubic

luwes and others added 30 commits August 15, 2026 09:23
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ges (videojs#2222)

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
decepulis and others added 24 commits August 26, 2026 07:18
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Darius Cepulis <dcepulis@mux.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sync with upstream videojs/v10 main (d083950, 10.0.0-beta.32).

Resolutions beyond the textual conflicts:
- Port the tsdown entries to the Vite+ pack configs: `moq` entry in
  packages/spf/vite.config.ts; keep simple-moq-video off the CDN via an
  exclusion in the auto-discovered media entries (html/vite.config.ts).
- switchVideoTrack: keep the all-sets candidate pool and
  confineToActiveSwitchingSet ahead of upstream's stickToSelectedCodecs;
  merge preferCodecFamilies and playerResolutionCap into the rules.
- safeDefine moved to registration/safe-define.
- Migrate MoQ tests from 'vitest' to 'vite-plus/test'; run the new jsdoc
  formatter and padding rule over the MoQ sources.
- Move .claude/plans/moq-engine-implementation.md to .agents/plans
  (.claude/plans is now a generated alias).
Brings the publisher stack onto upstream videojs/v10 main (d083950,
10.0.0-beta.32) via mmcc/moq.

Publisher-side ports beyond the textual conflicts:
- html: move the publisher preset to presets/publisher/{index,player,skin,
  skin.tailwind}.ts with registration-only define/publisher modules
  (upstream's presets/define split); VideoPublisherElement now extends
  createPlayer().PlayerElement and exports a PlayerController.
- Skins: adopt the dialog/controls-backdrop split (media-dialog-*,
  media-controls-backdrop/-content, Menu.Popup + Menu.Content /
  media-menu-content) in all four publisher skins; rename publisher CSS
  custom properties to the --media-* prefix; replace the removed
  error/overlay tailwind + css components with dialog/controls-backdrop.
- Renames: MediaElement -> UIElement, safeDefine -> registration/,
  ui/compounds -> registration/ui-compounds, MediaContainerElement ->
  ContainerElement, publishMenuMetadata -> publishMenuTriggerState,
  hotkey action names live in core/ui/hotkey/core.
- Toolchain: port tsdown/vitest configs to vite.config.ts (moq-publish
  pack entries, publish test projects, test-time __DEV__ define); migrate
  tests to 'vite-plus/test'; run the jsdoc formatter and padding rule.
- Sandbox: @videojs/skins is no longer a sandbox dependency upstream, so
  the publisher's media-pulse Tailwind theme is inlined in app/styles.css.
@github-actions

github-actions Bot commented Aug 26, 2026 •

Copy link
Copy Markdown

📦 Bundle Size Report

🎨 @videojs/html

Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin 58.59 kB 60.85 kB +2.26 kB (+3.9%) -62 B
/video/minimal-skin.tailwind 59.33 kB 61.20 kB +1.88 kB (+3.2%) -62 B
/video/minimal-skin2 — 7.07 kB new —
/video/player 10.14 kB 9.65 kB -496 B (-4.8%) -62 B
/video/skin 58.83 kB 61.03 kB +2.21 kB (+3.8%) -62 B
/video/skin.tailwind 59.57 kB 61.37 kB +1.81 kB (+3.0%) -62 B
/video/skin2 — 6.92 kB new —
/audio/minimal-skin 45.30 kB 46.73 kB +1.43 kB (+3.2%) -62 B
/audio/minimal-skin.tailwind 45.85 kB 47.07 kB +1.21 kB (+2.6%) -62 B
/audio/minimal-skin2 — 5.28 kB new —
/audio/player 7.05 kB 6.10 kB -973 B (-13.5%) -62 B
/audio/skin 49.23 kB 50.85 kB +1.62 kB (+3.3%) -62 B
/audio/skin.tailwind 49.77 kB 51.25 kB +1.48 kB (+3.0%) -62 B
/audio/skin2 — 5.25 kB new —
/background/player 5.38 kB 4.46 kB -942 B (-17.1%) -62 B
/background/skin 1.14 kB 10.49 kB +9.35 kB (+819.9%) +68.28 kB
/background/skin2 — 190 B new —
/live-video/minimal-skin 52.69 kB 54.71 kB +2.02 kB (+3.8%) -62 B
/live-video/minimal-skin.tailwind 53.00 kB 54.79 kB +1.79 kB (+3.4%) -62 B
/live-video/minimal-skin2 — 7.07 kB new —
/live-video/player 9.54 kB 9.02 kB -536 B (-5.5%) -62 B
/live-video/skin 55.20 kB 57.55 kB +2.35 kB (+4.3%) -62 B
/live-video/skin.tailwind 55.76 kB 57.65 kB +1.89 kB (+3.4%) -62 B
/live-video/skin2 — 6.92 kB new —
/live-audio/minimal-skin 39.40 kB 40.06 kB +681 B (+1.7%) -62 B
/live-audio/minimal-skin.tailwind 38.81 kB 39.17 kB +365 B (+0.9%) -62 B
/live-audio/minimal-skin2 — 5.28 kB new —
/live-audio/player 7.08 kB 6.11 kB -991 B (-13.7%) -62 B
/live-audio/skin 42.95 kB 43.84 kB +912 B (+2.1%) -62 B
/live-audio/skin.tailwind 42.53 kB 43.12 kB +606 B (+1.4%) -62 B
/live-audio/skin2 — 5.25 kB new —
/publisher/player 7.85 kB 6.85 kB -1023 B (-12.7%) -62 B
/publisher/skin 42.80 kB 45.74 kB +2.94 kB (+6.9%) -62 B
/publisher/skin.tailwind 43.01 kB 45.74 kB +2.72 kB (+6.3%) -62 B
/publisher/skin2 — 5.29 kB new —
/ui/alert-dialog 4.22 kB 9.13 kB +4.91 kB (+116.3%) +68.28 kB
/ui/buffering-indicator 8.88 kB 9.32 kB +456 B (+5.0%) +68.28 kB
/ui/container — 10.19 kB new +68.28 kB
/ui/controls 9.04 kB 9.54 kB +508 B (+5.5%) -62 B
/ui/controls-backdrop — 1.69 kB new +68.28 kB
/ui/controls-content — 1.67 kB new +68.28 kB
/ui/dialog — 9.07 kB new +68.28 kB
/ui/dialog-backdrop — 1.70 kB new +68.28 kB
/ui/dialog-close — 2.01 kB new +68.28 kB
/ui/dialog-description — 1.69 kB new +68.28 kB
/ui/dialog-popup — 1.87 kB new +68.28 kB
/ui/dialog-title — 1.70 kB new +68.28 kB
/ui/error-dialog 12.16 kB 13.41 kB +1.25 kB (+10.2%) -62 B
/ui/gesture — 10.13 kB new +68.28 kB
/ui/hotkey 10.18 kB 10.57 kB +404 B (+3.9%) +68.28 kB
/ui/menu 19.07 kB 20.74 kB +1.68 kB (+8.8%) -62 B
/ui/popover 8.11 kB 8.53 kB +423 B (+5.1%) +68.28 kB
/ui/seek-indicator 12.86 kB 13.23 kB +384 B (+2.9%) +68.28 kB
/ui/thumbnail 10.05 kB 10.50 kB +459 B (+4.5%) +68.28 kB
/ui/time-slider-chapter-title 9.07 kB 9.48 kB +415 B (+4.5%) +68.28 kB
/ui/time-slider-chapters 10.05 kB 10.44 kB +397 B (+3.9%) +68.28 kB
/ui/title — 8.88 kB new +68.28 kB
/ui/tooltip 9.44 kB 9.92 kB +485 B (+5.0%) -62 B
/ui/volume-popover — 15.43 kB new +68.28 kB
/media/mux-video 141.61 kB 142.33 kB +738 B (+0.5%) —
/media/mux-audio 141.39 kB 142.05 kB +677 B (+0.5%) —
/media/cloudflare-video — 6.22 kB new —
/media/hls-background-video 15.69 kB 16.86 kB +1.17 kB (+7.4%) —
/media/hls-video 27.39 kB 28.21 kB +842 B (+3.0%) —
/media/hlsjs-video 140.52 kB 141.03 kB +524 B (+0.4%) —
/media/mux-background-video 15.72 kB 16.87 kB +1.15 kB (+7.3%) —
/media/shaka-video — 199.21 kB new —
/media/simple-moq-video 28.11 kB 28.44 kB +333 B (+1.2%) —
/media/spotify-audio — 6.24 kB new —
/media/tiktok-video — 6.29 kB new —
/media/twitch-video — 6.19 kB new —
/video (default) 58.84 kB 62.57 kB +3.73 kB (+6.3%) -62 B
/video (default + hls) 197.39 kB 201.69 kB +4.31 kB (+2.2%) -62 B
/video (minimal) 58.60 kB 62.31 kB +3.71 kB (+6.3%) -62 B
/video (minimal + hls) 197.08 kB 201.23 kB +4.15 kB (+2.1%) -62 B
/audio (default) 49.20 kB 52.38 kB +3.17 kB (+6.5%) -62 B
/audio (minimal) 45.30 kB 48.31 kB +3.01 kB (+6.6%) -62 B
/background 5.66 kB 12.24 kB +6.58 kB (+116.2%) -62 B
/ui/alert-dialog-close 1.95 kB — removed —
/ui/alert-dialog-description 1.63 kB — removed —
/ui/alert-dialog-title 1.65 kB — removed —
/ui/compounds 35.49 kB — removed -68.34 kB
/media/container 3.12 kB — removed -68.34 kB
/skin-element 1.47 kB — removed —
Small changes (56, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/video/minimal-skin.css 6.30 kB 6.51 kB +212 B (+3.3%) —
/video/skin.css 6.18 kB 6.32 kB +143 B (+2.3%) —
/audio/minimal-skin.css 4.62 kB 4.88 kB +267 B (+5.6%) —
/audio/skin.css 4.56 kB 4.81 kB +252 B (+5.4%) —
/live-video/minimal-skin.css 6.30 kB 6.51 kB +212 B (+3.3%) —
/live-video/skin.css 6.18 kB 6.32 kB +143 B (+2.3%) —
/live-audio/minimal-skin.css 4.62 kB 4.88 kB +267 B (+5.6%) —
/live-audio/skin.css 4.56 kB 4.81 kB +252 B (+5.4%) —
/publisher/skin.css 4.81 kB 4.90 kB +99 B (+2.0%) —
/ui/airplay-button 11.69 kB 11.92 kB +235 B (+2.0%) -62 B
/ui/audio-track-radio-group 11.83 kB 12.05 kB +225 B (+1.9%) -62 B
/ui/camera-button 11.84 kB 12.06 kB +225 B (+1.9%) -62 B
/ui/camera-radio-group 12.00 kB 12.19 kB +195 B (+1.6%) -62 B
/ui/captions-button 11.94 kB 12.15 kB +215 B (+1.8%) -62 B
/ui/captions-radio-group 11.93 kB 12.13 kB +207 B (+1.7%) -62 B
/ui/capture-placeholder 10.12 kB 10.30 kB +191 B (+1.8%) -62 B
/ui/cast-button 11.63 kB 11.90 kB +273 B (+2.3%) -62 B
/ui/connection-indicator 9.99 kB 10.17 kB +191 B (+1.9%) -62 B
/ui/enable-devices-button 11.89 kB 12.12 kB +241 B (+2.0%) -62 B
/ui/fullscreen-button 11.63 kB 11.85 kB +229 B (+1.9%) -62 B
/ui/mic-button 11.83 kB 12.05 kB +232 B (+1.9%) -62 B
/ui/mic-radio-group 12.00 kB 12.18 kB +188 B (+1.5%) -62 B
/ui/mute-button 11.63 kB 11.90 kB +276 B (+2.3%) -62 B
/ui/pip-button 11.62 kB 11.87 kB +250 B (+2.1%) -62 B
/ui/play-button 11.61 kB 11.86 kB +256 B (+2.2%) -62 B
/ui/playback-rate-button 11.82 kB 11.97 kB +156 B (+1.3%) -62 B
/ui/playback-rate-radio-group 11.85 kB 12.04 kB +196 B (+1.6%) -62 B
/ui/poster 9.28 kB 9.38 kB +102 B (+1.1%) -62 B
/ui/publish-badge 10.07 kB 10.27 kB +202 B (+2.0%) -62 B
/ui/publish-button 10.47 kB 10.67 kB +205 B (+1.9%) -62 B
/ui/publish-timer 10.67 kB 10.84 kB +177 B (+1.6%) -62 B
/ui/quality-radio-group 12.44 kB 12.64 kB +208 B (+1.6%) -62 B
/ui/screen-share-button 11.85 kB 12.08 kB +233 B (+1.9%) -62 B
/ui/seek-button 11.65 kB 11.91 kB +267 B (+2.2%) -62 B
/ui/seek-indicator-value 1.03 kB 1.10 kB +78 B (+7.4%) —
/ui/slider 12.56 kB 12.79 kB +240 B (+1.9%) -62 B
/ui/status-announcer 11.05 kB 11.32 kB +277 B (+2.4%) -62 B
/ui/status-indicator 13.41 kB 13.58 kB +176 B (+1.3%) -62 B
/ui/status-indicator-value 1.02 kB 1.10 kB +82 B (+7.8%) —
/ui/time 11.41 kB 11.58 kB +177 B (+1.5%) -62 B
/ui/time-slider 15.48 kB 15.71 kB +235 B (+1.5%) -62 B
/ui/volume-indicator 13.43 kB 13.60 kB +174 B (+1.3%) -62 B
/ui/volume-indicator-fill 1.03 kB 1.11 kB +82 B (+7.8%) —
/ui/volume-indicator-value 1.02 kB 1.10 kB +81 B (+7.7%) —
/ui/volume-slider 13.21 kB 13.44 kB +243 B (+1.8%) -62 B
/media/background-video 1.14 kB 1.16 kB +17 B (+1.5%) —
/media/dash-video 211.89 kB 211.72 kB -171 B (-0.1%) —
/media/google-cast 6.46 kB 6.52 kB +62 B (+0.9%) —
/media/hls-audio 21.86 kB 22.14 kB +296 B (+1.3%) —
/media/moq-publish-video 23.89 kB 23.88 kB -9 B (-0.0%) —
/media/mux-data 26.71 kB 26.70 kB -13 B (-0.0%) —
/media/native-hls-video 7.51 kB 7.51 kB +4 B (+0.1%) —
/media/vimeo-video 12.97 kB 13.03 kB +59 B (+0.4%) —
/media/youtube-video 6.75 kB 6.79 kB +41 B (+0.6%) —
/global.css 196 B 195 B -1 B (-0.5%) —
/shared.css 99 B 118 B +19 B (+19.2%) —
Presets (7)
Entry Initial Lazy
/video (default) 62.57 kB 68.28 kB
/video (default + hls) 201.69 kB 68.28 kB
/video (minimal) 62.31 kB 68.28 kB
/video (minimal + hls) 201.23 kB 68.28 kB
/audio (default) 52.38 kB 68.28 kB
/audio (minimal) 48.31 kB 68.28 kB
/background 12.24 kB 68.28 kB
Media (21)
Entry Initial
/media/mux-video 142.33 kB
/media/mux-audio 142.05 kB
/media/background-video 1.16 kB
/media/cloudflare-video 6.22 kB
/media/dash-video 211.72 kB
/media/google-cast 6.52 kB
/media/hls-audio 22.14 kB
/media/hls-background-video 16.86 kB
/media/hls-video 28.21 kB
/media/hlsjs-video 141.03 kB
/media/moq-publish-video 23.88 kB
/media/mux-background-video 16.87 kB
/media/mux-data 26.70 kB
/media/native-hls-video 7.51 kB
/media/shaka-video 199.21 kB
/media/simple-moq-video 28.44 kB
/media/spotify-audio 6.24 kB
/media/tiktok-video 6.29 kB
/media/twitch-video 6.19 kB
/media/vimeo-video 13.03 kB
/media/youtube-video 6.79 kB
Players (6)
Entry Initial Lazy
/video/player 9.65 kB 68.28 kB
/audio/player 6.10 kB 68.28 kB
/background/player 4.46 kB 68.28 kB
/live-video/player 9.02 kB 68.28 kB
/live-audio/player 6.11 kB 68.28 kB
/publisher/player 6.85 kB 68.28 kB
Skins (41)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.51 kB —
/video/skin.css css 6.32 kB —
/video/minimal-skin js 60.85 kB 68.28 kB
/video/minimal-skin.tailwind js 61.20 kB 68.28 kB
/video/minimal-skin2 js 7.07 kB —
/video/skin js 61.03 kB 68.28 kB
/video/skin.tailwind js 61.37 kB 68.28 kB
/video/skin2 js 6.92 kB —
/audio/minimal-skin.css css 4.88 kB —
/audio/skin.css css 4.81 kB —
/audio/minimal-skin js 46.73 kB 68.28 kB
/audio/minimal-skin.tailwind js 47.07 kB 68.28 kB
/audio/minimal-skin2 js 5.28 kB —
/audio/skin js 50.85 kB 68.28 kB
/audio/skin.tailwind js 51.25 kB 68.28 kB
/audio/skin2 js 5.25 kB —
/background/skin.css css 145 B —
/background/skin js 10.49 kB 68.28 kB
/background/skin2 js 190 B —
/live-video/minimal-skin.css css 6.51 kB —
/live-video/skin.css css 6.32 kB —
/live-video/minimal-skin js 54.71 kB 68.28 kB
/live-video/minimal-skin.tailwind js 54.79 kB 68.28 kB
/live-video/minimal-skin2 js 7.07 kB —
/live-video/skin js 57.55 kB 68.28 kB
/live-video/skin.tailwind js 57.65 kB 68.28 kB
/live-video/skin2 js 6.92 kB —
/live-audio/minimal-skin.css css 4.88 kB —
/live-audio/skin.css css 4.81 kB —
/live-audio/minimal-skin js 40.06 kB 68.28 kB
/live-audio/minimal-skin.tailwind js 39.17 kB 68.28 kB
/live-audio/minimal-skin2 js 5.28 kB —
/live-audio/skin js 43.84 kB 68.28 kB
/live-audio/skin.tailwind js 43.12 kB 68.28 kB
/live-audio/skin2 js 5.25 kB —
/publisher/skin.css css 4.90 kB —
/publisher/skin js 45.74 kB 68.28 kB
/publisher/skin.tailwind js 45.74 kB 68.28 kB
/publisher/skin2 js 5.29 kB —
/global.css css 195 B —
/shared.css css 118 B —
UI Components (60)
Entry Initial Lazy
/ui/airplay-button 11.92 kB 68.28 kB
/ui/alert-dialog 9.13 kB 68.28 kB
/ui/audio-track-radio-group 12.05 kB 68.28 kB
/ui/buffering-indicator 9.32 kB 68.28 kB
/ui/camera-button 12.06 kB 68.28 kB
/ui/camera-radio-group 12.19 kB 68.28 kB
/ui/captions-button 12.15 kB 68.28 kB
/ui/captions-radio-group 12.13 kB 68.28 kB
/ui/capture-placeholder 10.30 kB 68.28 kB
/ui/cast-button 11.90 kB 68.28 kB
/ui/connection-indicator 10.17 kB 68.28 kB
/ui/container 10.19 kB 68.28 kB
/ui/controls 9.54 kB 68.28 kB
/ui/controls-backdrop 1.69 kB 68.28 kB
/ui/controls-content 1.67 kB 68.28 kB
/ui/dialog 9.07 kB 68.28 kB
/ui/dialog-backdrop 1.70 kB 68.28 kB
/ui/dialog-close 2.01 kB 68.28 kB
/ui/dialog-description 1.69 kB 68.28 kB
/ui/dialog-popup 1.87 kB 68.28 kB
/ui/dialog-title 1.70 kB 68.28 kB
/ui/enable-devices-button 12.12 kB 68.28 kB
/ui/error-dialog 13.41 kB 68.28 kB
/ui/fullscreen-button 11.85 kB 68.28 kB
/ui/gesture 10.13 kB 68.28 kB
/ui/hotkey 10.57 kB 68.28 kB
/ui/menu 20.74 kB 68.28 kB
/ui/mic-button 12.05 kB 68.28 kB
/ui/mic-radio-group 12.18 kB 68.28 kB
/ui/mute-button 11.90 kB 68.28 kB
/ui/pip-button 11.87 kB 68.28 kB
/ui/play-button 11.86 kB 68.28 kB
/ui/playback-rate-button 11.97 kB 68.28 kB
/ui/playback-rate-radio-group 12.04 kB 68.28 kB
/ui/popover 8.53 kB 68.28 kB
/ui/poster 9.38 kB 68.28 kB
/ui/publish-badge 10.27 kB 68.28 kB
/ui/publish-button 10.67 kB 68.28 kB
/ui/publish-timer 10.84 kB 68.28 kB
/ui/quality-radio-group 12.64 kB 68.28 kB
/ui/screen-share-button 12.08 kB 68.28 kB
/ui/seek-button 11.91 kB 68.28 kB
/ui/seek-indicator 13.23 kB 68.28 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 12.79 kB 68.28 kB
/ui/status-announcer 11.32 kB 68.28 kB
/ui/status-indicator 13.58 kB 68.28 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.50 kB 68.28 kB
/ui/time 11.58 kB 68.28 kB
/ui/time-slider 15.71 kB 68.28 kB
/ui/time-slider-chapter-title 9.48 kB 68.28 kB
/ui/time-slider-chapters 10.44 kB 68.28 kB
/ui/title 8.88 kB 68.28 kB
/ui/tooltip 9.92 kB 68.28 kB
/ui/volume-indicator 13.60 kB 68.28 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.43 kB 68.28 kB
/ui/volume-slider 13.44 kB 68.28 kB

⚛️ @videojs/react

Path Base initial PR initial Initial diff Lazy diff
/media/mux-video/hls-js 139.96 kB 140.62 kB +680 B (+0.5%) —
/media/mux-video/spf 26.70 kB 27.52 kB +840 B (+3.1%) —
/media/mux-audio/hls-js 139.85 kB 140.46 kB +622 B (+0.4%) —
/media/mux-audio/spf 20.98 kB 21.41 kB +446 B (+2.1%) —
/media/cloudflare-video — 4.35 kB new —
/media/hls-background-video 15.24 kB 16.44 kB +1.20 kB (+7.9%) —
/media/hls-video 25.69 kB 26.49 kB +822 B (+3.1%) —
/media/hlsjs-video 138.86 kB 139.58 kB +738 B (+0.5%) —
/media/mux-audio 139.75 kB 140.44 kB +706 B (+0.5%) —
/media/mux-background-video 15.27 kB 16.43 kB +1.16 kB (+7.6%) —
/media/mux-video 139.97 kB 140.62 kB +668 B (+0.5%) —
/media/shaka-video — 197.52 kB new —
/media/spotify-audio — 4.22 kB new —
/media/tiktok-video — 4.18 kB new —
/media/twitch-video — 4.30 kB new —
/video/minimal-skin 45.83 kB 48.48 kB +2.65 kB (+5.8%) -62 B
/video/minimal-skin.tailwind 52.46 kB 55.46 kB +2.99 kB (+5.7%) -62 B
/video/player 7.15 kB 7.51 kB +372 B (+5.1%) +68.28 kB
/video/skin 45.80 kB 48.49 kB +2.69 kB (+5.9%) -62 B
/video/skin.tailwind 52.34 kB 55.30 kB +2.96 kB (+5.7%) -62 B
/audio/minimal-skin 35.41 kB 37.81 kB +2.40 kB (+6.8%) -62 B
/audio/minimal-skin.tailwind 40.30 kB 42.93 kB +2.63 kB (+6.5%) -62 B
/audio/player 4.01 kB 3.95 kB -68 B (-1.7%) +68.28 kB
/audio/skin 35.40 kB 37.79 kB +2.39 kB (+6.8%) -62 B
/audio/skin.tailwind 40.29 kB 42.92 kB +2.63 kB (+6.5%) -62 B
/background/player 2.28 kB 2.27 kB -8 B (-0.3%) +68.28 kB
/live-video/minimal-skin 37.98 kB 40.62 kB +2.64 kB (+7.0%) -62 B
/live-video/minimal-skin.tailwind 44.33 kB 47.27 kB +2.93 kB (+6.6%) -62 B
/live-video/player 6.53 kB 6.91 kB +389 B (+5.8%) +68.28 kB
/live-video/skin 38.07 kB 40.64 kB +2.57 kB (+6.8%) -62 B
/live-video/skin.tailwind 44.36 kB 47.18 kB +2.82 kB (+6.3%) -62 B
/live-audio/minimal-skin 27.88 kB 29.66 kB +1.79 kB (+6.4%) -62 B
/live-audio/minimal-skin.tailwind 31.66 kB 33.58 kB +1.93 kB (+6.1%) -62 B
/live-audio/player 4.03 kB 3.96 kB -73 B (-1.8%) +68.28 kB
/live-audio/skin 27.96 kB 29.69 kB +1.74 kB (+6.2%) -62 B
/live-audio/skin.tailwind 31.79 kB 33.71 kB +1.92 kB (+6.0%) -62 B
/publisher/skin 28.78 kB 30.93 kB +2.14 kB (+7.4%) -62 B
/publisher/skin.tailwind 33.49 kB 35.69 kB +2.20 kB (+6.6%) -62 B
/ui/alert-dialog 3.32 kB 4.41 kB +1.10 kB (+33.0%) +68.28 kB
/ui/buffering-indicator 8.07 kB 8.47 kB +410 B (+5.0%) +68.28 kB
/ui/controls 7.81 kB 8.26 kB +466 B (+5.8%) +68.28 kB
/ui/dialog — 4.44 kB new +68.28 kB
/ui/error-dialog 10.92 kB 12.19 kB +1.27 kB (+11.6%) -62 B
/ui/gesture 8.17 kB 8.55 kB +386 B (+4.6%) +68.28 kB
/ui/hotkey 8.65 kB 8.99 kB +349 B (+3.9%) +68.28 kB
/ui/menu 18.21 kB 19.67 kB +1.46 kB (+8.0%) +68.28 kB
/ui/popover 7.81 kB 8.12 kB +322 B (+4.0%) +68.28 kB
/ui/poster 7.69 kB 8.25 kB +576 B (+7.3%) +68.28 kB
/ui/seek-indicator 12.14 kB 12.52 kB +383 B (+3.1%) +68.28 kB
/ui/slider 12.95 kB 13.36 kB +424 B (+3.2%) -62 B
/ui/thumbnail 8.97 kB 9.37 kB +411 B (+4.5%) +68.28 kB
/ui/time-slider 14.53 kB 14.87 kB +345 B (+2.3%) -62 B
/ui/title — 7.94 kB new +68.28 kB
/ui/tooltip 8.54 kB 8.90 kB +376 B (+4.3%) +68.28 kB
/ui/volume-popover — 14.89 kB new +68.28 kB
/ui/volume-slider 12.36 kB 12.79 kB +440 B (+3.5%) -62 B
/video (default) 45.86 kB 48.59 kB +2.73 kB (+6.0%) -62 B
/video (default + hls) 183.05 kB 186.43 kB +3.38 kB (+1.8%) -62 B
/video (minimal) 45.94 kB 48.57 kB +2.64 kB (+5.7%) -62 B
/video (minimal + hls) 183.28 kB 186.41 kB +3.13 kB (+1.7%) -62 B
/audio (default) 35.47 kB 37.88 kB +2.41 kB (+6.8%) -62 B
/audio (minimal) 35.49 kB 37.93 kB +2.44 kB (+6.9%) -62 B
/background 589 B 580 B -9 B (-1.5%) +68.28 kB
Small changes (51, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/media/background-video 394 B 402 B +8 B (+2.0%) —
/media/dash-video 210.24 kB 210.29 kB +47 B (+0.0%) —
/media/google-cast 5.33 kB 5.34 kB +6 B (+0.1%) —
/media/hls-audio 20.16 kB 20.45 kB +290 B (+1.4%) —
/media/moq-publish-video 22.08 kB 22.12 kB +32 B (+0.1%) —
/media/mux-data 25.46 kB 25.49 kB +34 B (+0.1%) —
/media/native-hls-video 5.74 kB 5.76 kB +17 B (+0.3%) —
/media/vimeo-video 11.14 kB 11.21 kB +71 B (+0.6%) —
/media/youtube-video 4.85 kB 4.86 kB +9 B (+0.2%) —
/video/minimal-skin.css 6.18 kB 6.40 kB +230 B (+3.6%) —
/video/skin.css 6.05 kB 6.20 kB +156 B (+2.5%) —
/audio/minimal-skin.css 4.47 kB 4.73 kB +266 B (+5.8%) —
/audio/skin.css 4.40 kB 4.66 kB +269 B (+6.0%) —
/background/skin 273 B 277 B +4 B (+1.5%) —
/live-video/minimal-skin.css 6.18 kB 6.40 kB +230 B (+3.6%) —
/live-video/skin.css 6.05 kB 6.20 kB +156 B (+2.5%) —
/live-audio/minimal-skin.css 4.47 kB 4.73 kB +266 B (+5.8%) —
/live-audio/skin.css 4.40 kB 4.66 kB +269 B (+6.0%) —
/publisher/skin.css 4.64 kB 4.77 kB +131 B (+2.8%) —
/ui/airplay-button 10.88 kB 11.04 kB +170 B (+1.5%) -62 B
/ui/audio-track 8.50 kB 8.65 kB +144 B (+1.7%) -62 B
/ui/audio-track-radio-group 9.65 kB 9.82 kB +169 B (+1.7%) -62 B
/ui/camera-button 11.04 kB 11.17 kB +134 B (+1.2%) -62 B
/ui/camera-radio-group 8.50 kB 8.65 kB +147 B (+1.7%) -62 B
/ui/captions-button 10.87 kB 11.02 kB +151 B (+1.4%) -62 B
/ui/captions-radio-group 9.77 kB 9.92 kB +154 B (+1.5%) -62 B
/ui/capture-placeholder 9.06 kB 9.20 kB +146 B (+1.6%) -62 B
/ui/cast-button 10.87 kB 11.02 kB +145 B (+1.3%) -62 B
/ui/connection-indicator 8.99 kB 9.14 kB +149 B (+1.6%) -62 B
/ui/enable-devices-button 11.11 kB 11.27 kB +160 B (+1.4%) -62 B
/ui/fullscreen-button 10.84 kB 10.98 kB +149 B (+1.3%) -62 B
/ui/live-button 9.28 kB 9.45 kB +166 B (+1.7%) -62 B
/ui/mic-button 11.04 kB 11.18 kB +149 B (+1.3%) -62 B
/ui/mic-radio-group 8.51 kB 8.65 kB +141 B (+1.6%) -62 B
/ui/mute-button 10.83 kB 11.04 kB +212 B (+1.9%) -62 B
/ui/pip-button 10.84 kB 10.98 kB +147 B (+1.3%) -62 B
/ui/play-button 10.81 kB 10.96 kB +152 B (+1.4%) -62 B
/ui/playback-rate 8.56 kB 8.69 kB +140 B (+1.6%) -62 B
/ui/playback-rate-button 10.80 kB 10.96 kB +158 B (+1.4%) -62 B
/ui/playback-rate-radio-group 9.70 kB 9.86 kB +155 B (+1.6%) -62 B
/ui/publish-badge 9.04 kB 9.19 kB +158 B (+1.7%) -62 B
/ui/publish-button 9.54 kB 9.71 kB +178 B (+1.8%) -62 B
/ui/publish-timer 9.61 kB 9.73 kB +122 B (+1.2%) -62 B
/ui/quality 8.99 kB 9.14 kB +149 B (+1.6%) -62 B
/ui/quality-radio-group 10.15 kB 10.30 kB +160 B (+1.5%) -62 B
/ui/screen-share-button 11.04 kB 11.20 kB +160 B (+1.4%) -62 B
/ui/seek-button 10.85 kB 10.99 kB +139 B (+1.3%) -62 B
/ui/status-announcer 10.59 kB 10.77 kB +180 B (+1.7%) -62 B
/ui/status-indicator 12.66 kB 12.80 kB +149 B (+1.1%) -62 B
/ui/time 10.33 kB 10.43 kB +97 B (+0.9%) -62 B
/ui/volume-indicator 12.76 kB 12.92 kB +165 B (+1.3%) -62 B
Presets (7)
Entry Initial Lazy
/video (default) 48.59 kB 68.28 kB
/video (default + hls) 186.43 kB 68.28 kB
/video (minimal) 48.57 kB 68.28 kB
/video (minimal + hls) 186.41 kB 68.28 kB
/audio (default) 37.88 kB 68.28 kB
/audio (minimal) 37.93 kB 68.28 kB
/background 580 B 68.28 kB
Media (24)
Entry Initial
/media/mux-video/hls-js 140.62 kB
/media/mux-video/spf 27.52 kB
/media/mux-audio/hls-js 140.46 kB
/media/mux-audio/spf 21.41 kB
/media/background-video 402 B
/media/cloudflare-video 4.35 kB
/media/dash-video 210.29 kB
/media/google-cast 5.34 kB
/media/hls-audio 20.45 kB
/media/hls-background-video 16.44 kB
/media/hls-video 26.49 kB
/media/hlsjs-video 139.58 kB
/media/moq-publish-video 22.12 kB
/media/mux-audio 140.44 kB
/media/mux-background-video 16.43 kB
/media/mux-data 25.49 kB
/media/mux-video 140.62 kB
/media/native-hls-video 5.76 kB
/media/shaka-video 197.52 kB
/media/spotify-audio 4.22 kB
/media/tiktok-video 4.18 kB
/media/twitch-video 4.30 kB
/media/vimeo-video 11.21 kB
/media/youtube-video 4.86 kB
Players (5)
Entry Initial Lazy
/video/player 7.51 kB 68.28 kB
/audio/player 3.95 kB 68.28 kB
/background/player 2.27 kB 68.28 kB
/live-video/player 6.91 kB 68.28 kB
/live-audio/player 3.96 kB 68.28 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 6.40 kB —
/video/skin.css css 6.20 kB —
/video/minimal-skin js 48.48 kB 68.28 kB
/video/minimal-skin.tailwind js 55.46 kB 68.28 kB
/video/skin js 48.49 kB 68.28 kB
/video/skin.tailwind js 55.30 kB 68.28 kB
/audio/minimal-skin.css css 4.73 kB —
/audio/skin.css css 4.66 kB —
/audio/minimal-skin js 37.81 kB 68.28 kB
/audio/minimal-skin.tailwind js 42.93 kB 68.28 kB
/audio/skin js 37.79 kB 68.28 kB
/audio/skin.tailwind js 42.92 kB 68.28 kB
/background/skin.css css 90 B —
/background/skin js 277 B —
/live-video/minimal-skin.css css 6.40 kB —
/live-video/skin.css css 6.20 kB —
/live-video/minimal-skin js 40.62 kB 68.28 kB
/live-video/minimal-skin.tailwind js 47.27 kB 68.28 kB
/live-video/skin js 40.64 kB 68.28 kB
/live-video/skin.tailwind js 47.18 kB 68.28 kB
/live-audio/minimal-skin.css css 4.73 kB —
/live-audio/skin.css css 4.66 kB —
/live-audio/minimal-skin js 29.66 kB 68.28 kB
/live-audio/minimal-skin.tailwind js 33.58 kB 68.28 kB
/live-audio/skin js 29.69 kB 68.28 kB
/live-audio/skin.tailwind js 33.71 kB 68.28 kB
/publisher/skin.css css 4.77 kB —
/publisher/skin js 30.93 kB 68.28 kB
/publisher/skin.tailwind js 35.69 kB 68.28 kB
UI Components (50)
Entry Initial Lazy
/ui/airplay-button 11.04 kB 68.28 kB
/ui/alert-dialog 4.41 kB 68.28 kB
/ui/audio-track 8.65 kB 68.28 kB
/ui/audio-track-radio-group 9.82 kB 68.28 kB
/ui/buffering-indicator 8.47 kB 68.28 kB
/ui/camera-button 11.17 kB 68.28 kB
/ui/camera-radio-group 8.65 kB 68.28 kB
/ui/captions-button 11.02 kB 68.28 kB
/ui/captions-radio-group 9.92 kB 68.28 kB
/ui/capture-placeholder 9.20 kB 68.28 kB
/ui/cast-button 11.02 kB 68.28 kB
/ui/connection-indicator 9.14 kB 68.28 kB
/ui/controls 8.26 kB 68.28 kB
/ui/dialog 4.44 kB 68.28 kB
/ui/enable-devices-button 11.27 kB 68.28 kB
/ui/error-dialog 12.19 kB 68.28 kB
/ui/fullscreen-button 10.98 kB 68.28 kB
/ui/gesture 8.55 kB 68.28 kB
/ui/hotkey 8.99 kB 68.28 kB
/ui/live-button 9.45 kB 68.28 kB
/ui/menu 19.67 kB 68.28 kB
/ui/mic-button 11.18 kB 68.28 kB
/ui/mic-radio-group 8.65 kB 68.28 kB
/ui/mute-button 11.04 kB 68.28 kB
/ui/pip-button 10.98 kB 68.28 kB
/ui/play-button 10.96 kB 68.28 kB
/ui/playback-rate 8.69 kB 68.28 kB
/ui/playback-rate-button 10.96 kB 68.28 kB
/ui/playback-rate-radio-group 9.86 kB 68.28 kB
/ui/popover 8.12 kB 68.28 kB
/ui/poster 8.25 kB 68.28 kB
/ui/publish-badge 9.19 kB 68.28 kB
/ui/publish-button 9.71 kB 68.28 kB
/ui/publish-timer 9.73 kB 68.28 kB
/ui/quality 9.14 kB 68.28 kB
/ui/quality-radio-group 10.30 kB 68.28 kB
/ui/screen-share-button 11.20 kB 68.28 kB
/ui/seek-button 10.99 kB 68.28 kB
/ui/seek-indicator 12.52 kB 68.28 kB
/ui/slider 13.36 kB 68.28 kB
/ui/status-announcer 10.77 kB 68.28 kB
/ui/status-indicator 12.80 kB 68.28 kB
/ui/thumbnail 9.37 kB 68.28 kB
/ui/time 10.43 kB 68.28 kB
/ui/time-slider 14.87 kB 68.28 kB
/ui/title 7.94 kB 68.28 kB
/ui/tooltip 8.90 kB 68.28 kB
/ui/volume-indicator 12.92 kB 68.28 kB
/ui/volume-popover 14.89 kB 68.28 kB
/ui/volume-slider 12.79 kB 68.28 kB

🧩 @videojs/core

Path Base initial PR initial Initial diff Lazy diff
. 14.09 kB 14.39 kB +309 B (+2.1%) —
/dom 20.94 kB 22.82 kB +1.88 kB (+9.0%) +68.28 kB
/vjsc — 1.74 kB new —
/components 927 B — removed —
Small changes (3, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/i18n 3.41 kB 3.43 kB +15 B (+0.4%) -62 B
/i18n/locales/all 35.47 kB 35.40 kB -73 B (-0.2%) —
/i18n/locales/bn 1.52 kB 1.46 kB -62 B (-4.0%) —
Entries (77)
Entry Initial Lazy
. 14.39 kB —
/dom 22.82 kB 68.28 kB
/vjsc 1.74 kB —
/i18n 3.43 kB 68.28 kB
/i18n/locales/all 35.40 kB —
/i18n/locales/ar 1.45 kB —
/i18n/locales/az 1.31 kB —
/i18n/locales/bg 1.53 kB —
/i18n/locales/bn 1.46 kB —
/i18n/locales/bs 1.23 kB —
/i18n/locales/ca 1.29 kB —
/i18n/locales/cs 1.29 kB —
/i18n/locales/cy 1.24 kB —
/i18n/locales/da 1.20 kB —
/i18n/locales/de 1.31 kB —
/i18n/locales/el 1.74 kB —
/i18n/locales/en 993 B —
/i18n/locales/es 1.21 kB —
/i18n/locales/et 1.27 kB —
/i18n/locales/eu 1.24 kB —
/i18n/locales/fa 1.45 kB —
/i18n/locales/fi 1.26 kB —
/i18n/locales/fr 1.29 kB —
/i18n/locales/gd 1.32 kB —
/i18n/locales/gl 1.21 kB —
/i18n/locales/he 1.37 kB —
/i18n/locales/hi 1.54 kB —
/i18n/locales/hr 1.25 kB —
/i18n/locales/hu 1.31 kB —
/i18n/locales/id 1.11 kB —
/i18n/locales/it 1.22 kB —
/i18n/locales/ja 1.41 kB —
/i18n/locales/ko 1.36 kB —
/i18n/locales/lt 1.24 kB —
/i18n/locales/lv 1.30 kB —
/i18n/locales/mr 1.54 kB —
/i18n/locales/nb 1.18 kB —
/i18n/locales/ne 1.52 kB —
/i18n/locales/nl 1.22 kB —
/i18n/locales/nn 1.18 kB —
/i18n/locales/oc 1.29 kB —
/i18n/locales/pl 1.36 kB —
/i18n/locales/pt 1.25 kB —
/i18n/locales/pt-BR 1.25 kB —
/i18n/locales/pt-PT 1.23 kB —
/i18n/locales/ro 1.28 kB —
/i18n/locales/ru 1.63 kB —
/i18n/locales/sk 1.32 kB —
/i18n/locales/sl 1.26 kB —
/i18n/locales/sr 1.29 kB —
/i18n/locales/sv 1.22 kB —
/i18n/locales/te 1.55 kB —
/i18n/locales/th 1.53 kB —
/i18n/locales/tr 1.30 kB —
/i18n/locales/uk 1.64 kB —
/i18n/locales/vi 1.32 kB —
/i18n/locales/zh 1.23 kB —
/i18n/locales/zh-CN 1.23 kB —
/i18n/locales/zh-TW 1.24 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/publish 451 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 280 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
. 996 B 1.05 kB +80 B (+8.0%) —
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 365 B

🔧 @videojs/utils

Path Base initial PR initial Initial diff Lazy diff
/dom 4.49 kB 5.02 kB +545 B (+11.9%) —
Small changes (4, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
/function 369 B 386 B +17 B (+4.6%) —
/i18n 44 B 249 B +205 B (+465.9%) —
/style 188 B 212 B +24 B (+12.8%) —
/time 1.01 kB 976 B -63 B (-6.1%) —
Entries (13)
Entry Initial
/array 271 B
/dom 5.02 kB
/events 320 B
/function 386 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 976 B
/number 199 B

📦 @videojs/media

Path Base initial PR initial Initial diff Lazy diff
/dom/dash 209.84 kB 3.28 kB -206.56 kB (-98.4%) —
/dom/cloudflare — 3.69 kB new —
/dom/hls-js 138.53 kB 139.17 kB +654 B (+0.5%) —
/dom/mux 161.78 kB 162.77 kB +1010 B (+0.6%) —
/dom/shaka — 197.02 kB new —
/dom/spotify — 3.58 kB new —
/dom/tiktok — 3.57 kB new —
/dom/twitch — 3.62 kB new —
Small changes (8, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
. 1.15 kB 1.18 kB +35 B (+3.0%) —
/dom/audio-host 1.10 kB 1.10 kB +1 B (+0.1%) —
/dom/custom-media-element 2.09 kB 2.09 kB +4 B (+0.2%) —
/dom/dash 209.84 kB 209.83 kB -18 B (-0.0%) —
/dom/google-cast 4.06 kB 4.06 kB -1 B (-0.0%) —
/dom/native-hls 5.26 kB 5.25 kB -5 B (-0.1%) —
/dom/vimeo 10.54 kB 10.62 kB +85 B (+0.8%) —
/dom/youtube 4.23 kB 4.25 kB +19 B (+0.4%) —
Entries (21)
Entry Initial
. 1.18 kB
/dom 121 B
/dom/dash 3.28 kB
/dom/audio-host 1.10 kB
/dom/cloudflare 3.69 kB
/dom/custom-media-element 2.09 kB
/dom/dash 209.83 kB
/dom/google-cast 4.06 kB
/dom/hls-js 139.17 kB
/dom/media-host 1.20 kB
/dom/media-played-ranges 576 B
/dom/mux 162.77 kB
/dom/native-hls 5.25 kB
/dom/shaka 197.02 kB
/dom/spotify 3.58 kB
/dom/tiktok 3.57 kB
/dom/twitch 3.62 kB
/dom/video-host 1.39 kB
/dom/vimeo 10.62 kB
/dom/youtube 4.25 kB
/media-tracks 2.05 kB

📦 @videojs/spf

Path Base initial PR initial Initial diff Lazy diff
/hls 21.06 kB 22.22 kB +1.16 kB (+5.5%) —
/moq 26.59 kB 26.99 kB +408 B (+1.5%) —
/hls-background-video 14.76 kB 15.91 kB +1.15 kB (+7.8%) —
/hls-video 25.23 kB 26.05 kB +832 B (+3.2%) —
/mux-audio 20.49 kB 20.89 kB +409 B (+1.9%) —
/mux-background-video 14.76 kB 15.86 kB +1.11 kB (+7.5%) —
/mux-video 26.12 kB 26.93 kB +830 B (+3.1%) —
Small changes (6, ≤ 300 B)
Path Base initial PR initial Initial diff Lazy diff
. 4.53 kB 4.55 kB +20 B (+0.4%) —
/dom 6.58 kB 6.61 kB +25 B (+0.4%) —
/media-tracks 604 B 605 B +1 B (+0.2%) —
/moq-publish 20.35 kB 20.38 kB +22 B (+0.1%) —
/moq-publish-video 21.58 kB 21.58 kB +2 B (+0.0%) —
/hls-audio 19.67 kB 19.96 kB +296 B (+1.5%) —
Entries (13)
Entry Initial
. 4.55 kB
/dom 6.61 kB
/hls 22.22 kB
/media-tracks 605 B
/moq 26.99 kB
/moq-publish 20.38 kB
/moq-publish-video 21.58 kB
/hls-background-video 15.91 kB
/hls-audio 19.96 kB
/hls-video 26.05 kB
/mux-audio 20.89 kB
/mux-background-video 15.86 kB
/mux-video 26.93 kB

📦 @videojs/jsx

Path Base initial PR initial Initial diff Lazy diff
. 393 B — removed —
/jsx-runtime 371 B — removed —
/jsx-dev-runtime 375 B — removed —

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd5b316447

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -105,7 +106,7 @@ export const controls = cn(
'peer-data-open/error:hidden!',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Hide controls through a selector that can match

When the publisher error dialog opens, this variant never hides the controls: neither publisher template creates a peer/error, and in the HTML template the dialog is a sibling of <media-controls> while this class is applied to the nested <media-controls-content>. Consequently peer-data-open/error:hidden! cannot match in either the HTML or React Tailwind skin, leaving the control bar visible beneath every publish-error dialog; use a container/:has() condition or otherwise propagate the dialog state to the controls.

Useful? React with 👍 / 👎.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

27 issues found across 3000 files

Not reviewed (too large): site/scripts/api-docs-builder/src/media-element-handler.ts (~2,408 lines) - if these are generated or fixture files, add them to ignored paths to exclude them from future reviews.

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="apps/sandbox/templates/react-shaka-video/main.tsx">

<violation number="1" location="apps/sandbox/templates/react-shaka-video/main.tsx:33">
P2: For Mux-backed Shaka sources, this template omits the poster and storyboard track, so the React Shaka sandbox loses its poster and seek-preview thumbnails. Add the shared poster/storyboard hooks and pass/render their values as the other React video templates do.</violation>
</file>

<file name=".github/workflows/issue-to-pr.yml">

<violation number="1" location=".github/workflows/issue-to-pr.yml:39">
P1: When a maintainer labels an issue containing prompt-injection content, the network-enabled Codex process can exfiltrate its write-scoped `GH_TOKEN`. Do not expose write credentials to the coding agent; perform GitHub writes in a separate trusted step or use an isolated, tightly scoped token and restricted network.</violation>
</file>

<file name="apps/sandbox/templates/html-spotify-audio/main.ts">

<violation number="1" location="apps/sandbox/templates/html-spotify-audio/main.ts:14">
P2: When the user changes Language in the sandbox, this iframe keeps the initial locale because the template never initializes, wraps, or subscribes to HTML i18n. Add the standard HTML i18n setup and `bindSandboxHtmlLocaleChange(render)` used by `html-audio`.</violation>
</file>

<file name="apps/sandbox/templates/html-hlsjs-video/main.ts">

<violation number="1" location="apps/sandbox/templates/html-hlsjs-video/main.ts:43">
P3: When `source=none` is combined with any playback override, this creates a non-null `{ src: '' }` source and initializes hls.js for an empty URL. Only synthesize an initial source when `url` is non-empty.</violation>
</file>

<file name="apps/sandbox/templates/html-shaka-video/main.ts">

<violation number="1" location="apps/sandbox/templates/html-shaka-video/main.ts:26">
P2: When `hls-live` is selected, this keeps the standard VOD skin and player. Compute `live` and pass it to `loadVideoSkinTag` and the player wrapper, as the other HTML HLS templates do.</violation>

<violation number="2" location="apps/sandbox/templates/html-shaka-video/main.ts:39">
P2: When `hls-7` is selected, the sandbox never mounts its chapter track, so the skin cannot show chapter markers or titles. Import and render `getChapters`/`renderChapters` before the storyboard, matching the other HTML video templates.</violation>
</file>

<file name="apps/sandbox/templates/html-hls-background-video/main.ts">

<violation number="1" location="apps/sandbox/templates/html-hls-background-video/main.ts:25">
P2: When this template is opened directly without the shell-generated `source` query parameter, `getInitialSource()` selects `hls-1`, an MPEG-TS stream that SPF cannot play, so the demo starts in a permanent error state. Use the playable `hls-4k` background source as the no-query default while preserving an explicitly selected source.</violation>
</file>

<file name="apps/sandbox/templates/html-mux-background-video/main.ts">

<violation number="1" location="apps/sandbox/templates/html-mux-background-video/main.ts:24">
P2: When this template is opened directly without a `source` query parameter, `getInitialSource()` selects `hls-1`, an MPEG-TS stream that the background SPF engine cannot play. Initialize the standalone page with `DEFAULT_BACKGROUND_SOURCE` when no explicit source is provided, while preserving an explicit `source` query.</violation>
</file>

<file name="packages/cli/vite.config.ts">

<violation number="1" location="packages/cli/vite.config.ts:53">
P2: CLI tests resolve CDN metadata from a seven-entry fixture, while production builds generate metadata for every non-excluded CDN media bundle. Update the fixture to match the generated manifest, otherwise CDN availability and URL-generation tests cannot cover the production data.</violation>
</file>

<file name=".agents/skills/write-docs/SKILL.md">

<violation number="1" location=".agents/skills/write-docs/SKILL.md:16">
P3: The new 'reference page' artifact category has no matching scaffold: write-docs/templates/ only ships concept.md, how-to.md, and readme.md, while Workflow step 3 directs 'New artifact scaffold: the matching file in templates/'. Add a reference.md template (or note that none exists) so the skill's guidance and its templates stay aligned.</violation>
</file>

<file name=".github/workflows/issue-triage.yml">

<violation number="1" location=".github/workflows/issue-triage.yml:26">
P2: When an external contributor opens or reopens an issue, `openai/codex-action@v1` fails its write-access check before running Codex because `allow-users` is empty. Allow the intended external users, or set `allow-users: '*'` for this public issue-triage workflow.</violation>
</file>

<file name=".github/workflows/forward-port-changelog.yml">

<violation number="1" location=".github/workflows/forward-port-changelog.yml:67">
P1: When an older changelog-prose PR merges while a newer release is still publishing, this job copies the newer raw changelog to `site/v10` before its packages reach npm. Synchronize this job with the release deployment or exclude release versions until publication completes.</violation>
</file>

<file name="apps/sandbox/vercel.json">

<violation number="1" location="apps/sandbox/vercel.json:3">
P2: Vercel's monorepo deployment needs a `root` field to point at `apps/sandbox`. Without it, Vercel treats the repository root as the project directory, so the default output directory `dist` is resolved to `<repo>/dist` instead of `apps/sandbox/dist` that the Vite build (outDir: `resolve(__dirname, 'dist')`) produces, and the deploy serves nothing. Add `"root": "apps/sandbox"` (the `pnpm --workspace-root build:sandbox` command still works from there).</violation>
</file>

<file name="apps/sandbox/templates/html-audio/main.ts">

<violation number="1" location="apps/sandbox/templates/html-audio/main.ts:33">
P2: When the audio sandbox selects `hls-mixed-codec`, this `crossorigin` attribute enables anonymous CORS and the Apple playlist fails without `Access-Control-Allow-Origin`. Remove the attribute for this plain audio element or add it only for CORS-enabled sources.</violation>
</file>

<file name="apps/sandbox/app/shared/sandbox-listener.ts">

<violation number="1" location="apps/sandbox/app/shared/sandbox-listener.ts:44">
P3: When a resolution query contains an excessively long digit string, `Number.parseInt` returns `Infinity` and this check accepts it. `resolutionToPixelArea` then treats it as unbounded, disabling the requested cap or floor; reject non-finite parsed heights.</violation>
</file>

<file name="internal/decisions/player/provider-attach.md">

<violation number="1" location="internal/decisions/player/provider-attach.md:12">
P3: Attach doesn't require both media and container. In `#tryAttach()`, only `#media` is mandatory — when media is present the store attaches even with a null container (confirmed by the `store.attach({ media, container: null })` core tests). Saying "when both are available" misstates the invariant; the prior wording ("when it has a media element") was accurate. Reword to reflect that media is required and container is optional.</violation>
</file>

<file name=".github/workflows/issue-sync.yml">

<violation number="1" location=".github/workflows/issue-sync.yml:39">
P2: When a merged PR contains prompt-injection text, Codex can run network-enabled commands with the issue-writing `GH_TOKEN`, allowing token exfiltration or unauthorized issue changes. Do not expose this token to the model; route approved issue mutations through a narrow wrapper, or isolate the agent from outbound network access.</violation>
</file>

<file name=".github/workflows/e2e-failure-triage.yml">

<violation number="1" location=".github/workflows/e2e-failure-triage.yml:39">
P1: Because this agent feeds attacker-controlled PR evidence to Codex, enabling unrestricted network access while exporting the write-scoped `GH_TOKEN` lets prompt-injected commands exfiltrate the token or mutate GitHub. Keep the agent off the open network and route only narrowly scoped GitHub operations through a separate, least-privileged step or token.</violation>
</file>

<file name=".github/workflows/api-reference-sync.yml">

<violation number="1" location=".github/workflows/api-reference-sync.yml:281">
P3: The stale-docs job is documented as GPT-5.6 Sol but runs GPT-5.6 Terra, so its configured model does not match the stated rollout. Use `gpt-5.6-sol` here or update the job description to the intended model.</violation>

<violation number="2" location=".github/workflows/api-reference-sync.yml:285">
P2: Because Codex reads PR-derived artifacts and has `GH_TOKEN` plus network access, prompt-injected content can exfiltrate the token or perform unintended issue operations. Keep the agent network-isolated and create the issue in a trusted workflow step from Codex's output instead.</violation>
</file>

<file name="packages/cli/package.json">

<violation number="1" location="packages/cli/package.json:22">
P2: Removing the `build` script (which ran `copy-docs`) orphaned cli's `copy-docs` script: nothing calls it now. html and react migrated the same copy-docs step into a `prepack` script; cli did not, so the CLI package docs are no longer generated into the `docs` dir that `files` publishes. Wire `copy-docs` into `prepack` like the sibling packages.</violation>
</file>

<file name="internal/design/spf/use-cases/audio-only-mode-override.md">

<violation number="1" location="internal/design/spf/use-cases/audio-only-mode-override.md:315">
P3: The File column points to `media/hls-audio/element.ts`, which does not exist in the repo. `HlsAudioElement` is defined in `define/media/hls-audio.ts` (extending the `HlsAudio` class in `media/hls-audio/media.ts`); the prior `define/media/hls-audio.ts` reference was correct. Point the row at the real file so the doc link resolves.</violation>
</file>

<file name=".agents/skills/write-api-reference/references/demo-patterns.md">

<violation number="1" location=".agents/skills/write-api-reference/references/demo-patterns.md:108">
P3: The example registers <media-container> via the new import but the .html markup never uses it, so a reader following the doc gets no effect from the import. Add a <media-container> wrapper around <video> and <media-mute-button> in the .html example (mirroring the real demos, e.g. mute-button/html/css/BasicUsage.html) so the import matches the markup.</violation>
</file>

<file name="apps/sandbox/package.json">

<violation number="1" location="apps/sandbox/package.json:43">
P2: The stackblitz startCommand runs `pnpm dev`, but this diff deletes the sandbox's `dev` script. Because the same command installs with `--ignore-scripts`, `prepare`/`vp config` never runs, so no script is regenerated and `pnpm dev` fails with "Missing script: dev", breaking the published StackBlitz sandbox. Restore a `dev` script (e.g. `"dev": "vp dev --host"`, which triggers the `setup` task in vite.config.ts and recreates `src/`), or point the startCommand at `vp dev --host` directly. This also keeps the README's statement that "the `dev` script runs `setup.ts` first" accurate.</violation>
</file>

<file name=".zed/settings.json">

<violation number="1" location=".zed/settings.json:16">
P2: The oxlint LSP here runs without the repo's lint config: the rule set, the anti-slop custom plugin, and the per-path overrides all live in vite.config.ts and are only applied by `vp lint`. Without a configPath to that config, editor diagnostics use default oxlint rules and won't match CI (`pnpm lint`), so warnings/errors shown in Zed may not reflect what CI enforces (and vice versa). Wire the oxlint server to the same config used by `vp lint` so editor and CI lint agree.</violation>

<violation number="2" location=".zed/settings.json:23">
P2: The repo's formatting settings (singleQuote, semi, printWidth 120, custom overrides) are defined inside vite.config.ts as a vite-plus defineConfig and applied by `vp fmt`. The standalone oxfmt LSP reading `fmt.configPath: "./vite.config.ts"` can't consume that vite-plus config, so format-on-save falls back to oxfmt defaults (double quotes / no semicolons), which conflict with the repo settings. Editor-saved files would then be rewritten by CI `vp fmt`, causing churn. Confirm the oxfmt LSP actually resolves the repo's settings from that path, and if not, point it at a real oxfmt config or the generated config that mirrors vite.config.ts.</violation>
</file>

<file name=".github/workflows/ci.yml">

<violation number="1" location=".github/workflows/ci.yml:224">
P2: The Vite task cache save uses a primary key that embeds github.run_id/run_attempt, so every CI run stores a new cache entry instead of reusing one. Over a long-lived PR or busy main that means re-uploading the full node_modules/.vite/task-cache each run and accumulating entries, which churns GitHub's 10GB/5k-entry cache budget and can evict the setup-node and pnpm caches alongside it. Keep the restore-keys prefix match but make the save key durable across runs (e.g. key on github.ref and/or a date bucket instead of run_id) so subsequent runs restore and overwrite the same entry rather than minting a new one each time.</violation>
</file>

Note: This PR contains a large number of files. cubic selects up to 200 of the highest-priority eligible files for this review, so some files may not have been reviewed.

Re-trigger cubic

effort: high
sandbox: workspace-write
safety-strategy: drop-sudo
codex-args: '["--config", "sandbox_workspace_write.network_access=true"]'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: When a maintainer labels an issue containing prompt-injection content, the network-enabled Codex process can exfiltrate its write-scoped GH_TOKEN. Do not expose write credentials to the coding agent; perform GitHub writes in a separate trusted step or use an isolated, tightly scoped token and restricted network.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/issue-to-pr.yml, line 39:

<comment>When a maintainer labels an issue containing prompt-injection content, the network-enabled Codex process can exfiltrate its write-scoped `GH_TOKEN`. Do not expose write credentials to the coding agent; perform GitHub writes in a separate trusted step or use an isolated, tightly scoped token and restricted network.</comment>

<file context>
@@ -19,24 +18,25 @@ jobs:
+          effort: high
+          sandbox: workspace-write
+          safety-strategy: drop-sudo
+          codex-args: '["--config", "sandbox_workspace_write.network_access=true"]'
           prompt: |
             You are the issue-to-PR implementation agent for this repository.
</file context>

# merges. So there is nothing here to reconcile, and no unreleased
# changelog to leak into production.
rm -rf site/src/content/changelog
git checkout origin/main -- site/src/content/changelog

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: When an older changelog-prose PR merges while a newer release is still publishing, this job copies the newer raw changelog to site/v10 before its packages reach npm. Synchronize this job with the release deployment or exclude release versions until publication completes.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/forward-port-changelog.yml, line 67:

<comment>When an older changelog-prose PR merges while a newer release is still publishing, this job copies the newer raw changelog to `site/v10` before its packages reach npm. Synchronize this job with the release deployment or exclude release versions until publication completes.</comment>

<file context>
@@ -0,0 +1,83 @@
+            # merges. So there is nothing here to reconcile, and no unreleased
+            # changelog to leak into production.
+            rm -rf site/src/content/changelog
+            git checkout origin/main -- site/src/content/changelog
+            git add -A site/src/content/changelog
+
</file context>

effort: medium
sandbox: workspace-write
safety-strategy: drop-sudo
codex-args: '["--config", "sandbox_workspace_write.network_access=true"]'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Because this agent feeds attacker-controlled PR evidence to Codex, enabling unrestricted network access while exporting the write-scoped GH_TOKEN lets prompt-injected commands exfiltrate the token or mutate GitHub. Keep the agent off the open network and route only narrowly scoped GitHub operations through a separate, least-privileged step or token.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/e2e-failure-triage.yml, line 39:

<comment>Because this agent feeds attacker-controlled PR evidence to Codex, enabling unrestricted network access while exporting the write-scoped `GH_TOKEN` lets prompt-injected commands exfiltrate the token or mutate GitHub. Keep the agent off the open network and route only narrowly scoped GitHub operations through a separate, least-privileged step or token.</comment>

<file context>
@@ -25,17 +26,17 @@ jobs:
+          effort: medium
+          sandbox: workspace-write
+          safety-strategy: drop-sudo
+          codex-args: '["--config", "sandbox_workspace_write.network_access=true"]'
           prompt: |
             You are diagnosing a failed Video.js E2E workflow for a pull request.
</file context>

return (
<SandboxI18nProvider>
<VideoPlayer>
<VideoSkinComponent skin={skin} styling={styling} className="mx-auto aspect-video max-w-4xl">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: For Mux-backed Shaka sources, this template omits the poster and storyboard track, so the React Shaka sandbox loses its poster and seek-preview thumbnails. Add the shared poster/storyboard hooks and pass/render their values as the other React video templates do.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/sandbox/templates/react-shaka-video/main.tsx, line 33:

<comment>For Mux-backed Shaka sources, this template omits the poster and storyboard track, so the React Shaka sandbox loses its poster and seek-preview thumbnails. Add the shared poster/storyboard hooks and pass/render their values as the other React video templates do.</comment>

<file context>
@@ -0,0 +1,51 @@
+  return (
+    <SandboxI18nProvider>
+      <VideoPlayer>
+        <VideoSkinComponent skin={skin} styling={styling} className="mx-auto aspect-video max-w-4xl">
+          {/* Shaka plays DASH and HLS from the same element, so the source list here is not
+              narrowed to one manifest format the way the dash.js sandbox is. */}
</file context>

const state = createHtmlSandboxState();
const loadLatest = createLatestLoader();

async function render() {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When the user changes Language in the sandbox, this iframe keeps the initial locale because the template never initializes, wraps, or subscribes to HTML i18n. Add the standard HTML i18n setup and bindSandboxHtmlLocaleChange(render) used by html-audio.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/sandbox/templates/html-spotify-audio/main.ts, line 14:

<comment>When the user changes Language in the sandbox, this iframe keeps the initial locale because the template never initializes, wraps, or subscribes to HTML i18n. Add the standard HTML i18n setup and `bindSandboxHtmlLocaleChange(render)` used by `html-audio`.</comment>

<file context>
@@ -0,0 +1,35 @@
+const state = createHtmlSandboxState();
+const loadLatest = createLatestLoader();
+
+async function render() {
+  const tag = await loadLatest(() => loadAudioSkinTag(state.skin, state.styling));
+  if (!tag) return;
</file context>


function readResolution(name: string): MediaResolution | undefined {
const value = params.get(name);
if (!value || !RESOLUTION_PATTERN.test(value) || Number.parseInt(value, 10) <= 0) return undefined;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: When a resolution query contains an excessively long digit string, Number.parseInt returns Infinity and this check accepts it. resolutionToPixelArea then treats it as unbounded, disabling the requested cap or floor; reject non-finite parsed heights.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/sandbox/app/shared/sandbox-listener.ts, line 44:

<comment>When a resolution query contains an excessively long digit string, `Number.parseInt` returns `Infinity` and this check accepts it. `resolutionToPixelArea` then treats it as unbounded, disabling the requested cap or floor; reject non-finite parsed heights.</comment>

<file context>
@@ -27,9 +35,31 @@ function readBoolean(name: string): boolean {
 
+function readResolution(name: string): MediaResolution | undefined {
+  const value = params.get(name);
+  if (!value || !RESOLUTION_PATTERN.test(value) || Number.parseInt(value, 10) <= 0) return undefined;
+
+  return value as MediaResolution;
</file context>
Suggested change
if (!value || !RESOLUTION_PATTERN.test(value) || Number.parseInt(value, 10) <= 0) return undefined;
if (!value || !RESOLUTION_PATTERN.test(value) || !Number.isFinite(Number.parseInt(value, 10)) || Number.parseInt(value, 10) <= 0) return undefined;

@@ -9,7 +9,7 @@ date: 2026-03-13

The provider (`<video-player>` / React `Provider`) owns the `store.attach()` lifecycle. The container (`<media-container>` / React `Container`) no longer discovers media or calls `store.attach()` — it registers itself with the provider via context and serves only as a layout reference element.

Media and container elements register themselves with the provider through attach contexts — setter callbacks that flow downward from provider to descendants. The provider calls `store.attach({ media, container })` when it has a media element. As a fallback for plain `<video>`/`<audio>` elements that can't consume context, the provider queries its subtree.
Media and container elements register themselves with the provider through attach contexts. Each registration returns an identity-specific release callback, so an older element cannot clear a newer registration when it disconnects. The provider calls `store.attach({ media, container })` when both are available. Plain `<video>` and `<audio>` descendants are tracked with a `MutationObserver` because they cannot consume context.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Attach doesn't require both media and container. In #tryAttach(), only #media is mandatory — when media is present the store attaches even with a null container (confirmed by the store.attach({ media, container: null }) core tests). Saying "when both are available" misstates the invariant; the prior wording ("when it has a media element") was accurate. Reword to reflect that media is required and container is optional.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At internal/decisions/player/provider-attach.md, line 12:

<comment>Attach doesn't require both media and container. In `#tryAttach()`, only `#media` is mandatory — when media is present the store attaches even with a null container (confirmed by the `store.attach({ media, container: null })` core tests). Saying "when both are available" misstates the invariant; the prior wording ("when it has a media element") was accurate. Reword to reflect that media is required and container is optional.</comment>

<file context>
@@ -9,7 +9,7 @@ date: 2026-03-13
 The provider (`<video-player>` / React `Provider`) owns the `store.attach()` lifecycle. The container (`<media-container>` / React `Container`) no longer discovers media or calls `store.attach()` — it registers itself with the provider via context and serves only as a layout reference element.
 
-Media and container elements register themselves with the provider through attach contexts — setter callbacks that flow downward from provider to descendants. The provider calls `store.attach({ media, container })` when it has a media element. As a fallback for plain `<video>`/`<audio>` elements that can't consume context, the provider queries its subtree.
+Media and container elements register themselves with the provider through attach contexts. Each registration returns an identity-specific release callback, so an older element cannot clear a newer registration when it disconnects. The provider calls `store.attach({ media, container })` when both are available. Plain `<video>` and `<audio>` descendants are tracked with a `MutationObserver` because they cannot consume context.
 
 ## Context
</file context>

--max-turns 25
--allowedTools "Read" "Glob" "Grep" "Bash(gh:*)" "Bash(cat:*)" "Bash(jq:*)" "Bash(diff:*)" "Bash(ls:*)" "Bash(head:*)" "Bash(tail:*)" "Bash(wc:*)" "Bash(sort:*)"
openai-api-key: ${{ secrets.OPENAI_API_KEY }}
model: gpt-5.6-terra

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The stale-docs job is documented as GPT-5.6 Sol but runs GPT-5.6 Terra, so its configured model does not match the stated rollout. Use gpt-5.6-sol here or update the job description to the intended model.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .github/workflows/api-reference-sync.yml, line 281:

<comment>The stale-docs job is documented as GPT-5.6 Sol but runs GPT-5.6 Terra, so its configured model does not match the stated rollout. Use `gpt-5.6-sol` here or update the job description to the intended model.</comment>

<file context>
@@ -269,18 +273,24 @@ jobs:
-            --max-turns 25
-            --allowedTools "Read" "Glob" "Grep" "Bash(gh:*)" "Bash(cat:*)" "Bash(jq:*)" "Bash(diff:*)" "Bash(ls:*)" "Bash(head:*)" "Bash(tail:*)" "Bash(wc:*)" "Bash(sort:*)"
+          openai-api-key: ${{ secrets.OPENAI_API_KEY }}
+          model: gpt-5.6-terra
+          effort: high
+          sandbox: workspace-write
</file context>
Suggested change
model: gpt-5.6-terra
model: gpt-5.6-sol

@@ -312,7 +312,7 @@ Public re-export: `@videojs/spf/hls-audio`.
| Export | File | Purpose |
|---|---|---|
| `HlsAudio` | `media/hls-audio/media.ts` | Applies `MediaAttachMixin` + `CustomMediaElement('audio', HlsAudioMedia)` |
| `HlsAudioElement` (tag `hls-audio`) | `define/media/hls-audio.ts` | Custom-element definition; registers `<hls-audio>` via `safeDefine` |
| `HlsAudioElement` (tag `hls-audio`) | `media/hls-audio/element.ts` | Custom-element implementation; `define/media/hls-audio.ts` registers it via `safeDefine` |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The File column points to media/hls-audio/element.ts, which does not exist in the repo. HlsAudioElement is defined in define/media/hls-audio.ts (extending the HlsAudio class in media/hls-audio/media.ts); the prior define/media/hls-audio.ts reference was correct. Point the row at the real file so the doc link resolves.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At internal/design/spf/use-cases/audio-only-mode-override.md, line 315:

<comment>The File column points to `media/hls-audio/element.ts`, which does not exist in the repo. `HlsAudioElement` is defined in `define/media/hls-audio.ts` (extending the `HlsAudio` class in `media/hls-audio/media.ts`); the prior `define/media/hls-audio.ts` reference was correct. Point the row at the real file so the doc link resolves.</comment>

<file context>
@@ -312,7 +312,7 @@ Public re-export: `@videojs/spf/hls-audio`.
 |---|---|---|
 | `HlsAudio` | `media/hls-audio/media.ts` | Applies `MediaAttachMixin` + `CustomMediaElement('audio', HlsAudioMedia)` |
-| `HlsAudioElement` (tag `hls-audio`) | `define/media/hls-audio.ts` | Custom-element definition; registers `<hls-audio>` via `safeDefine` |
+| `HlsAudioElement` (tag `hls-audio`) | `media/hls-audio/element.ts` | Custom-element implementation; `define/media/hls-audio.ts` registers it via `safeDefine` |
 
 CDN entry: `packages/html/src/cdn/media/hls-audio.ts` →
</file context>
Suggested change
| `HlsAudioElement` (tag `hls-audio`) | `media/hls-audio/element.ts` | Custom-element implementation; `define/media/hls-audio.ts` registers it via `safeDefine` |
| `HlsAudioElement` (tag `hls-audio`) | `define/media/hls-audio.ts` | Defines `HlsAudioElement` (extends `HlsAudio` in `media/hls-audio/media.ts`), registers `<hls-audio>` via `safeDefine` |


```ts
import '@videojs/html/video/player';
import '@videojs/html/ui/container';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The example registers via the new import but the .html markup never uses it, so a reader following the doc gets no effect from the import. Add a wrapper around

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .agents/skills/write-api-reference/references/demo-patterns.md, line 108:

<comment>The example registers <media-container> via the new import but the .html markup never uses it, so a reader following the doc gets no effect from the import. Add a <media-container> wrapper around <video> and <media-mute-button> in the .html example (mirroring the real demos, e.g. mute-button/html/css/BasicUsage.html) so the import matches the markup.</comment>

<file context>
@@ -105,12 +105,14 @@ The `.astro` wrapper is required because only Astro `<script>` tags go through V
 
 ```ts
 import '@videojs/html/video/player';
+import '@videojs/html/ui/container';
 import '@videojs/html/ui/mute-button';

</file context>


</details>

…rols

The publisher Tailwind controls carried `peer-data-open/error:hidden!` from
the pre-dialog error markup. After the dialog port the error dialog root no
longer declares `peer/error`, and the controls class sits on the nested
`media-controls-content`, so the variant could never match. Remove it: the
dialog backdrop overlays the bar while an error is open, the same behavior
the CSS flavor and the video skins have now.
@mmcc
mmcc merged commit 5622191 into mmcc/moq-publisher Sep 1, 2026
24 of 25 checks passed
@mmcc
mmcc deleted the chore/sync-publisher-upstream branch September 1, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants