Repository navigation
fix(spf): align publisher framing and tests with relay 0.14.17 - #48
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73f42e4a90
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| Temporary implementation notes — delete before merge per `AGENTS.md`. | ||
|
|
||
| **Issue #45 verification (2026-09-16, moq-relay 0.14.17):** the shared codec |
There was a problem hiding this comment.
Remove the temporary migration plan before merge
Do not expand and retain this planning file: the repository guide explicitly classifies .agents/plans/ as temporary implementation notes that must be deleted before merge. Keeping it also preserves stale implementation-planning claims, such as the later statement that fills are not needed for the relay path, despite this change documenting that relay 0.14.17 now requests them; delete the plan and move only explicitly requested durable rationale to an appropriate record.
AGENTS.md reference: AGENTS.md:L64-L70
Useful? React with 👍 / 👎.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size Report🎨 @videojs/html — 2 small size changes
Presets (7)
Media (21)
Players (6)
Skins (41)
UI Components (60)
⚛️ @videojs/react — 1 small size change
Presets (7)
Media (24)
Players (5)
Skins (29)
UI Components (50)
🧩 @videojs/core — no changesEntries (77)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/media
Entries (21)
📦 @videojs/spf — 3 small size changes
Entries (13)
ℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
There was a problem hiding this comment.
1 issue found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".agents/plans/moq-transport-20-migration.md">
<violation number="1" location=".agents/plans/moq-transport-20-migration.md:21">
P2: Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| @@ -9,7 +9,7 @@ code on `mmcc/moq` and `mmcc/moq-publisher` pinned draft-19 | |||
| not change; loc.ts already uses the loc-04 property IDs that draft-20 §15.8 | |||
There was a problem hiding this comment.
P2: Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .agents/plans/moq-transport-20-migration.md, line 21:
<comment>Delete this temporary migration plan before merging instead of extending it with completed verification logs. Keeping it will leave non-authoritative, date-specific protocol guidance in the repository, which the plan-directory policy explicitly forbids.</comment>
<file context>
@@ -18,6 +18,29 @@ the spec text is ambiguous, and calls out each place it does.
Temporary implementation notes — delete before merge per `AGENTS.md`.
+**Issue #45 verification (2026-09-16, moq-relay 0.14.17):** the shared codec
+uses bare Locations in both directions. Fixed-byte tests pin SUBSCRIBE_OK,
+REQUEST_OK, multi-byte IDs, following parameters/properties, and truncation.
</file context>
Brings the publisher stack onto mmcc/moq at 2fefce4 (PRs #47, #50, #51): subscriber location framing for moq-relay 0.14.17, isolated subscription recovery attempts with preserved retry backoff, and the moq publishing guide under packages/spf/docs. No publisher-side ports were needed. The LARGEST_OBJECT bare-Location codec change from PR #47 was already on this branch via PR #48, so control-messages.ts and its tests merge to the existing content.
Refs #45
Related subscriber PR: #47
Fill-serving follow-up: #46
Summary
Once a track has content, the publisher includes LARGEST_OBJECT in SUBSCRIBE_OK and REQUEST_OK. Its old length prefix is incompatible with moq-relay 0.14.17. Encode and decode Locations as two bare varints, and update the relay test hub to exercise the new upstream pull.
Changes
Known limitation, tracked separately in #46: the existing publisher rejects nonempty fills when the browser lacks
writer.commit(). This PR covers the framing fix and the existing reliable-reset path; it does not implement browser-compatible fill serving. Older relays' length-prefixed Locations remain incompatible, so coordinate deployment with the relay upgrade.Testing
pnpm check:workspacepassed.moqdev/moq-relay:0.14.17: initial delivery and a late subscriber receiving Largest Object{255,128}plus 129 cached objects succeeded.NOT_SUPPORTED: fill requires reliable stream resetin Chromium 147.0.7727.15 / Playwright 1.59.1, including with experimental web-platform features. Full live publisher re-subscription remains unverified until Serve MoQ Publisher Fills Without Requiring Browser Reliable Reset Support #46 is addressed; the protocol test used synthetic payloads.Summary by cubic
Fixes the
LARGEST_OBJECTframing mismatch from #45: the publisher now encodes and decodes it as two bare varints inSUBSCRIBE_OKandREQUEST_OK, matchingmoq-relay0.14.17. Older relays' length-prefixed Locations remain incompatible, so deploy this with the relay upgrade.Changes
SUBSCRIBE_OK,REQUEST_OK, trailing parameters/properties, and truncation;INCLUDE_PROPERTIESstays length-prefixed.FILL_PARAMETERS StartGroup=1, with subscriber priority 255.writer.commit()(Serve MoQ Publisher Fills Without Requiring Browser Reliable Reset Support #46); this PR keeps the existing reliable-reset path.Written for commit 73f42e4. Summary will update on new commits.