Repository navigation
feat(skin): port the publisher skin to VJSC - #57
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
📦 Bundle Size Report🎨 @videojs/html
Small changes (2, ≤ 300 B)
Presets (7)
Media (20)
Players (6)
Skins (32)
UI Components (73)
⚛️ @videojs/react
Small changes (1, ≤ 300 B)
Presets (7)
Media (23)
Extensions (2)
Players (5)
Skins (20)
UI Components (50)
🧩 @videojs/core
Entries (77)
🏷️ @videojs/element — no changesEntries (2)
📦 @videojs/store — no changesEntries (3)
🔧 @videojs/utils — no changesEntries (13)
📦 @videojs/cdn — no changes📦 @videojs/cloudflare-video — no changes📦 @videojs/dash-video — no changes📦 @videojs/google-cast — no changes📦 @videojs/hlsjs-video — no changes📦 @videojs/media — no changesEntries (3)
📦 @videojs/mux — no changes📦 @videojs/mux-audio — no changesEntries (2)
📦 @videojs/mux-data — no changes📦 @videojs/mux-video — no changesEntries (2)
📦 @videojs/native-hls-video — no changes📦 @videojs/shaka-video — no changes📦 @videojs/spf — no changesEntries (10)
📦 @videojs/spotify-audio — no changes📦 @videojs/tiktok-video — no changes📦 @videojs/twitch-video — no changes📦 @videojs/other — no changesEntries (3)
📦 @videojs/vimeo-video — no changes📦 @videojs/wistia-video — no changesEntries (2)
📦 @videojs/youtube-video — no changesℹ️ How to interpretEach entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately. Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles. Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded. Run |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1ea651fc00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
All reported issues were addressed across 120 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Authors the publisher skin in VJSC at packages/skins/src/presets/publisher and generates the HTML and React package CSS skins from it, so the vendored legacy-skin copies are gone. The publisher compiles through the shared graph under its own `skin=default-publisher` variant and stays out of skinStyles, the catalog, and the registry. - core: VJSC component declarations for the publisher UI modules - react: CameraRadioGroup and MicRadioGroup Root/Value/Options parts - skins: fork-owned build/publisher.ts generator, publisher tokens, and small hooks in the shared transform, targets, and package plugin - A failed publish keeps the Go live look (closes the gaps.md entry) - PublisherSkinTailwind(Element) removed: packages ship CSS only; the sandbox compiles Tailwind from the authored source - Drops the generate-cache exclusion and the sandbox media-pulse token - Fixes the React sandbox for createPlayer's `Player` rename Closes #54
1ea651f to
ee01837
Compare
…isible - useCameraOptions/useMicrophoneOptions return the translated group label, and the Options parts forward it as aria-label unless the caller names the group itself - Controls.Root uses visibility="always" so the controls state matches the bar that never hides
Closes #54. Stacked on #56 (#55 renames). Retarget to
mmcc/moq-publisheronce #56 lands.What changed
packages/skins/src/presets/publisher/(skin.tsx,capture-controls.tsx,publisher.styles.ts,base.css). It reuses the shared Container, ErrorDialog, Button, ButtonTooltip, FullscreenButton, RadioItem, and the menu/popup styles.packages/skins/build/publisher.tsis owned by the fork. The publisher compiles through the shared VJSC graph under its ownskin=default-publishervariant.parseVariantrejects that variant, so the publisher stays out ofskinStyles, the catalog, the registry, andinstallation. Changes to upstream files are small hooks:internal/skins/default-publisher/{template,register,skin.css}internal/skins/default-publisher/**pluspresets/publisher/skin.{tsx,css}component.tsfor the 11 publisher UI modules.CameraRadioGroup/MicRadioGroupRoot/Value/Optionsparts, mirroringCaptionsRadioGroup.legacy-skin/copies andgaps.md; the retry gap is closed because a failed publish keeps the Go live lookmedia-pulsetoken and the@sourcelines for the publisher packagesPublisherSkinTailwind/PublisherSkinTailwindElement: breaking, because the packages now ship CSS only, as upstream doesBehavior notes
data-availabilitythe menu forwards to its trigger, no longer by leaving it out of the React render. The React skin test was updated to match.animate-pulse. The package CSS declares the matching keyframes, because VJSC's CSS output leaves keyframes out.<video>(React). The HTML sandbox slots a custom media element whose<video>lives in its own shadow root. The legacy::slotted(video)rule couldn't reach it either, so that behavior is unchanged.createPlayer().Provider→Player. Upstream renamed it during the sync, and that rename broke this sandbox page.Verification
pnpm build:packages, cleanpnpm typecheck,pnpm lint@videojs/skins77 tests pass, including the browser-support audit, which now covers 18 stylesheets with the publisher's included.@videojs/html543,@videojs/react633: all pass./moq-publisher/and React/react-moq-publisher/, in both CSS and?styling=tailwind🤖 Generated with Claude Code
Summary by cubic
Ports the publisher skin to VJSC, authoring it in
packages/skins/src/presets/publisherand removing the duplicated legacy skin copies frompackages/htmlandpackages/react. The skin compiles through the shared VJSC graph under its owndefault-publishervariant and stays out of the catalog, registry, andskinStyles.Breaking Changes
PublisherSkinTailwindandPublisherSkinTailwindElementare removed; the publisher packages now ship CSS only, like upstream.CameraRadioGroupandMicRadioGroupparts mirroringCaptionsRadioGroup.Bug Fixes
data-availabilityforwarded by the menu instead of being dropped from the React render.animate-pulse, with matching keyframes declared in the package CSS since VJSC's CSS output omits keyframes.VideoPublisherElementitself, so<video-publisher>works from the single skin import.createPlayer().Provider→Playerrename from the upstream sync.Written for commit 59bbce1. Summary will update on new commits.