Skip to content

feat(spf): send SUBSCRIBER_PRIORITY by track kind on MoQ media subscribes - #69

Merged
mmcc merged 2 commits into
mmcc/moqfrom
mmcc/moq-subscriber-priority
Oct 27, 2026
Merged

mmcc merged 2 commits into
mmcc/moqfrom
mmcc/moq-subscriber-priority

Conversation

@mmcc

@mmcc mmcc commented Oct 20, 2026 •

Copy link
Copy Markdown
Owner

Closes #68.

The MoQ player's media SUBSCRIBEs now carry SUBSCRIBER_PRIORITY: 16 for audio and 96 for video, so a congested relay-to-viewer downlink sends audio first. moq-relay 0.17 orders a viewer's downlink by subscriber priority alone and ignores the publisher's 0x0E (muxinc/relay-sdks#154). On that relay any REQUEST_UPDATE ends the subscription, so the priority has to go on the SUBSCRIBE. The values match the relay SDKs' mediaSubscribeParameters (muxinc/relay-sdks#337, videojs#343), which measured audio p99 at 74-76 ms with these priorities and 253-259 ms without, on ord behind an 800 kbit/s cap.

What changed

  • MEDIA_SUBSCRIBER_PRIORITY in track-subscriber.ts holds { audio: 16, video: 96 }. The actor picks the value from the track's catalog kind (track.type), not its name.
  • track-subscriber is the only place that builds a media SUBSCRIBE, so the initial join, ABR/layer-switch handoffs, dead-subscription rejoins and suspend/resume rejoins all get the priority. The auth-refresh resubscribe keeps it too.
  • Override: a subscriberPriority in CreateTrackSubscriberOptions.parameters replaces the default. That option is already documented as "auth tokens, priority". No new public player API.
  • The catalog subscription and text tracks still send no priority, so the relay uses its default. The catalog is fetched before any media subscription exists and later updates are rare and small, so I found no concrete reason to change it.

Verification

  • New tests check the SUBSCRIBE parameters for audio and video by catalog kind (including a track named against its kind), the override, the auth-refresh resubscribe, and, through subscribe-selected-tracks with real subscribers, an ABR switch HD→SD plus a rejoin of the handoff target, and an audio rejoin after PUBLISH_DONE.
  • pnpm -F @videojs/spf test (2429 passed), pnpm lint, pnpm typecheck.
  • Live on ord.relay.mux.global, with the relay-sdks Python videojs_stream publisher and the spf-moq-player sandbox in headless Chromium. Decoding the page's WebTransport writes with the player's own parameter decoder gave:
{"requestId":0,"track":"catalog","locationFilter":{"type":"relative-group","groupsBeforeNext":1}}
{"requestId":2,"track":"video","subscriberPriority":96,"locationFilter":{"type":"relative-group","groupsBeforeNext":0}}
{"requestId":4,"track":"audio","subscriberPriority":16,"locationFilter":{"type":"next-object"}}

The relay accepted both subscriptions and playback started.

Notes

  • Publisher side, not changed here: this branch has no publisher. On mmcc/moq-publisher, setup-track-publishers sets a per-subgroup-header publisher priority (catalog 0, audio 64, camera 128, screen 192) and does not send the 0x0E Default Publisher Priority track property with the SDK values (audio 16 / video 96). moq-relay 0.17 ignores both for viewer ordering anyway.

🤖 Generated with Claude Code


Summary by cubic

Media SUBSCRIBEs now carry SUBSCRIBER_PRIORITY chosen by track kind — 16 for audio, 96 for video — so audio stays ahead of video on a congested relay-to-viewer downlink. moq-relay 0.17 orders by subscriber priority alone, so this value rides every media SUBSCRIBE: initial join, ABR/layer-switch handoffs, dead-subscription and suspend/resume rejoins, and the auth-refresh resubscribe. The values match the relay SDKs' mediaSubscribeParameters.

The priority comes from MEDIA_SUBSCRIBER_PRIORITY in track-subscriber.ts, selected by track.type, and can be overridden with subscriberPriority in CreateTrackSubscriberOptions.parameters. refreshAuth only supplies fresh auth: the resubscribe keeps the original subscriberPriority and location whatever it returns. Catalog and text track subscribes send no priority and leave the peer's default.

Written for commit 366a58d. Summary will update on new commits.

View guided diff Turn on auto-fix

…ibes

Audio subscribes carry 16 and video 96, matching the relay SDKs'
mediaSubscribeParameters (muxinc/relay-sdks#337). moq-relay 0.17 orders
a viewer's downlink by subscriber priority alone, so without it audio
queues behind video on a congested link.

Closes #68
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T17:01:54.152125Z 91a8b9e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

📦 Bundle Size Report

🎨 @videojs/html — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/media/simple-moq-video 30.06 kB 30.08 kB +17 B (+0.1%) —
Presets (7)
Entry Initial Lazy
/video (default) 64.34 kB 56.03 kB
/video (default + hls) 66.08 kB 56.03 kB
/video (minimal) 64.88 kB 56.03 kB
/video (minimal + hls) 66.49 kB 56.03 kB
/audio (default) 48.22 kB 56.03 kB
/audio (minimal) 48.51 kB 56.03 kB
/background 11.86 kB 56.03 kB
Media (19)
Entry Initial
/media/mux-video 3.03 kB
/media/mux-audio 2.68 kB
/media/background-video 1.16 kB
/media/cloudflare-video 2.90 kB
/media/dash-video 2.63 kB
/media/hls-audio 23.61 kB
/media/hls-background-video 17.49 kB
/media/hls-video 33.89 kB
/media/hlsjs-video 2.63 kB
/media/mux-background-video 17.47 kB
/media/native-hls-video 7.68 kB
/media/shaka-video 2.63 kB
/media/simple-moq-video 30.08 kB
/media/spotify-audio 3.02 kB
/media/tiktok-video 3.12 kB
/media/twitch-video 2.93 kB
/media/vimeo-video 2.90 kB
/media/wistia-video 607 B
/media/youtube-video 2.90 kB
Players (5)
Entry Initial Lazy
/video/player 9.97 kB 56.03 kB
/audio/player 6.14 kB 56.03 kB
/background/player 4.46 kB 56.03 kB
/live-video/player 9.33 kB 56.03 kB
/live-audio/player 6.16 kB 56.03 kB
Skins (29)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.29 kB —
/video/skin.css css 8.00 kB —
/video/minimal-skin js 63.24 kB 56.03 kB
/video/minimal-skin2 js 8.27 kB —
/video/skin js 62.80 kB 56.03 kB
/video/skin2 js 7.99 kB —
/audio/minimal-skin.css css 6.07 kB —
/audio/skin.css css 5.80 kB —
/audio/minimal-skin js 47.00 kB 56.03 kB
/audio/minimal-skin2 js 6.05 kB —
/audio/skin js 46.74 kB 56.03 kB
/audio/skin2 js 5.78 kB —
/background/skin.css css 141 B —
/background/skin js 10.11 kB 56.03 kB
/background/skin2 js 159 B —
/live-video/minimal-skin.css css 6.77 kB —
/live-video/skin.css css 6.69 kB —
/live-video/minimal-skin js 50.81 kB 56.03 kB
/live-video/minimal-skin2 js 6.77 kB —
/live-video/skin js 50.73 kB 56.03 kB
/live-video/skin2 js 6.67 kB —
/live-audio/minimal-skin.css css 4.77 kB —
/live-audio/skin.css css 4.67 kB —
/live-audio/minimal-skin js 36.17 kB 56.03 kB
/live-audio/minimal-skin2 js 4.77 kB —
/live-audio/skin js 36.14 kB 56.03 kB
/live-audio/skin2 js 4.66 kB —
/global.css css 239 B —
/shadow.css css 78 B —
UI Components (62)
Entry Initial Lazy
/ui/airplay-button 11.52 kB 56.03 kB
/ui/alert-dialog 8.98 kB 56.03 kB
/ui/audio-track-radio-group 11.62 kB 56.03 kB
/ui/buffering-indicator 8.84 kB 56.03 kB
/ui/captions-button 11.76 kB 56.03 kB
/ui/captions-radio-group 11.66 kB 56.03 kB
/ui/cast-button 11.51 kB 56.03 kB
/ui/container 9.71 kB 56.03 kB
/ui/controls 9.03 kB 56.03 kB
/ui/controls-backdrop 1.69 kB 56.03 kB
/ui/controls-content 1.67 kB 56.03 kB
/ui/dialog 8.92 kB 56.03 kB
/ui/dialog-backdrop 1.70 kB 56.03 kB
/ui/dialog-close 2.06 kB 56.03 kB
/ui/dialog-description 1.69 kB 56.03 kB
/ui/dialog-popup 1.90 kB 56.03 kB
/ui/dialog-title 1.70 kB 56.03 kB
/ui/error-dialog 12.62 kB 56.03 kB
/ui/fullscreen-button 11.50 kB 56.03 kB
/ui/gesture 9.96 kB 56.03 kB
/ui/hotkey 10.37 kB 56.03 kB
/ui/live-button 10.02 kB 56.03 kB
/ui/menu 19.18 kB 56.03 kB
/ui/menu-checkbox-item 1.97 kB 56.03 kB
/ui/menu-content 7.64 kB 56.03 kB
/ui/menu-group 2.09 kB 56.03 kB
/ui/menu-group-label 1.64 kB —
/ui/menu-item 2.29 kB 56.03 kB
/ui/menu-item-indicator 1.38 kB 56.03 kB
/ui/menu-radio-group 3.02 kB 56.03 kB
/ui/menu-radio-item 2.14 kB 56.03 kB
/ui/menu-separator 1.30 kB 56.03 kB
/ui/mute-button 11.52 kB 56.03 kB
/ui/pip-button 11.48 kB 56.03 kB
/ui/play-button 11.46 kB 56.03 kB
/ui/playback-rate-button 11.56 kB 56.03 kB
/ui/playback-rate-radio-group 11.62 kB 56.03 kB
/ui/popover 8.76 kB 56.03 kB
/ui/poster 9.15 kB 56.03 kB
/ui/quality-radio-group 12.12 kB 56.03 kB
/ui/seek-button 11.50 kB 56.03 kB
/ui/seek-indicator 12.95 kB 56.03 kB
/ui/seek-indicator-value 1.10 kB —
/ui/slider 11.88 kB 56.03 kB
/ui/slider-preview 2.01 kB 56.03 kB
/ui/status-announcer 10.86 kB 56.03 kB
/ui/status-indicator 13.29 kB 56.03 kB
/ui/status-indicator-value 1.10 kB —
/ui/thumbnail 10.58 kB 56.03 kB
/ui/time 11.29 kB 56.03 kB
/ui/time-slider 13.38 kB 56.03 kB
/ui/time-slider-chapter-title 9.04 kB 56.03 kB
/ui/time-slider-chapters 9.88 kB 56.03 kB
/ui/title 8.44 kB 56.03 kB
/ui/tooltip 10.13 kB 56.03 kB
/ui/tooltip-label 1.21 kB —
/ui/tooltip-shortcut 1.18 kB —
/ui/volume-indicator 13.26 kB 56.03 kB
/ui/volume-indicator-fill 1.11 kB —
/ui/volume-indicator-value 1.10 kB —
/ui/volume-popover 15.14 kB 56.03 kB
/ui/volume-slider 12.58 kB 56.03 kB
⚛️ @videojs/react — no changes
Presets (7)
Entry Initial Lazy
/video (default) 58.84 kB 56.03 kB
/video (default + hls) 59.33 kB 56.03 kB
/video (minimal) 58.93 kB 56.03 kB
/video (minimal + hls) 59.39 kB 56.03 kB
/audio (default) 45.68 kB 56.03 kB
/audio (minimal) 45.68 kB 56.03 kB
/background 908 B 56.03 kB
Media (22)
Entry Initial
/media/mux-video/hls-js 1.46 kB
/media/mux-video/spf 1.46 kB
/media/mux-audio/hls-js 1.12 kB
/media/mux-audio/spf 1.13 kB
/media/background-video 513 B
/media/cloudflare-video 1.81 kB
/media/dash-video 1.11 kB
/media/hls-audio 22.36 kB
/media/hls-background-video 17.49 kB
/media/hls-video 32.59 kB
/media/hlsjs-video 1.12 kB
/media/mux-audio 1.12 kB
/media/mux-background-video 17.49 kB
/media/mux-video 1.45 kB
/media/native-hls-video 6.32 kB
/media/shaka-video 1.11 kB
/media/spotify-audio 1.89 kB
/media/tiktok-video 1.81 kB
/media/twitch-video 1.84 kB
/media/vimeo-video 1.79 kB
/media/wistia-video 1.41 kB
/media/youtube-video 1.79 kB
Extensions (2)
Entry Initial
/extensions/google-cast 1.77 kB
/extensions/mux-data 1.80 kB
Players (5)
Entry Initial Lazy
/video/player 8.22 kB 56.03 kB
/audio/player 4.38 kB 56.03 kB
/background/player 2.64 kB 56.03 kB
/live-video/player 7.60 kB 56.03 kB
/live-audio/player 4.40 kB 56.03 kB
Skins (18)
Entry Type Initial Lazy
/video/minimal-skin.css css 8.12 kB —
/video/skin.css css 7.81 kB —
/video/minimal-skin js 58.75 kB 56.03 kB
/video/skin js 58.64 kB 56.03 kB
/audio/minimal-skin.css css 5.88 kB —
/audio/skin.css css 5.60 kB —
/audio/minimal-skin js 45.56 kB 56.03 kB
/audio/skin js 45.60 kB 56.03 kB
/background/skin.css css 97 B —
/background/skin js 518 B —
/live-video/minimal-skin.css css 6.60 kB —
/live-video/skin.css css 6.51 kB —
/live-video/minimal-skin js 48.61 kB 56.03 kB
/live-video/skin js 48.64 kB 56.03 kB
/live-audio/minimal-skin.css css 4.58 kB —
/live-audio/skin.css css 4.47 kB —
/live-audio/minimal-skin js 33.79 kB 56.03 kB
/live-audio/skin js 33.79 kB 56.03 kB
UI Components (39)
Entry Initial Lazy
/ui/airplay-button 11.22 kB 56.03 kB
/ui/alert-dialog 5.20 kB 56.03 kB
/ui/audio-track 8.35 kB 56.03 kB
/ui/audio-track-radio-group 10.78 kB 56.03 kB
/ui/buffering-indicator 8.40 kB 56.03 kB
/ui/captions-button 11.19 kB 56.03 kB
/ui/captions-radio-group 10.88 kB 56.03 kB
/ui/cast-button 11.22 kB 56.03 kB
/ui/controls 8.29 kB 56.03 kB
/ui/dialog 5.19 kB 56.03 kB
/ui/error-dialog 12.61 kB 56.03 kB
/ui/fullscreen-button 11.17 kB 56.03 kB
/ui/gesture 8.60 kB 56.03 kB
/ui/hotkey 8.99 kB 56.03 kB
/ui/live-button 9.53 kB 56.03 kB
/ui/menu 22.01 kB 56.03 kB
/ui/mute-button 11.22 kB 56.03 kB
/ui/pip-button 11.18 kB 56.03 kB
/ui/play-button 11.16 kB 56.03 kB
/ui/playback-rate 8.41 kB 56.03 kB
/ui/playback-rate-button 11.14 kB 56.03 kB
/ui/playback-rate-radio-group 10.85 kB 56.03 kB
/ui/popover 9.12 kB 56.03 kB
/ui/poster 8.61 kB 56.03 kB
/ui/quality 8.77 kB 56.03 kB
/ui/quality-radio-group 11.19 kB 56.03 kB
/ui/seek-button 11.18 kB 56.03 kB
/ui/seek-indicator 12.91 kB 56.03 kB
/ui/slider 14.34 kB 56.03 kB
/ui/status-announcer 10.81 kB 56.03 kB
/ui/status-indicator 13.34 kB 56.03 kB
/ui/thumbnail 9.77 kB 56.03 kB
/ui/time 10.60 kB 56.03 kB
/ui/time-slider 16.17 kB 56.03 kB
/ui/title 7.88 kB 56.03 kB
/ui/tooltip 9.98 kB 56.03 kB
/ui/volume-indicator 13.39 kB 56.03 kB
/ui/volume-popover 15.53 kB 56.03 kB
/ui/volume-slider 12.96 kB 56.03 kB
🧩 @videojs/core — no changes
Entries (76)
Entry Initial Lazy
. 13.41 kB —
/dom 23.48 kB 56.03 kB
/vjsc 1.90 kB —
/i18n 3.21 kB 56.03 kB
/i18n/locales/all 33.91 kB —
/i18n/locales/ar 1.16 kB —
/i18n/locales/az 1.08 kB —
/i18n/locales/bg 1.29 kB —
/i18n/locales/bn 1.25 kB —
/i18n/locales/bs 1.02 kB —
/i18n/locales/ca 1.04 kB —
/i18n/locales/cs 1.10 kB —
/i18n/locales/cy 1.02 kB —
/i18n/locales/da 984 B —
/i18n/locales/de 1.06 kB —
/i18n/locales/el 1.42 kB —
/i18n/locales/en 801 B —
/i18n/locales/es 999 B —
/i18n/locales/et 1.02 kB —
/i18n/locales/eu 1.04 kB —
/i18n/locales/fa 1.21 kB —
/i18n/locales/fi 1.05 kB —
/i18n/locales/fr 1.01 kB —
/i18n/locales/gd 1.09 kB —
/i18n/locales/gl 1017 B —
/i18n/locales/he 1.10 kB —
/i18n/locales/hi 1.25 kB —
/i18n/locales/hr 1.05 kB —
/i18n/locales/hu 1.10 kB —
/i18n/locales/id 953 B —
/i18n/locales/it 1.01 kB —
/i18n/locales/ja 1.16 kB —
/i18n/locales/ko 1.08 kB —
/i18n/locales/lt 1.04 kB —
/i18n/locales/lv 1.09 kB —
/i18n/locales/mr 1.23 kB —
/i18n/locales/nb 990 B —
/i18n/locales/ne 1.23 kB —
/i18n/locales/nl 1.01 kB —
/i18n/locales/nn 983 B —
/i18n/locales/oc 1.05 kB —
/i18n/locales/pl 1.11 kB —
/i18n/locales/pt 1.02 kB —
/i18n/locales/pt-BR 1.02 kB —
/i18n/locales/pt-PT 1.02 kB —
/i18n/locales/ro 1.04 kB —
/i18n/locales/ru 1.36 kB —
/i18n/locales/sk 1.10 kB —
/i18n/locales/sl 1.04 kB —
/i18n/locales/sr 1.05 kB —
/i18n/locales/sv 1.01 kB —
/i18n/locales/te 1.29 kB —
/i18n/locales/th 1.20 kB —
/i18n/locales/tr 1.00 kB —
/i18n/locales/uk 1.37 kB —
/i18n/locales/vi 1.10 kB —
/i18n/locales/zh 1.01 kB —
/i18n/locales/zh-CN 1.01 kB —
/i18n/locales/zh-TW 1.02 kB —
/i18n/text/airplay 101 B —
/i18n/text/buttons 137 B —
/i18n/text/captions 93 B —
/i18n/text/cast 114 B —
/i18n/text/common 90 B —
/i18n/text/container 75 B —
/i18n/text/errors 285 B —
/i18n/text/fullscreen 98 B —
/i18n/text/live 126 B —
/i18n/text/menu 249 B —
/i18n/text/pip 101 B —
/i18n/text/playback 80 B —
/i18n/text/seek 105 B —
/i18n/text/slider 65 B —
/i18n/text/status 222 B —
/i18n/text/time 322 B —
/i18n/text/volume 133 B —
🏷️ @videojs/element — no changes
Entries (2)
Entry Initial
. 1.05 kB
/context 943 B
📦 @videojs/store — no changes
Entries (3)
Entry Initial
. 1.72 kB
/html 703 B
/react 511 B
🔧 @videojs/utils — no changes
Entries (13)
Entry Initial
/array 271 B
/dom 5.25 kB
/events 320 B
/function 414 B
/i18n 249 B
/jwt 176 B
/object 535 B
/predicate 297 B
/percent 281 B
/string 239 B
/style 212 B
/time 1018 B
/number 199 B
📦 @videojs/cdn — no changes
📦 @videojs/cloudflare-video — no changes
📦 @videojs/dash-video — no changes
📦 @videojs/google-cast — no changes
📦 @videojs/hlsjs-video — no changes
📦 @videojs/media — no changes
Entries (3)
Entry Initial
. 1.29 kB
/dom 4.12 kB
/media-tracks 2.05 kB
📦 @videojs/mux — no changes
📦 @videojs/mux-audio — no changes
Entries (2)
Entry Initial
. 136.12 kB
/spf 22.85 kB
📦 @videojs/mux-data — no changes
📦 @videojs/mux-video — no changes
Entries (2)
Entry Initial
. 136.12 kB
/spf 33.00 kB
📦 @videojs/native-hls-video — no changes
📦 @videojs/shaka-video — no changes
📦 @videojs/spf — 1 small size change
Path Base initial PR initial Initial diff Lazy diff
/moq 28.58 kB 28.64 kB +61 B (+0.2%) —
Entries (8)
Entry Initial
. 4.55 kB
/dom 7.67 kB
/hls 28.22 kB
/media-tracks 607 B
/moq 28.64 kB
/hls-background-video 16.51 kB
/hls-audio 21.36 kB
/hls-video 31.73 kB
📦 @videojs/spotify-audio — no changes
📦 @videojs/tiktok-video — no changes
📦 @videojs/twitch-video — no changes
📦 @videojs/other — no changes
Entries (3)
Entry Initial Lazy
video.js 71.83 kB 56.03 kB
video.js/package.json 608 B —
video.js/errors 1.03 kB —
📦 @videojs/vimeo-video — no changes
📦 @videojs/wistia-video — no changes
Entries (2)
Entry Initial
. 1.91 kB
/helpers 1.77 kB
📦 @videojs/youtube-video — no changes

ℹ️ How to interpret

Each entry is independently bundled, minified, and brotli-compressed. Initial size includes its static import graph; lazy dynamic chunks are reported separately.

Entries are not additive because their dependency graphs overlap. Preset rows represent realistic combined bundles.

Changes of 300 B or less across initial, lazy, and total size are collapsed, not discarded.

Run pnpm size locally to check current initial sizes.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="packages/spf/src/playback/actors/track-subscriber.ts">

<violation number="1" location="packages/spf/src/playback/actors/track-subscriber.ts:617">
P3: The auth-refresh resubscribe drops any `subscriberPriority` that `refreshAuth` returns, because this line overwrites it after `...refreshed`. `refreshAuth` is documented to return parameters to retry with, so a refreshed value should win and the resolved kind default should be the fallback. Use `refreshed.subscriberPriority ?? parameters.subscriberPriority`.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

subscribe({
...parameters,
...refreshed,
subscriberPriority: parameters.subscriberPriority,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: The auth-refresh resubscribe drops any subscriberPriority that refreshAuth returns, because this line overwrites it after ...refreshed. refreshAuth is documented to return parameters to retry with, so a refreshed value should win and the resolved kind default should be the fallback. Use refreshed.subscriberPriority ?? parameters.subscriberPriority.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At packages/spf/src/playback/actors/track-subscriber.ts, line 617:

<comment>The auth-refresh resubscribe drops any `subscriberPriority` that `refreshAuth` returns, because this line overwrites it after `...refreshed`. `refreshAuth` is documented to return parameters to retry with, so a refreshed value should win and the resolved kind default should be the fallback. Use `refreshed.subscriberPriority ?? parameters.subscriberPriority`.</comment>

<file context>
@@ -596,7 +611,12 @@ export function createTrackSubscriberActor(options: CreateTrackSubscriberOptions
+                  subscribe({
+                    ...parameters,
+                    ...refreshed,
+                    subscriberPriority: parameters.subscriberPriority,
+                    locationFilter: parameters.locationFilter,
+                  });
</file context>
Suggested change
subscriberPriority: parameters.subscriberPriority,
subscriberPriority: refreshed.subscriberPriority ?? parameters.subscriberPriority,

@mmcc
mmcc merged commit 4f732ff into mmcc/moq Oct 27, 2026
21 of 23 checks passed
@mmcc
mmcc deleted the mmcc/moq-subscriber-priority branch October 27, 2026 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant