Repository navigation
chore: sync mmcc/moq-publisher to videojs/video.js main #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mmcc
wants to merge
4,416
commits into
mmcc/moq-publisher
Choose a base branch
from
chore/sync-videojs-publisher
base: mmcc/moq-publisher
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4416 commits
Select commit
Hold shift + click to select a range
fc049a3
8.22.0
8842d37
refactor(types): track and track list types generation (#8978)
amtins 1c282a3
feat: toJSON methods for text track serialization (#8998)
wseymour15 5b9795d
fix: Improve getFileExtension() readability and handle leading dot ex…
damanV5 77c99d2
feat: Improve SmartTV scrubbing behavior (#8988)
bzizmo c7298d4
8.23.0
Essk 751ac56
fix: controlText for text track modal (#8989)
adrums86 76aadfe
fix: only change focus from BPB if not tap or mouse click (#9015)
Frenzie f2d34ee
Fix broken link in changelog for version 8.19.0 (#8986)
ashimupd 8e1889c
fix: update text-track-cue styles on useractive (#9023)
tsi 5e045af
8.23.1
Essk e0b2521
fix: update release workfow permissions (#9027)
Essk ac523ed
8.23.2
Essk 1a09554
fix: update release workflow `discussion` permission (#9031)
Essk 9537534
8.23.3
Essk 09eb715
docs: Update README.md w/ v10 news link (#9037)
heff 31f8d7c
fix: Component.js string arg type for for removeChild (#9070)
dds05 c3e4f6b
chore(package): update VHS to v3.17.2 (#9079)
Essk 8e4ec97
8.23.4
Essk 20f8d76
docs: Clarify copyright and project stewardship (#9104)
heff 4ceeb01
ci: remove npm token from GHA release.yml to test trusted publisher w…
cjpillsbury d203eab
chore: update prod dependencies (#9129)
mister-ben ec33990
fix: prevent current time display showing 0:00 during seek (#9135)
mister-ben 93ecc35
fix: Broken menu button setIcon type (#9089)
Chocobozzz 08f3ee3
fix: Allow use in jsdom environments without `window.CSS` (#9137)
jdufresne 46779e8
fix: convert Tracklist length to a getter and fix event docs (#9142)
christriants 9cc0b34
fix(lang): improve finnish lang support (#9114)
greeho 553253c
fix(lang): updated translations for gl (#9026)
xuars 67ba442
chore: tags and version changes into main (#9123)
cjpillsbury e27bb32
chore(package): update vhs to v3.17.3 (#9147)
Essk 31dfb75
8.23.7
Essk 6dec037
chore: Convert PR title action to module (#9152)
mister-ben 6ec1314
chore(package): update vhs to 3.17.4 (#9151)
Essk 9d2101e
8.23.8
Essk c625b0b
fix(audio-tracks): missing AD icon in Safari (#9153)
amtins 69ea0e0
fix(types): 'Cannot find name Player' error in type generation (#9162)
amtins 00440ee
fix(track-button): properly remove event listeners on dispose to prev…
nochev 0054c0b
fix(player): strip stale layout class when breakpoints() is re-set (#…
Essk 91423aa
chore: update @videojs/http-streaming to 3.17.5, vhs-utils to 4.1.2, …
Essk 81b3cb4
8.23.9
Essk 1ce2b21
docs(types): document Player.error(null) for clearing MediaError (#9174)
CyberVy f337747
fix: focus the play toggle instead of the tech element on Edge to avo…
BCovePW 60accc0
fix(lang): Update nn (Norwegian Nynorsk) translations (#9208)
arvindfroi adc132a
fix(lang): add missing Japanese (ja) translation for "Playing in Pict…
mahirhir bf013ba
feat(poster): add support for marking player as maincontent (#9173)
kontrollanten 16fdbab
docs: point Quick Start zencdn links at hosted 8.23.6 (#9215)
Hashim1999164 c3a7e0e
8.24.0
Essk 70f498b
chore(package): update @xmldom/xmldom to 0.8.15 (#9230)
Essk 16997fa
8.24.1
Essk b63eb29
fix: ran npm audit fix on npm 6 (#9231)
spuppo-mux 1aea7c9
fix: update node, replace access-sniff with pa11y and override unders…
spuppo-mux a77010c
feat(media): add resolveAdapterType and resolveMimeType (#3024)
mihar-22 a30932a
docs(site): add the vidstack migration guide (#3021)
mihar-22 381727e
refactor(skin): reduce default saturation filter (#3091)
sampotts 9fce51a
refactor(skin): rename media-opaque to media-high-contrast (#3094)
sampotts cbb6b9a
chore(ci): remove e2e failure triage (#3095)
sampotts 253b238
feat(site): mask private installation input in PostHog analytics (#2666)
decepulis fb1e008
feat(site): tag clickable markup for PostHog autocapture (#3084)
decepulis a0e336e
feat(site): tag Mux links with their placement for attribution (#3086)
decepulis 51d09b2
feat(site): record docs, installation, agent-handoff, and Mux upload …
decepulis 712a3d7
feat(site): count agent Markdown reads at the edge (#3081)
decepulis bd8f072
feat(packages): export a per-package VERSION from core, html, and rea…
decepulis 9b6675e
refactor(packages)!: attach extensions at the player (#2880)
luwes 1d1eafc
refactor(packages)!: rename the minimal skin to neutral (#3092)
mihar-22 a8e979b
test(packages): audit every test with the maintain-tests skill (#3080)
mihar-22 571fb68
feat(react): add mediaRef prop to media components (#3098)
luwes 5d419de
feat(skin): add compat skin (#3026)
sampotts 0ca1e1a
fix(media): keep hls.js text tracks when MEDIA_ATTACHED follows the m…
spuppo-mux 3f7a926
refactor(react)!: export compound radio groups from the package root …
decepulis 58122c9
feat(site): check that undocumented public exports are tagged interna…
decepulis 9a4c660
docs(site): stop using internal APIs in examples (#3066)
decepulis 3cb8ee5
docs(site): add reference pages for presets, useMedia, UIElement, and…
decepulis 53e5ce9
refactor(react,html)!: make every stable type importable from the fra…
decepulis 15558aa
chore: tag undocumented public exports @internal and enforce it in CI…
decepulis 8aed7b4
chore(store): check and tag store's public exports (#3083)
decepulis 499b892
chore: release main (#3005)
videojs-release[bot] 37477fc
feat(packages): release Video.js 10.0.0 as stable (#3058)
decepulis 9763e10
chore: release main (#3130)
videojs-release[bot] a46631e
chore(release): add the 10.0.0 root and site changelog (#3131)
decepulis b91ae58
chore(root): remove release-as after the 10.0.0 release (#3065)
decepulis a408299
docs(site): add changelog prose for 10.0.0-rc.5 (#3129)
github-actions[bot] 3bcee61
docs(site): add changelog prose for 10.0.0 (#3133)
github-actions[bot] 012e128
docs(blog): add Video.js 10 release post (#3061)
decepulis 0b1497c
feat(site): move pre-v10 blog posts to the legacy site (#3127)
decepulis ef04287
fix(react): hand the playback adapter to mediaRef on adapter-backed m…
luwes ad7f2a0
fix(mux-video): parse mux stream urls without the .m3u8 extension (#3…
luwes f0c2782
fix(react): accept autoPlay on embeds and drop callback-ref cleanups …
luwes b509794
docs(site): add live demos to skin reference pages (#3137)
decepulis 78035be
docs(site): turn the nav version pill into a docs version menu (#3144)
decepulis 29cd89d
Add Video.js v10 migration overview to docs (#3105)
heff 7021cfe
docs(site): fix shadcn and migration links in 10.0 blog post (#3148)
decepulis 5106afd
chore(packages): prune stale and add missing workspace dependencies (…
luwes a738ed6
docs: say "media component" instead of "media element" (#3150)
decepulis 27dcd7d
fix(youtube-video): keep the iframe in place when detach destroys the…
luwes a19eda4
chore: release main (#3142)
videojs-release[bot] 941c00d
chore: give favicon graduated bar proportions (#3159)
decepulis 0164acc
docs(site): add changelog prose for 10.0.1 (#3155)
github-actions[bot] c7f324e
ci(changelog-prose): defer to the raw changelog for breaking changes …
decepulis 04d29bc
fix(icons): optically center the compat play icon (#3146)
luwes ae9f9fc
Merge Video.js v8 history into v10
luwes 11938a0
ci: replace changelog/blog forward-port with on-demand cherry-picks (…
decepulis f16a42d
feat(skin): publish the button tooltip as a registry component (#3194)
mihar-22 78c042b
docs(core): replace contributor steps with getting started and AI qui…
mihar-22 fe34200
fix(hlsjs-video): bump hls.js (#3171)
spuppo-mux 511e8a6
feat(packages): support hls json chapters in hls.js and native hls (#…
luwes 226c950
feat(site): add the popover TOC rail to blog and changelog posts (#3168)
decepulis ff2241c
feat(site): render footnotes with popovers in rich content (#3166)
decepulis f45b35f
feat(site): add Figure component for captioned images (#3200)
decepulis 7480305
docs(site): add iphone duo blog post (#3199)
decepulis 5660f44
fix(site): drop section from page titles and break OG titles at claus…
decepulis 52e4362
docs(site): note that wistia loads sentry on playback errors (#2943)
sampotts 897901b
feat(spf): send credentials with hls requests for crossorigin="use-cr…
luwes 8614a9e
Merge Video.js v8 history into v10
luwes b30e107
docs(root): add security policy and v8 issue routing (#9248)
luwes 6a21d0b
fix(core): smooth time slider playback progress
sampotts 7d88ca2
fix(core): stop extrapolating stalled native media time
sampotts 5fe31de
fix(core): sync time slider progress with seekable ranges
sampotts 258fafb
perf(core): skip semantic updates on time slider frames
sampotts 88e229c
fix(core): sample playback time on animation frames
sampotts 50f59a2
Merge pull request #9250 from videojs/fix/smooth-playhead
sampotts 17956da
chore(root): point repository links at videojs/video.js (#9253)
luwes 89fd4a0
chore(root): include every release since 2010 in the changelog (#9255)
luwes c39479b
feat(skin): add scaffold skin (#9251)
sampotts e917909
fix(ci): skip package manager cache in release pr changelog job (#9268)
luwes f23b55c
fix(skin): show compat backdrop while buffering (#9252)
sampotts 69b53d9
fix(skin): correct scaffold parity checks and rtl controls (#9269)
sampotts cebef62
docs(root): remove readme timeline (#9320)
sampotts d2d7814
docs(root): route v8 security reports and issues to videojs-v8 (#9321)
mihar-22 7e763d3
fix(site): correct HDR screenshots and optimize responsive images (#9…
sampotts 20485da
fix(sandbox): improve width editing and empty accent preview (#9329)
sampotts 74cf8cd
fix(skin): improve scaffold reduced-transparency controls (#9287)
sampotts c4705d4
feat(sandbox): offer youtube clips in the source picker (#9374)
luwes b56d02d
feat(playerjs-video): add player.js embed media (#9247)
luwes 16aa693
fix(youtube-video): keep caption tracks in sync with the embed (#9367)
javierarams d067696
feat(site): publish full entry content in the blog and changelog feed…
decepulis 2c90308
feat(installation): link native media fallback to videojs.org/help (#…
decepulis 3f5f75d
feat(react): link native media fallback to videojs.org/help (#9382)
decepulis 19c3d26
perf(site): request a 2400px hero poster instead of the 4K source (#9…
decepulis 746e131
perf(site): load the docsearch modal on first search intent (#9376)
decepulis f79585f
fix(site): match the eurostile fallback faces on every platform (#9377)
decepulis 5ff5413
refactor(packages): drop the hidden about-this-player link from skins…
decepulis fe45929
fix(skin): clean up title and caption alignment (#9389)
sampotts 48f79b8
chore(sandbox): add cosmic dawn media source (#9390)
sampotts 05f40e8
docs(site): add the video-react migration guide (#9397)
luwes 875da58
feat(video.js): route installs to the framework packages (#9258)
mihar-22 79a12d2
feat(video.js): publish video.js to npm under next (#9477)
mihar-22 919ad95
chore: release main (#9249)
videojs-release[bot] 72801b8
fix(sandbox): ignore unknown source query values (#9404)
sampotts 03586f1
refactor(site): share one focus outline and popover ring (#9405)
sampotts a761d33
feat(site): add a comparison component (#9406)
sampotts b192fdc
build(root): watch only development outputs in pnpm dev (#9483)
sampotts fdb1a1c
chore(root): upgrade workspace dependencies (#9482)
sampotts c056868
fix(skin): show elapsed time on compact neutral players (#9484)
sampotts 583191f
fix(react): render crossorigin attributes before hydration (#9403)
sampotts ff8d26f
fix(skin): keep media text colors when merging Tailwind classes (#9491)
sampotts 6172124
fix(skin): scale scaffold controls in fullscreen (#9487)
sampotts 476a3c8
fix(sandbox): debounce shell URL sync to avoid replaceState rate limi…
sampotts c0d7abc
ci(cd): allow release recovery after main moves on (#9490)
luwes 271ea01
chore(root): add npm trusted publishing setup and release pr check (#…
luwes 2ff5aa1
test(sandbox): wait for the debounced URL in the compare aspect-ratio…
sampotts eba7839
fix(test): retry browserstack connections and report their cause (#9506)
sampotts ea35beb
docs(site): resolve inherited slider defaults (#9398)
javierarams f85dc0d
docs(site): add changelog prose for 10.1.0 (#9481)
github-actions[bot] 4cbfdea
feat(core): depend on video.js (#9507)
luwes c71b02f
ci(ci): add claude pr bug review workflow (#9508)
luwes fbab3b9
build(installation): keep node built-ins external in the neutral buil…
sampotts 76f3df5
docs(site): install composer archive into libraries/videojs-cdn (#9513)
luwes 57ed313
ci(ci): review fork prs after workflow approval (#9515)
luwes 3bfe71a
ci(ci): scope claude reviewer gh commands to the reviewed pr (#9516)
luwes da0b2dc
ci(ci): skip claude reviews when the pr diff is unchanged (#9517)
luwes 4676472
fix(hlsjs-video): read live edge start from hls.js live sync position…
mrlika 6872005
fix(packages): seek while dragging the time slider so the frame updat…
Anandb71 c1c3f76
feat(cli): add skin create to start a skin project (#9500)
sampotts 2228a99
feat(cli): preview skins in a sandbox-style workbench (#9501)
sampotts e1be8a5
feat(cli): deploy skin workbenches to vercel, netlify, or cloudflare …
sampotts 64efe4d
ci(cli): build every skin create combination (#9514)
sampotts 2d40a22
perf(html): re-render sliders on resize only for edge thumb alignment…
taekop 19e2d82
refactor(spf)!: derive engine types from their behaviors and drop sha…
cjpillsbury 31f3391
feat(spf): opt-in MoQ audio renderer over the shared worklet audio core
mmcc a38555e
fix(spf): worklet audio renderer clock follows context time through p…
mmcc 1a7945d
fix(spf): keep the worklet clock monotonic across underrun recovery a…
mmcc f7d1672
fix(spf): worklet clock floor follows the audible position; frame len…
mmcc dddb2fe
fix(spf): bound the placed re-join clock and ignore pre-underrun tail…
mmcc 0e5fcb3
fix(spf): count every worklet starvation edge; let a frozen re-join r…
mmcc c2beabf
fix(spf): count a worklet dry edge that a track change lands on
mmcc 9ca2548
Merge pull request #67 from mmcc/feat/moq-worklet-audio-renderer
mmcc ff6ef6e
feat(site): add swag link to footers (#9552)
decepulis 8a0a3d8
build(site): upgrade astro to 7.4 and enable parallel prerendering (#…
decepulis 91a8b9e
feat(spf): send SUBSCRIBER_PRIORITY by track kind on MoQ media subscr…
mmcc 92be7bd
docs(site): add the skin design inspiration blog post (#9407)
sampotts ede58db
refactor(spf): give each engine its own entry point with uniform name…
cjpillsbury 9e90d26
fix(mux-data): report video.js as the default player software (#9568)
luwes 12b7722
chore(root): stop marking #9391 as breaking in the changelog (#9570)
luwes 1f410e0
refactor(spf): export engine defaults and merge them in createComposi…
cjpillsbury 3f69079
fix(spf): block segment loading under DRM regardless of composition o…
cjpillsbury 76620b1
feat(spf): compose the HLS engines from features (#9395)
cjpillsbury 78ae2b8
chore(packages): drop the spf package-level size scripts for the work…
cjpillsbury 29592ba
fix(skin): remove dead captions and AirPlay controls from audio skins…
sampotts 3b35510
docs(site): add a build your own skin guide (#9505)
sampotts 87bb1c2
feat(cli): point skin projects at the videojs-skin agent skill (#9518)
sampotts 1042afd
chore: release main (#9489)
videojs-release[bot] 1457b86
docs(site): add skin choice guidance (#9474)
mihar-22 da70fba
fix(site): report the deployed branch in the sandbox copy-report on v…
cjpillsbury 40f9900
refactor(spf): import svta error codes from @svta/cml-error-codes (#9…
cjpillsbury d84b573
feat(mux-data): report framework and engine in the player software na…
luwes c15ea19
fix(mux-data): monitor the HLS background video (#9581)
cjpillsbury 83a8ead
docs(site): add changelog prose for 10.2.0 (#9574)
github-actions[bot] 716c660
fix(spf): resolve a relative source URL in the HLS adapters (#9587)
cjpillsbury 6be8ed4
fix(react): leave pointer events to the skin over chromeless embeds (…
luwes 9b115eb
fix(core): keep embeds from taking a volume the browser locks (#9602)
luwes 6f5e053
feat(core): hide playback rate controls when the media has no playbac…
luwes 2e0db03
fix(installation): pass Mux URLs to React Mux media as a structured s…
decepulis ecaab1c
fix(skin): lighten the video controls backdrop (#9585)
sampotts bc54d7a
fix(html): keep the playback rate menu trigger visible once rates are…
sampotts 1e2291c
fix(core): hide open popovers before entering fullscreen (#9627)
sampotts 0c471ab
fix(skin): derive muted foreground from the foreground color (#9558)
sampotts 10e6884
fix(packages): show only the control name in the playback rate toolti…
sampotts 6f56667
feat(core): show a pending autoplay as starting playback (#9609)
luwes 366a58d
docs(spf): state that refreshAuth only refreshes auth on the resubscribe
mmcc 4f732ff
Merge pull request #69 from mmcc/mmcc/moq-subscriber-priority
mmcc 02d064f
Merge videojs/video.js main into mmcc/moq
mmcc c45cbaa
Merge mmcc/moq (videojs/video.js main) into mmcc/moq-publisher
mmcc d8e9f72
chore(html): tag the simple-moq-video element @internal
mmcc e6c040d
Merge mmcc/moq stability tag into mmcc/moq-publisher
mmcc 92f1064
chore(packages): tag undocumented publisher exports @internal
mmcc b835d98
docs(spf): name @caprid/relay as the source of the subscriber priorities
mmcc 1da4b56
feat(spf): render MoQ audio through the @caprid/moq-media worklet core
mmcc 2db76ce
test(installation): skip media the cdn build excludes in the workspac…
mmcc 17a67d1
Merge pull request #73 from mmcc/fix/installation-cdn-moq-exclusion
mmcc 6743350
Merge remote-tracking branch 'origin/mmcc/moq' into feat/moq-worklet-…
mmcc d75c164
fix(spf): start a new fill when a placed re-join clock freezes
mmcc 660e328
feat(spf): speak moqt-22 through @caprid/moq-core
mmcc b2707da
docs(spf): vendor moq-transport draft-22 and repoint transport prose
mmcc 38db34c
fix(spf): keep MoQ audio on WebCodecs with @caprid/moq-media 0.1.1
mmcc acb8ce9
Merge pull request #75 from mmcc/feat/moq-caprid-core
mmcc 7220d44
fix(spf): pin @caprid/moq-media to 0.1.0 to drop 70 kB of unused WASM
mmcc 5e6e811
docs(spf): correct the MoQ loopback relay notes for draft-22
mmcc 9912f29
fix(spf): reject unsafe integers in the MoQ loopback varint encoder
mmcc 049990e
Merge pull request #77 from mmcc/fix/moq-caprid-core-followups
mmcc 6cb0907
docs: Add CI sponsor to readme (#9642)
heff c38933e
ci(ci): run workflows on blacksmith (#9643)
sampotts fdeaafa
Feature: SoundCloud Audio provider (#9524)
javierarams 8989194
fix(hlsjs-video): update hls.js to 1.7.3 (#9645)
decepulis 95fa120
fix(twitch-video): drop the playback rate the embed cannot apply (#9640)
mossaddique 905a6d1
fix(hlsjs-video): keep rendition ids in step with the levels hls.js r…
spuppo-mux d16a4ad
Merge remote-tracking branch 'origin/mmcc/moq' into chore/sync-videoj…
mmcc be530c1
Merge remote-tracking branch 'upstream/main' into chore/sync-videojs-moq
mmcc ae36743
Merge branch 'chore/sync-videojs-moq' into chore/sync-videojs-publisher
mmcc 0d066ce
Merge branch 'mmcc/moq-publisher' into chore/sync-videojs-publisher
mmcc e6fb089
fix(cdn): keep moq-publish-video off the CDN
mmcc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -73,7 +73,7 @@ Primary: | |||||
|
|
||||||
| Secondary: | ||||||
|
|
||||||
| - Existing engine factory + adapter as templates (`createHlsVideoEngine` | ||||||
| - Existing engine factory + adapter as templates (the `hls-video` engine | ||||||
| and `HlsVideoAdapterCore` — the canonical pair the variant parallels). | ||||||
| - `internal/decisions/*.md` — past tactical decisions. | ||||||
|
|
||||||
|
|
@@ -189,7 +189,7 @@ Discipline: | |||||
|
|
||||||
| 9. **Composing variant-specific behaviors into default factory** — | ||||||
| variant-specific behaviors go in the variant factory, not the | ||||||
| default `createHlsVideoEngine`. Same failure mode as | ||||||
| default `hls-video` engine. Same failure mode as | ||||||
| `/implement-spf-feature`'s catalog, but more pointed here: the | ||||||
| *whole point* of a use-case implementation is the variant assembly, | ||||||
| so misrouting at the factory level is the canonical first-pass bug. | ||||||
|
|
@@ -232,7 +232,7 @@ Discipline: | |||||
|
|
||||||
| 16. **SPF adapter stranded at engine layer** — the implementation pass | ||||||
| lands the engine variant + SPF adapter and stops there. The variant | ||||||
| is reachable via `@videojs/spf/hls` but **not consumable through | ||||||
| is reachable via its `@videojs/spf/hls/*` entry point but **not consumable through | ||||||
| the existing player surface** (the `packages/html` custom elements | ||||||
| + `packages/react` components + sandbox demos that real consumers | ||||||
| actually use). The canonical failure shape: ship a "Phase 1 | ||||||
|
|
@@ -421,10 +421,10 @@ typical for use-case implementations: | |||||
| **Core SPF layer (always present):** | ||||||
|
|
||||||
| - **Engine variant factory creation** (new) — typically the first chunk; | ||||||
| parallels `createHlsVideoEngine` shape with the composition mechanism | ||||||
| parallels the `hls-video` engine's shape with the composition mechanism | ||||||
| applied (subtract / add / swap / configure). | ||||||
| - **Adapter creation** (new) — parallels `HlsVideoAdapterCore` / | ||||||
| `HlsVideoMixin`; uses `shareSignals` unchanged. | ||||||
| `HlsVideoMixin`; reads and writes the engine's `state` / `context` directly. | ||||||
| - **Constituent feature implementation chunks** (if bundling per Step | ||||||
| 2) — route to `/implement-spf-feature`. | ||||||
| - **Use-case-specific behavior creation** (if any) — route to | ||||||
|
|
@@ -435,7 +435,7 @@ typical for use-case implementations: | |||||
| the variant; per-behavior tests for any new use-case-specific | ||||||
| behaviors. | ||||||
| - **Composition wiring** — ties the variant factory into the adapter | ||||||
| and exposes via `packages/spf/src/playback/engines/hls/index.ts`. | ||||||
| and exposes via `packages/spf/src/hls.ts`. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: This path points implementers at the shared HLS barrel rather than the engine composition module, so variant wiring may be added to the wrong file. Point to the corresponding file under Prompt for AI agents
Suggested change
|
||||||
|
|
||||||
| **Implementation-scope-extension layers (opt-in per Step 2):** | ||||||
|
|
||||||
|
|
@@ -516,7 +516,7 @@ Iterate per chunk: | |||||
| - **Subtractive composition / wiring** — handle inline. | ||||||
| - **Config-driven** — handle inline. | ||||||
| - **Engine variant factory creation** — handle inline (typically; the | ||||||
| factory shape parallels `createHlsVideoEngine`). | ||||||
| factory shape parallels the `hls-video` engine). | ||||||
| - **Adapter creation** — handle inline (typically; the adapter shape | ||||||
| parallels `HlsVideoAdapterCore` + `HlsVideoMixin`). | ||||||
| - **New use-case-specific behavior** → route to `/create-spf-behavior`. | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,128 @@ | ||
| --- | ||
| name: maintain-tests | ||
| description: Gate and audit test value. Use when writing, reviewing, or pruning tests or test-only seams. | ||
| --- | ||
|
|
||
| # Maintain tests | ||
|
|
||
| Three modes, one value bar. Optimize for confidence, not deletion count. | ||
|
|
||
| - **Authoring**: gate every new or changed test at write time. | ||
| - **Audit**: run a focused sweep for tests that restate source, duplicate stronger proof, couple behavior to implementation, or keep test-only production seams alive. Land it as one coherent batch; continue in separate follow-up PRs. | ||
| - **Campaign**: prune a whole package or feature surface. Read [references/campaign.md](references/campaign.md) before starting one. | ||
|
|
||
| ## Authoring gate | ||
|
|
||
| Before adding a test, answer four questions; a missing answer means do not add it yet: | ||
|
|
||
| 1. What observable behavior, invariant, or independent contract does it protect? | ||
| 2. What credible regression makes it fail? | ||
| 3. Why does existing coverage not already catch that failure? Each contract has one primary owner at the strongest boundary. Runtime-neutral logic belongs to `core`, `media`, `store`, `spf`, or `utils` tests. `html` and `react` tests own only the binding: attributes, properties, props, rendering, events, registration, lifecycle, and SSR. Another layer needs its own distinct risk. Prefer a table-driven case or shared fixture over a near-duplicate test. | ||
| 4. Does it need a production seam (export, flag, wrapper, injection hook) that no production caller needs? If yes, move the test to the real boundary instead. | ||
|
|
||
| Then check the test against every [junk pattern](#junk-patterns); a match fails the gate unless the [retention bar](#retention-bar) names the contract it independently guards. A test that breaks under behavior-preserving refactoring asserts implementation; rewrite it at the owning boundary. | ||
|
|
||
| Bug regression tests must fail on the pre-fix code for the intended reason and pass after the owner-boundary repair. One regression at the owner boundary covers the bug; do not replay it at every layer it crosses. | ||
|
|
||
| ## Junk patterns | ||
|
|
||
| Authoring rejects new tests that match; audits hunt existing tests that do. | ||
|
|
||
| - assertion-free coverage probes, and assertions that cannot fail; | ||
| - self-comparisons and identity copiers; | ||
| - copied fixtures, inventories, manifests, or export lists; | ||
| - exact source, import, or string greps; | ||
| - private predicate or call-shape tests duplicated at real boundaries; | ||
| - duplicate invocations of the same contract, including core logic replayed through both HTML and React; | ||
| - adapter- or extension-local replays of shared helpers (`packages/adapters/mux`, `@videojs/utils`, shared media hosts); | ||
| - tests whose only purpose is preserving test-only exports, globals, or wrappers; | ||
| - dead production code whose only callers are tests; | ||
| - expected values produced by the helper or renderer under test; | ||
| - mocks that implement the asserted behavior, or one mock standing in for different APIs; module mocks flagged by `anti-slop/no-module-mocking` are a common source; | ||
| - fixtures that supply the event, state, or callback ordering the owner should produce, such as dispatching the media event the code should cause or asserting store state the path never writes; | ||
| - capability tests that restate declared flags instead of exercising the behavior the flag promises; | ||
| - negative controls that pass for an unrelated reason: another guard, a disconnected element, an API the simulated DOM lacks, a synchronous check of an update that lands a microtask or frame later, or a rejection the production path never reaches; | ||
| - names or fixtures that promise more than the input exercises. | ||
|
|
||
| ## Value bar | ||
|
|
||
| Tests justify their maintenance cost by protecting behavior, a credible regression, or an independently meaningful contract. An existing test that must change for behavior-preserving reorganization is suspect, not automatically deletable. | ||
|
|
||
| Before judging a candidate, read the complete test and production owner, its entry point, callers, callees, sibling implementations, overlapping tests, CI routing, and history. Read root and scoped `AGENTS.md` files first. When a test claims dependency-backed behavior (hls.js, dash.js, Shaka, embed SDKs, jsdom, happy-dom), inspect the dependency source or types in `node_modules`. Check which environment the package's Vite config gives the test; simulated DOMs omit many media APIs. | ||
|
|
||
| ## Discovery | ||
|
|
||
| Keep discovery read-only and report evidence before editing. For broad scope, run parallel lanes cut along production owners: | ||
|
|
||
| - runtime-neutral packages: `utils`, `store`, `element`, `media`, `core`; | ||
| - `spf`, by owner: core, network, media, playback behaviors, engines; | ||
| - UI by component family across `core`, `core/dom`, `html`, and `react`, so cross-layer duplicates are visible; | ||
| - adapters and extensions; | ||
| - tooling: `vjsc`, `skins`, `icons`, `installation`, `cli`, `cdn`, `build`, `tools`, `.github/scripts`; | ||
| - `site`, `apps/e2e`, and `apps/sandbox`; | ||
| - a cross-cutting sweep for the junk patterns and test-only exports. | ||
|
|
||
| Outside campaign mode, prefer a few high-confidence candidates over a large speculative inventory. | ||
|
|
||
| ## Retention bar | ||
|
|
||
| Keep a test when it independently enforces a public export, custom-element attribute or event, React prop or ref, store state or request, media or adapter, stream-parsing, accessibility, styling-hook (data attribute or CSS custom property), SSR, i18n, installation-output, API-reference, package, release, visual-baseline, or architecture contract. Also keep: | ||
|
|
||
| - call ordering when order is observable behavior; | ||
| - regressions with a credible failure mode; | ||
| - source inspection when it is the cheapest independent guard: it fails when the contract changes (the user-facing key, byte, or path) and survives an identifier-only refactor; | ||
| - a retained test that fails on the baseline: treat it as a possible product bug, reproduce it, and repair the owner rather than deleting it. | ||
|
|
||
| Static or slow is not a deletion reason. A test that resembles implementation may still be the independent contract; prove otherwise before removing it. | ||
|
|
||
| ## Candidate evidence | ||
|
|
||
| Record every field before editing; a missing field means the candidate is not ready: | ||
|
|
||
| - exact test name and location; | ||
| - what failure it can actually detect; | ||
| - non-test callers of the covered production or support seam; | ||
| - stronger remaining owner-boundary proof, or why no proof is needed; | ||
| - relevant history and the reason the test or seam exists; | ||
| - production or test-support deletion unlocked; | ||
| - risk and the focused validation command. | ||
|
|
||
| ## Edit shape | ||
|
|
||
| Choose one coherent owner-boundary batch. Delete obsolete test-only exports, globals, wrappers, and dead production paths instead of preserving aliases. Move retained regressions to their canonical owners. Consolidate repeated package or dependency assertions into one generic contract. | ||
|
|
||
| Prefer net-negative production LOC. Do not add replacement tests that restate the same implementation, and do not convert uncertain candidates into cleanup to raise deletion counts. | ||
|
|
||
| ## Validation | ||
|
|
||
| Never edit source or tests while Vitest is watching the checkout. | ||
|
|
||
| 1. Tests resolve workspace packages from built output. In a fresh worktree, run `pnpm install` and `pnpm build:packages` first; rebuild a dependency after changing it. | ||
| 2. Run the smallest owner and sibling tests with `pnpm -F <pkg> test <path-or-pattern>`. Timing-sensitive tests can fail under load; rerun a failure alone before recording it. | ||
| 3. For removed greps or inventory assertions, run the executable that owns the real contract, such as `pnpm check:workspace`, `pnpm exec vp run <pkg>#build`, or `pnpm -F site api-docs`. | ||
| 4. After removing exports, build the package and run `pnpm typecheck`. | ||
| 5. Run `pnpm lint:fix:file <file>` on changed files, then `git diff --check`. | ||
| 6. Inspect `git diff --numstat`; report production and tooling separately from tests and test support. | ||
| 7. Have an independent reviewer compare removed coverage against the keepers before handoff. | ||
|
|
||
| ## Landing and continuation | ||
|
|
||
| Commit, push, or open a PR only when authorized. Land one coherent PR at a time; after it lands, refresh from `main` and rerun read-only discovery for the next batch. | ||
|
|
||
| ## Handoff | ||
|
|
||
| Report: | ||
|
|
||
| - root cause and removed low-value categories; | ||
| - production owner simplifications; | ||
| - retained false positives and why they remain valuable; | ||
| - focused and full proof actually run; | ||
| - production versus test LOC; | ||
| - PR and merge state; | ||
| - named follow-ups. | ||
|
|
||
| ## Example | ||
|
|
||
| Input: “Audit the time slider tests.” | ||
|
|
||
| Output: Evidence for each candidate across `core`, `html`, and `react`, one keeper per contract, a single owner-boundary edit batch, the focused `pnpm -F <pkg> test` proof, and a production-versus-test LOC split. |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: This entry-point pattern does not exist, so the workflow can direct implementers to an unresolvable import when exposing a variant engine. Refer to the engine-specific
@videojs/spf/engines/...entry point instead.Prompt for AI agents