Repository navigation
fix: clear ios text fields with the hid clear key instead of cmd+a - #406
Merged
Merged
Conversation
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On iOS,
locator.fill()/locator.clear()cleared fields withcmd+a+backspace. With the devicekit-ios 0.0.33 agent, the first key combo after a field gets focus is dropped, so onlybackspacearrived and one character was deleted ("Glorpax" → "Glorpa", then "Failed to clear element"). Related: #275.What
mobileclito 1.0.20, which installs devicekit-ios agent 0.0.34. That agent adds aclearkey todevice.io.keys(feat: clear key in device.io.keys sends the HID keyboard clear to wipe the focused text field devicekit-ios#101): it sends the HID "Keyboard Clear" usage, which wipes the focused text field in one event, the same way WebDriverAgent does.clearText()on iOS now sends['clear']in bothdriver-mobileclianddriver-mobilenext. Android is unchanged (ctrl+a,backspace).Cloud devices using
driver-mobilenextneed agent 0.0.34 or newer for this to work.Test plan
fill()/clear()step passesNot fixed here: "leaving without saving keeps the old profile" in Milliways still fails when it runs right after a test that saved the profile.
device.clearAppData()doesn't resetUserDefaultson the simulator, which is a separate issue.