Keep recall-collapse baselines stable through silent days - #42
Closed
hamzamerzic wants to merge 2 commits into
Closed
Keep recall-collapse baselines stable through silent days#42hamzamerzic wants to merge 2 commits into
hamzamerzic wants to merge 2 commits into
Conversation
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
Contributor
Author
|
Möbius agent review Result: Blocking queue finding: do not merge this alongside #43. PR #43 replaces the sliding automatic verdict with a durable completion checkpoint and ordered recall evidence, which is the coherent solution to the same failure. Close #42 as superseded by #43. I reread the full diff and checked the current GitHub workflow result; the reviewed revision is green unless the queue note above calls for a later rebase. This is a disclosed agent review posted by the PR author’s account, not an independent maintainer approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR #38 introduced the recall-collapse signal using a trailing seven-day median. During a multi-day outage, silent days eventually drove that median below the alert threshold, so the outage became its own normal and the alert cleared while recall remained inactive.
Ignoring silent days alone would make a single busy day sufficient evidence. This follow-up uses a bounded 14-day nonzero window and requires three active days before treating the median as established.
Tests
PYTHONPATH=. pytest -q(71 tests, 2 subtests)