Make planned-restart continuation always-on and retire its toggle - #846
Merged
hamzamerzic merged 2 commits intoAug 22, 2026
Merged
Conversation
hamzamerzic
added
area: backend
miljanm
reviewed
Aug 22, 2026
miljanm
left a comment
miljanm
left a comment
Contributor
There was a problem hiding this comment.
Reviewer: all clear
I didn't find a concrete issue in this revision. This is a QA second look, not a maintainer approval.
Reviewed revision 3b992a7871d3.
miljanm
reviewed
Aug 22, 2026
miljanm
left a comment
miljanm
left a comment
Contributor
There was a problem hiding this comment.
Reviewer: all clear
I didn't find a concrete issue in this revision. This is a QA second look, not a maintainer approval.
Reviewed revision 94f6ad0f559b.
miljanm
reviewed
Aug 22, 2026
miljanm
left a comment
miljanm
left a comment
Contributor
There was a problem hiding this comment.
Reviewer: all clear
I didn't find a concrete issue in this revision. This is a QA second look, not a maintainer approval.
Reviewed revision 94f6ad0f559b.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Aug 22, 2026
A planned restart is initiated by Möbius itself, so continuing the interrupted work afterward is always the right behavior. The per-chat "Continue after planned restarts" toggle (and its owner-default seed) only ever added a way to break that, so remove the whole preference layer: the chat-settings switch, the API field, the chat-detail response field, the owner default column, and the frontend hook/state/cache plumbing. The per-chat `auto_resume_on_restart` column stays, but now purely as an internal latch: it defaults on for every chat and is cleared only by `delegations.mark_cancelled`, so a cancelled delegated child cannot resurrect itself when the boot sweep claims restart parks. A new appended migration (0016) retires the vestigial `auto_resume_on_restart_default` owner seed: it lifts every chat a prior toggle latched off (excluding cancelled delegation children) and drops the dead column, guarded on the seed column's presence so it no-ops elsewhere. Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
Co-authored-by: Möbius Agent <mobius-agent@users.noreply.github.com>
hamzamerzic
force-pushed
the
fix/retire-restart-resume-toggle
branch
from
August 22, 2026 20:08
94f6ad0 to
24d12a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
A planned restart is initiated by Möbius itself, so continuing the interrupted work afterward is always the right behavior. The per-chat "Continue after planned restarts" toggle (and its owner-default seed) only ever offered a way to break that, so this removes the whole preference layer and makes planned-restart continuation always-on.
Changes
auto_resume_on_restartfrom theChatPatchAPI, the chat-detail response, and chat creation; a PATCH that still sends it is now ignored rather than honored.auto_resume_on_restart_defaultowner column.auto_resume_on_restartcolumn, now purely as an internal latch: it defaults on for every chat and is cleared only bydelegations.mark_cancelled, so a cancelled delegated child cannot resurrect itself when the boot sweep claims restart parks.0016_retire_restart_resume_toggle: it lifts every chat a prior toggle latched off (excluding cancelled delegation children) and drops the dead owner seed column, guarded on the seed column's presence so it no-ops on databases that never carried it.Testing
test_db_migrations.py,test_chat_agent_settings.py,test_delegations.py,test_limit_park.py(176 passed) andscripts/check-schema-migrations.py(16 immutable migrations verified).ChatView/Shelllib and hook suites (61 passed).