Improving the ABD class using WaveformModes from sxs - #119
Draft
akhairna wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @moble, @duetosymmetry and @keefemitman - I have made some initial changes to the ABD class. At this stage it just works if all the input arguments are given as a
sxs.WaveformModesobject. The obvious things that don't work are thefrom_initial_valuesandtransformmethods. Both of them construct an empty instance of the ABD class and then set the field attributes. Going forward I was thinking to use the WaveformModes class in the implementation of these methods to construct the ABD object. If you have any thoughts on better implementation please let me know.