Repository navigation
mcp: answer plain handler errors with -32603 instead of code 0 - #1402
Closed
RyoKusnadi wants to merge 2 commits into
Closed
RyoKusnadi wants to merge 2 commits into
RyoKusnadi wants to merge 2 commits into
Conversation
Contributor
|
Closing as priority given to owner of #1394 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a handler returns a plain Go error (no JSON-RPC code), the peer receives it with
"code": 0. This affects prompts, resources, completion, subscribe, raw tool handlers, receiving middleware, custom methods and the client-side sampling/elicitation handlers.This follows the direction suggested in the issue discussion: right after the receiving method handler in
handleReceive, an error that carries no code (not aWireError, notErrNotHandled/ErrMethodNotFound) is wrapped so it is sent with-32603(Internal error). The message is unchanged anderrors.Is/errors.Ason the original error still work. Coded errors keep their code.The change is gated behind
MCPGODEBUG=noplainerrorinternalcode=1and documented under 1.9.0. A test covers a plain and a coded error returned from receiving middleware.Fixes #1394