Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1404. Follow-up to #1401.
An ID such as
9007199254740993.0or90071992547409930e-1currently falls back to float64 and becomes9007199254740992. This affects request/response identity and cancellation matching against an integer-literal request ID.Keep the existing Int64 fast path, then normalize integral decimal/exponent forms exactly within int64 before the legacy fallback. The parser works on decimal digits, bounds exponent arithmetic, and never allocates storage proportional to the exponent. Other values retain the existing fallback, and the float64 API path is unchanged; this does not implement the stricter policy in #1178. Update the public/internal MakeID documentation accordingly.
Tests cover request/response decoding, MakeID, signed boundaries, equivalent notations, legacy behavior, and actual cancellation over an IO connection. A fuzz oracle uses bounded big.Rat inputs only in tests.
Validation on darwin/arm64:
go test ./...go test -race ./...go vet ./...go build ./...go test ./internal/jsonrpc2 -run '^$' -fuzz '^FuzzExactIntegerID$' -fuzztime=10s -parallel=2— 326,267 executions, PASS.BenchmarkMakeNumericIDsmoke, including an enormous exponent;git diff --check.No new production dependency; no change to out-of-range/fractional rejection policy.