Skip to content

CI installs with npm 10, so the allowScripts denials from #2712 do not apply there #2715

Open

Description

@cliffhall

Problem

#2712 denies the esbuild and fsevents install scripts through allowScripts in each v2 install. npm reads that policy only from 11.19 on. The build, coverage and package jobs in .github/workflows/main.yml use Node 22's bundled npm (10.x) and run npm install with it, so CI still runs both scripts. Copilot raised this on PR #2714.

The verify:install-scripts guard from #2712 reads lockfiles, so it enforces the review decision in CI regardless of npm version. What CI doesn't get is the blocking itself.

Proposed change

Before dependency installation, run npm >= 11.19 in every job that installs dependencies. For example, an exact-pinned npm install -g --ignore-scripts npm@<x.y.z> step, as the publish job already does for OIDC (#2483). Things to check:

Scoring

Severity 2 (CI behaves as it does today; the scripts are not malicious, only unneeded) + urgency 2 + milestone 1 = 5 → Low.

Activity

  1. added this to the v2.12.0 milestone on Oct 13, 2026
  2. added
    v2Issues and PRs for v2
    choreMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior change
    on Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    choreMaintenance: deps, build tooling, CI, cleanup — no user-facing behavior changev2Issues and PRs for v2

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions