chore: require rubocop-minitest 0.39#407
Merged
koic merged 1 commit intoJun 15, 2026
Merged
Conversation
Member
|
I believe this case is no longer flagged. Is that still the case? |
Require rubocop-minitest 0.39.0 or newer so Minitest/AssertEmptyLiteral uses its newer default disabled state.
0e694e3 to
460adaf
Compare
Contributor
Author
|
@koic After upgrading |
koic
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Require
rubocop-minitest0.39.0 or newer soMinitest/AssertEmptyLiteraluses its newer default disabled state.Context
Clean
mainreported 35Minitest/AssertEmptyLiteraloffenses withrubocop-minitest0.38.2. That cop was disabled by default inrubocop-minitest0.39.0 becauseassert_emptycan hide whether the intended expected literal was[]or{}.Changes
rubocop-minitestversion of0.39.0in the Gemfile.Tophatting
GEM_HOME="$PWD/.gem-test" GEM_PATH="$PWD/.gem-test:/nix/store/jh918yiwd5cs4pjg005ac32m2q7ckw3l-ruby-4.0.5/lib/ruby/gems/4.0.0" bundle exec rake rubocopGEM_HOME="$PWD/.gem-test" GEM_PATH="$PWD/.gem-test:/nix/store/jh918yiwd5cs4pjg005ac32m2q7ckw3l-ruby-4.0.5/lib/ruby/gems/4.0.0" bundle exec rake testgit diff --check