Repository navigation
feat: update LATEST - #1105
feat: update LATEST#1105
Conversation
d0b9afc to
f57db37
Compare
DaleSeo
left a comment
DaleSeo
left a comment
There was a problem hiding this comment.
@alexhancock Once the default becomes 2026-07-28, even the initialize handshake will be handled statelessly, so no session will be created. That follows the SEP-2567 direction, but it also means that deployments relying on Mcp-Session-Id could be affected by the upgrade alone, with nothing in the API to signal the change. I'm a bit concerned about the impact, even though this is technically a non-breaking change.
| let client = ClientInfo::default() | ||
| .with_protocol_version(ProtocolVersion::V_2025_11_25) | ||
| .serve(transport) | ||
| .await?; |
There was a problem hiding this comment.
Once we pin this, these tests will only cover 2025-11-25 behavior, and nothing will verify what happens with the new default. What do you feel about adding a companion test that explicitly checks that no session is created at LATEST?
There was a problem hiding this comment.
The function no longer returns server_fallback as-is when it isn't in server_supported.
| tracing::warn!( | ||
| client_requested = %client_requested, | ||
| server_fallback = %fallback, | ||
| "client requested unsupported protocol version; falling back to server default" |
There was a problem hiding this comment.
When the handler's declared fallback isn't in supported_protocol_versions, this field carries the computed replacement.
| "client requested unsupported protocol version; falling back to server default" | |
| "client requested unsupported protocol version; falling back to a supported version" |
|
@alexhancock Any updates on this? |
|
@DaleSeo Sorry I got away from this for a bit. Revising now |
44f50c0 to
5ecf4d3
Compare
5ecf4d3 to
cfbb406
Compare
| // Pinned to the handshake lifecycle: this test drives subscriptions over a | ||
| // session, which `LATEST` no longer establishes. | ||
| fn get_info(&self) -> rmcp::model::ClientInfo { | ||
| rmcp::model::ClientInfo::default() | ||
| .with_protocol_version(ProtocolVersion::LATEST_WITH_INITIALIZE) | ||
| } |
There was a problem hiding this comment.
Is this version pin still needed?
2 participants
Simple update of the
LATESTalias toV_2026_07_28