Skip to content

ci: reject multi-line Codex auth secret - #1306

Merged
DaleSeo merged 1 commit into
mainfrom
DaleSeo/triage-auth-single-line
Sep 28, 2026
Merged

DaleSeo merged 1 commit into
mainfrom
DaleSeo/triage-auth-single-line

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

Motivation and Context

GitHub masks each line of a multi-line secret separately. When auth.json is saved as codex login writes it, with pretty-printing, lines like { and } get masked. As a result, GitHub drops the classification job output with a message saying, "Skip output 'classification' since it may contain secret." Then Apply labels is silently skipped, even though the run reports success.

This check makes the failure visible and tells maintainers how to reset the secret: jq -c . auth.json | gh secret set CODEX_AUTH_JSON. A single trailing newline from jq -c is still accepted.

How Has This Been Tested?

Breaking Changes

CI-only change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

@github-actions github-actions Bot added T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes labels Sep 28, 2026
@DaleSeo
DaleSeo marked this pull request as ready for review September 28, 2026 16:34
@DaleSeo
DaleSeo requested a review from a team as a code owner September 28, 2026 16:34
@DaleSeo DaleSeo self-assigned this Sep 28, 2026
@DaleSeo
DaleSeo merged commit bdd93dc into main Sep 28, 2026
24 checks passed
@DaleSeo
DaleSeo deleted the DaleSeo/triage-auth-single-line branch September 28, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-CI Changes to CI/CD workflows and configuration T-config Configuration file changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants