Repository navigation
ci: reject multi-line Codex auth secret - #1306
Merged
Merged
Conversation
DaleSeo
marked this pull request as ready for review
September 28, 2026 16:34
alexhancock
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
GitHub masks each line of a multi-line secret separately. When
auth.jsonis saved ascodex loginwrites it, with pretty-printing, lines like{and}get masked. As a result, GitHub drops theclassificationjob output with a message saying, "Skip output 'classification' since it may contain secret." ThenApply labelsis silently skipped, even though the run reports success.This check makes the failure visible and tells maintainers how to reset the secret:
jq -c . auth.json | gh secret set CODEX_AUTH_JSON. A single trailing newline fromjq -cis still accepted.How Has This Been Tested?
Breaking Changes
CI-only change.
Types of changes
Checklist