Repository navigation
feat(transport): expose streamable HTTP Host header check - #1343
Draft
monody0007 wants to merge 1 commit into
Draft
monody0007 wants to merge 1 commit into
monody0007 wants to merge 1 commit into
Conversation
github-actions
Bot
added
T-test
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An authentication layer in front of the Streamable HTTP service currently runs before rmcp rejects a disallowed Host. Reusing rmcp's check requires access to its private validation helpers.
Add
StreamableHttpServerConfig::is_host_allowed(uri, headers)so middleware can check the configured allowed hosts first. The method and service share the same validator, preserving Host precedence, HTTP/2 authority fallback, port matching, and existing error responses; Origin validation is unchanged.Tested offline with 23 request cases comparing the public check against service responses, existing Host and Origin tests, library tests, a rustdoc example, formatting checks, and targeted Clippy.
Closes #1334