Repository navigation
ci(triage): request the rotation reviewer on pull requests - #1350
Merged
Merged
Conversation
Contributor
|
@bolinfest is on triage rotation this week and is the reviewer for this one. Automated classification did not run for this one, so it needs a full manual pass. Automated triage. Labels are a first pass and the assigned maintainer has the final say. |
DaleSeo
marked this pull request as ready for review
October 13, 2026 18:19
alexhancock
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The triage workflow calls
issues.addAssigneesfor both issues and pull requests. For a PR, this only sets the assignee, so the person on rotation never sees it in their "Review requests" queue. This PR updates the workflow to request the on-rotation maintainer as a reviewer on pull requests. Issues still get an assignee, as before.This PR also fixes three smaller issues with the PR workflow:
auto-label-pr.ymllabels them based on the diff.workflow_dispatchrun targeted a PR number, the workflow treated it as an issue because it used the event type to determine what kind of item it was. It now checks the item itself.Breaking Changes
None.
Types of changes
Checklist
Additional context