Skip to content

fix(test): gate cancelled response tests on stdio features #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LucaCiucci wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(test): gate cancelled response tests on stdio features #1365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/rmcp/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,3 +488,8 @@ path = "tests/test_streamable_http_disconnect_cancel.rs"
name = "test_sep_2260_stream_routing"
required-features = ["server", "elicitation", "transport-streamable-http-server", "reqwest"]
path = "tests/test_sep_2260_stream_routing.rs"

[[test]]
name = "test_cancelled_response"
path = "tests/test_cancelled_response.rs"
required-features = ["server", "transport-io"]
Comment on lines +492 to +495

@DaleSeo DaleSeo Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[[test]]
name = "test_cancelled_response"
path = "tests/test_cancelled_response.rs"
required-features = ["server", "transport-io"]
[[test]]
name = "test_cancelled_response"
required-features = ["server"]
path = "tests/test_cancelled_response.rs"

Gating the entire target on transport-io also skips the three tests here gated on client. They only use duplex and mpsc, and never touch stdio.

// tests/test_cancelled_response.rs
+#[cfg(feature = "transport-io")]
 #[tokio::test(flavor = "multi_thread", worker_threads = 4)]
 async fn cancelled_request_receives_no_response() -> anyhow::Result<()> {
 ...
+#[cfg(feature = "transport-io")]
 #[tokio::test]
 // the HELPER_ENV entry point, serve_helper_stdio, spawn_helper

Loading