Repository navigation
feat(client): allow async tool output validators (#2971) - #3011
Open
karaaslanz wants to merge 2 commits into
Open
karaaslanz wants to merge 2 commits into
karaaslanz wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 71ee58c The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonSchemaValidatoroption to provide an asyncgetValidator(schema)and/or an async validation callback.tools/call, converting rejected compilation into the existing per-tool InvalidParams error, and await validation before inspectingvalid.fromJsonSchema/server contract. Explicit per-calltoolDefinitioncontinues to compile in isolation.Refs #2971. Related #2998 modifies lazy validator-cache compilation and must be considered when integrating this change.
Verification
git diff --check: PASS.pnpminstall / Vitest / package typecheck: NOT RUN successfully. The filtered install aborted withERR_PNPM_BAD_PACKAGE_JSON: localnode_modules/.pnpm/js-yaml@4.1.1/.../package.jsoncontained NUL bytes. A direct typecheck was consequently blocked by missing workspace dependencies. No environment cleanup was attempted.Opening as a draft so reviewers can confirm the client-only API scope and #2998 interaction before a ready-for-review declaration.