Repository navigation
fix(auth): accept RFC 8414 client-credentials metadata without authorize URL (#3033) - #3034
Draft
karaaslanz wants to merge 7 commits into
Draft
karaaslanz wants to merge 7 commits into
karaaslanz wants to merge 7 commits into
Conversation
🦋 Changeset detectedLatest commit: 5df5122 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@modelcontextprotocol/client
@modelcontextprotocol/codemod
@modelcontextprotocol/core
@modelcontextprotocol/server
@modelcontextprotocol/server-legacy
@modelcontextprotocol/express
@modelcontextprotocol/fastify
@modelcontextprotocol/hono
@modelcontextprotocol/node
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Closes #3033.
RFC 8414 allows an authorization server that supports only
client_credentialsto omitauthorization_endpoint. The SDK currently rejects it inOAuthMetadataSchemabeforeClientCredentialsProvidercan request a token. The SDK's own machine-to-machine example was forced to publish a fake/authorizeendpoint.Changes
authorization_endpointoptional in the RFC 8414 OAuth metadata schema, keeping the OIDC discovery schema strict.authorization_endpointwith an actionable incompatible-server error.@modelcontextprotocol/coreand@modelcontextprotocol/client.Verification (exact latest head
5df51220a30269c894a22b53a99b5670517c663c)check:all(snippets, skills, typecheck, lint, docs),build:all, smoke-dist-types, Node 20/22/24 unit and e2e tests, and Bun/Deno runtime checks.server-legacytype guarantee that needed refining; it was corrected in commit5df51220a302, and the latest head is green.Ready for maintainer review on technical grounds once the draft-state permission issue is resolved.