Repository navigation
generate reference fields from the DFNs - #501
Merged
Merged
Conversation
A component's columns in its row in the simulation's name file keyed (fk) to the simulation's models become its reference fields, in row order: an exchange's exgmnamea/exgmnameb, a solution's slnmnames (kept as `models`). The Exchange and Solution bases keep the semantics, via a _reference_problem hook replacing reference()'s check. Binding and ingress read and set reference fields in order instead of per type. The generated modules were produced with sim-nam annotated as devtools' sim-nam-model-keys branch will annotate it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin modflow-devtools to b7c43566, which marks sim-nam's model-name columns pk/fk, and test reference field generation on the real DFNs instead of patching the keys in. Synced at the contract commit, the generated modules are unchanged. The mixin gap check now looks for an attribute a base class lacks on its leaf subclasses, since Solution.models is now generated on IMS/EMS rather than declared on Solution. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #499, instead of declaring component references by hand, derive them from the DFNs. Uses MODFLOW-ORG/modflow-devtools#396. Some stuff here will be cleaned up soon