fix(product): persist clearing color/size/tags on save#325
Open
Ibochkarev wants to merge 1 commit into
Open
Conversation
Vue ms3-combo-options omitted empty arrays from the legacy MODX form POST, so ProductDataPayloadTrait never updated cleared fields. Also sync explicitly cleared JSON fields to msProductOption and normalize empty arrays in prepareOptionValues.
Ibochkarev
marked this pull request as ready for review
June 26, 2026 13:44
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Описание
Исправлена очистка стандартных JSON-полей товара (
color,size,tags) на вкладке «Данные товара» в менеджере.При удалении всех chips Vue-компонент
ms3-combo-optionsне отправлял hidden inputs в legacy POST формы MODX.ProductDataPayloadTraitтрактовал отсутствие ключа как «поле не меняли», и старое значение оставалось вmsProductData.Изменения:
DynamicField.vue: sentinel hidden inputfield[]=при пустом массиве (по аналогии с repeater, feat(extra-fields): repeater field type (ms3-repeater) #301).ProductDataService::saveOptions(): синхронизация явно очищенных JSON-полей вmsProductOptionчерез reflection на_fields.msProductData::prepareOptionValues(): нормализация пустого массива[]вnull.Тип изменений
Связанные Issues
Closes #324
Как это было протестировано?
Конфигурация тестирования:
php -lна изменённых файлах;npm run lintдляDynamicField.vueСкриншоты (если применимо)
Чеклист
Дополнительные заметки
После merge потребуется
npm run buildвvueManager/для обновления артефактов вassets/components/minishop3/js/mgr/vue-dist/.