feat(elements): Reload manager page when static file path changes (#13235) - #81
Open
Ibochkarev wants to merge 3 commits into
Open
Ibochkarev wants to merge 3 commits into
Ibochkarev wants to merge 3 commits into
Conversation
- Backend: Element/Update sets static_file_changed in response when static_file is dirty - Frontend: add MODx.reloadIfStaticFileChanged() helper; use it in template, chunk, snippet, plugin, tv panels to reload page on path change instead of duplicating logic
Subclass cleanup() overrides dropped the reload flag for Chunk, Snippet, Plugin, and TV. Share getCleanupData(), detect via staticSourceChanged(), and cover all five processors with regression tests (modxcms#13235).
Ibochkarev
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Что сделано
Когда вы меняете путь статического файла элемента (или media source / static-флаг) и сохраняете, менеджер перезагружает страницу этого элемента. Процессор update возвращает
static_file_changed; панели вызываютMODx.reloadIfStaticFileChanged(), поэтому редактор грузит контент из нового пути вместо держания старого буфера в памяти.Все пять element update-процессоров (template, chunk, snippet, plugin, TV) делят
getCleanupData(), поэтому переопределённыеcleanup()не могут потерять флаг.Зачем нужно
Без перезагрузки второй save после смены пути пишет старый in-memory контент в новый связанный файл (modxcms#13235).
Как проверить
Связанные
Refs modxcms#13235
Оригинал: modxcms#16844