Repository navigation
Guard search_meta against invalid regex - #2428
Merged
Merged
Conversation
ItemList pre-validates its regex argument and renders an error box,
but search_meta/get_index accept a pattern from any caller -- a
plugin or out-of-tree macro -- and re.compile raises re.error from
inside the searcher context on a pattern that does not compile.
Catch re.error and yield no hits on invalid input, matching the
filter semantics of the call. A regression test pins the empty
result for a pattern that does not compile ("[[[", unterminated
character set) plus a compiling-pattern control that still matches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guard search_meta against invalid regex
ItemList pre-validates its regex argument and renders an error box,
but search_meta/get_index accept a pattern from any caller -- a
plugin or out-of-tree macro -- and re.compile raises re.error from
inside the searcher context on a pattern that does not compile.
Catch re.error and yield no hits on invalid input, matching the
filter semantics of the call. A regression test pins the empty
result for a pattern that does not compile ("[[[", unterminated
character set) plus a compiling-pattern control that still matches.