Update Dafny to version 4.11 - #7
Merged
Merged
Conversation
Owner
|
Thank you, Shaobo! I will take a look at this PR when I have more time (probably, later this week). |
And I don't know why!
Though I just brought back the old assertions
Contributor
Author
Hey Alexey, I've got all proofs fixed except for |
- drop deprecated trailing semicolons on spec clauses / var decls
- mark intentionally bodyless methods/functions/lemmas with {:axiom}
- add real proof for FoldrEqFoldl via FoldlAcc helper (was assume false)
- complete induction bodies in MapIdentity, MapCompose, NotMemberCount0
- repair GcdPos/GcdIsDivisor for the b==0, a<0 branch via DivModAdd1
- restructure FactorsSortedStrict to avoid trigger-warning forall stmt
- fix Digits decreases for n<0 and rewrite DigitsSpec via named-fold helper
- CheckDistinctSubseq early-return constructs explicit !Distinct witness
- 0027 RemoveElement gains the missing forall k<j ==> nums[k]!=val invariant
- 0053 maxSubArray gains explicit triggers to stay under the 30s budget
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- runner: ubuntu-20.04 -> ubuntu-22.04 (20.04 image was retired) - checkout@v3 -> v4 - Dafny binary fetched from the 4.11.0 release zip - replace legacy `/compile:0` with the `dafny verify` subcommand Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The 4.11.0 release ships only `dafny-4.11.0-x64-ubuntu-22.04.zip` for Linux. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Hi @monadius I let Claude code to revive this PR. It should be good to go. Could you please take a look? |
Owner
|
Thank you @shaobo-he for reviving and finishing this PR! Everything looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still failing proofs in the library (i.e.,
libfolder), and I temporarily bypass them withassume false. Some proofs in theleetcodedirectories are failing as well.@monadius I'm still working on fixing them, but please feel free to edit this PR if you have time to look into it.