refactor(core): replace non-specific CSS selectors with explicit classes - #3460
Open
orrgottlieb wants to merge 1 commit into
Open
orrgottlieb wants to merge 1 commit into
orrgottlieb wants to merge 1 commit into
Conversation
Tighten two low-specificity selector patterns found in an audit:
- Slider: replace `.disabled * { pointer-events: none }` (universal
descendant) with a `.railDisabled` marker class on SliderRail. The
rail's subtree is disabled via inherited pointer-events while the root
keeps its `not-allowed` cursor. No behavior change.
- MultiSelectedValues: replace bare `> div:first-child` and
`> div:not(.hiddenChip)` with the existing `.chipWrapperWithOverflow`
and `.inputAndCounterWrapper` classes. Behavior-equivalent.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
PR Summary by QodoRefactor core CSS selectors to target explicit classes in Slider and Dropdown
AI Description
Diagram
High-Level Assessment
Files changed (3)
|
Contributor
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTo customize comments, go to the Qodo configuration screen, or learn more in the docs. |
Contributor
|
📦 Bundle Size Analysis ✅ No bundle size changes detected. Unchanged Components
📊 Summary:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to the Toggle focus-selector cleanup. Replaces two low-specificity selector patterns (found in a repo-wide audit) with explicit class targets. Behavior-preserving.
Changes
Slider —
.disabled * { pointer-events: none }(universal descendant) → a.railDisabledmarker class applied toSliderRail. Sincepointer-eventsis inherited, disabling the rail disables its whole subtree, while the.disabledroot keepscursor: not-allowed. Same visual/interaction behavior.MultiSelectedValues — bare
divcombinator targets replaced with existing classes:> div:first-child→> .chipWrapperWithOverflow:first-child> div:not(.hiddenChip)→> .chipWrapperWithOverflow:not(.hiddenChip), > .inputAndCounterWrapper(exactly the set the old selector matched: visible chips + the input/counter wrapper)Deliberately left unchanged
TextField.textField * { box-sizing: border-box }— an idiomatic scoped reset;box-sizingisn't inherited so it can't move to the parent, and enumerating descendants would be more fragile.div { max-width: 100% }in MultiSelectedValues single-chip — targets the externalChipspackage's internals (no exposed class); out of scope.Testing
🤖 Generated with Claude Code