fix: remove Antigravity MCP registration on uninstall#44
Open
ahmedabdelkarim504-commits wants to merge 1 commit into
Open
fix: remove Antigravity MCP registration on uninstall#44ahmedabdelkarim504-commits wants to merge 1 commit into
ahmedabdelkarim504-commits wants to merge 1 commit into
Conversation
The uninstaller removed the companion binary and agent data but left the mcpServers.monk entry in ~/.gemini/config/mcp_config.json. This could cause Antigravity to expose a dead Monk MCP entry after uninstall. Adds remove_antigravity_mcp() which cleans up the registration using jq or the Python fallback, matching the pattern in register_antigravity_mcp(). Fixes monk-io#27
Author
|
/claim Fixes #27 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Adds MCP config cleanup to the uninstaller, removing the \mcpServers.monk\ entry from ~/.gemini/config/mcp_config.json\ when present.
Problem
The uninstaller removed the companion binary and agent data but left the \mcpServers.monk\ entry in Antigravity's global config. This caused Antigravity to expose a dead Monk MCP entry after uninstall, potentially showing connection failures.
How it works
Adds
emove_antigravity_mcp()\ which uses jq (or Python fallback) to delete the \monk\ key from \mcpServers, then cleans up the empty \mcpServers\ object if no other entries remain. Called before the final completion message.
Testing
Verified with the reproduction script from the issue — after uninstall, the config no longer contains the \monk\ entry while other MCP servers are preserved.
Fixes #27