Skip to content

Verify ingress status after ensure - #65

Closed
silasbrookshaha wants to merge 1 commit into
monk-io:mainfrom
silasbrookshaha:fix-ingress-ensure-disabled
Closed

Verify ingress status after ensure#65
silasbrookshaha wants to merge 1 commit into
monk-io:mainfrom
silasbrookshaha:fix-ingress-ensure-disabled

Conversation

@silasbrookshaha

Copy link
Copy Markdown

Summary

  • require agents to treat monk.cluster.ingress.ensure action success as provisional
  • require a follow-up monk.cluster.ingress.status check before reporting ingress ready
  • keep route configuration intact and surface disabled/unhealthy ingress when status remains enabled=false, lacks ready instances/endpoints, or logs enable failures
  • add a regression script that checks the deployer/editor/workflow guidance stays present in both skill copies

Tests

  • /bin/sh tests/ingress-ensure-guidance.sh

Fixes #64

@nooga

nooga commented Jul 20, 2026

Copy link
Copy Markdown
Member

Thanks for the PR. On review this only updates agent-instruction docs and skills, not the actual code path that produces the false 'succeeded' result (src/services/cluster/create.ts / manage.ts). A docs-only change doesn't fix the underlying bug. Closing for now.

@nooga nooga closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug bounty] local ingress ensure reports success but remains disabled

2 participants