Repository navigation
chore(deps): migrate to github.com/moond4rk/binarycookies/v2 - #708
Merged
Merged
Conversation
v2 decodes jars that v1 rejected whole (any cookie record over 4096 bytes) and returns strings and UTC times, so extraction drops its conversions; Safari test fixtures are now written by binarycookies.Encode.
binarycookies.Encode writes whole seconds, so the 750ms fixture offset never reached the jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #709.
Moves Safari cookie extraction to
github.com/moond4rk/binarycookies/v2atv2.0.0.extract_cookie.godrops thestring(...)and.UTC()conversions.HasExpirebecomes meaningful: v2 returns the zero time for an invalid timestamp, which v1 never did.browsertestbuilds the Safari cookie fixtures withbinarycookies.Encodeinstead of a hand-written encoder (about 80 lines removed).Release: https://github.com/moonD4rk/binarycookies/releases/tag/v2.0.0
Checklist
mainbranchbinarycookies.Encode)go 1.20(do not bump)